Skip to contentSkip to conversation

mm: Set min_free_kbytes with user_min_free_kbytes when user_min_free_kbytes is preferred

PATCH In review Liangcai Fan 2 participants 3 messages Sep 28, 2021 – Sep 29, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: Set min_free_kbytes with user_min_free_kbytes when user_min_free_kbytes is preferred

The 'min_free_kbytes' and 'user_min_free_kbytes' maybe inconsistent after a few times of memory hotplug.
When 'new_min_free_kbytes' is not larger than 'user_min_free_kbytes', set 'min_free_kbytes' with 'user_min_free_kbytes' rather than leave it as the 'new_min_free_kbytes' calculated for the last time.

---
 mm/page_alloc.c | 6 ++++++
 1 file changed, 6 insertions(+)
mm/page_alloc.c +6 -0
index b37435c..ddf9dc1 100644
@@ -8467,6 +8467,12 @@ int __meminit init_per_zone_wmark_min(void)
 		if (min_free_kbytes > 262144)
 			min_free_kbytes = 262144;
 	} else {
+		/*
+		 * Set 'min_free_kbytes' with 'user_min_free_kbytes' rather than
+		 * leave it as the 'new_min_free_kbytes' calculated for the last
+		 * time.
+		 */
+		min_free_kbytes = user_min_free_kbytes;
 		pr_warn("min_free_kbytes is not updated to %d because user defined value %d is preferred\n",
 				new_min_free_kbytes, user_min_free_kbytes);
 	}
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 2 lines · On Tue, 28 Sep 2021 20:23:17 +0800 Liangcai Fan <[email protected]> wrote:

The 'min_free_kbytes' and 'user_min_free_kbytes' maybe inconsistent after a few times of memory hotplug.

What does "inconsistent" mean here?

Please describe the problem in more detail, perhaps with examples.

Quoted 15 lines

When 'new_min_free_kbytes' is not larger than 'user_min_free_kbytes', set 'min_free_kbytes' with 'user_min_free_kbytes' rather than leave it as the 'new_min_free_kbytes' calculated for the last time.

---
 mm/page_alloc.c | 6 ++++++
 1 file changed, 6 insertions(+)
mm/page_alloc.c +0 -0
index b37435c..ddf9dc1 100644

mm/page_alloc.c int __meminit init_per_zone_wmark_min(void) · line 8474

Quoted 8 lines
mm/page_alloc.c +5 -0
@@ -8467,6 +8467,12 @@ int __meminit init_per_zone_wmark_min(void)
 		if (min_free_kbytes > 262144)
 			min_free_kbytes = 262144;
 	} else {
+		/*
+		 * Set 'min_free_kbytes' with 'user_min_free_kbytes' rather than
+		 * leave it as the 'new_min_free_kbytes' calculated for the last
+		 * time.
+		 */

This comment explains what the code is doing, which is almost always obvious from reading the code! A better comment will describe *why*
the code is doing whatever is does. "why, not what", please.

Quoted 4 lines
mm/page_alloc.c +1 -0
+		min_free_kbytes = user_min_free_kbytes;
 		pr_warn("min_free_kbytes is not updated to %d because user defined value %d is preferred\n",
 				new_min_free_kbytes, user_min_free_kbytes);
 	}
#2 lore raw
Quoted 10 lines · Andrew Morton <[email protected]> 于2021年9月29日周三 上午6:29写道:
Quoted 2 lines · On Tue, 28 Sep 2021 20:23:17 +0800 Liangcai Fan <[email protected]> wrote:

The 'min_free_kbytes' and 'user_min_free_kbytes' maybe inconsistent after a few times of memory hotplug.

What does "inconsistent" mean here?

Please describe the problem in more detail, perhaps with examples.

example:
1. Turn on the device with 1G memory, and the calculated 'new_min_free_kbytes' is 3452kb, at this time 'min_free_kbytes' = 'new_min_free_kbytes' = 3452kb, 'user_min_free_kbytes' is the initial value -1.

2. The user sets 'min_free_kbytes' to 4096kb through the node, at this time 'user_min_free_kbytes' = 'min_free_kbytes' = 4096kb.

3. The memory has increased by 2G, and the memory has become 3G. Recalculate 'new_min_free_kbytes' to be 6568kb, which is greater than 'user_min_free_kbytes'(4096kb), at this time 'min_free_kbytes' = 'new_min_free_kbytes' = 6568kb, 'user_min_free_kbytes' = 4096kb.

4. The memory has been reduced by 2G, and now the memory has become 1G. Recalculate 'new_min_free_kbytes' to be 3452kb, which is less than 'user_min_free_kbytes'(4096kb). The original logic does not modify 'min_free_kbytes'.
At this time, 'min_free_kbytes' is the last 'new_min_free_kbytes'(6568kb). The memory is 1G ,'min_free_kbytes' should be equal to 'user_min_free_kbytes'(4096kb)
set by the user.

Quoted 19 lines
Quoted 19 lines

When 'new_min_free_kbytes' is not larger than 'user_min_free_kbytes', set 'min_free_kbytes' with 'user_min_free_kbytes' rather than leave it as the 'new_min_free_kbytes' calculated for the last time.

---
 mm/page_alloc.c | 6 ++++++
 1 file changed, 6 insertions(+)
mm/page_alloc.c +1 -0
index b37435c..ddf9dc1 100644
@@ -8467,6 +8467,12 @@ int __meminit init_per_zone_wmark_min(void)
              if (min_free_kbytes > 262144)
                      min_free_kbytes = 262144;
      } else {
+             /*
Quoted 9 lines

mm/page_alloc.c int __meminit init_per_zone_wmark_min(void) · line 8474

Quoted 4 lines
mm/page_alloc.c +4 -0
+              * Set 'min_free_kbytes' with 'user_min_free_kbytes' rather than
+              * leave it as the 'new_min_free_kbytes' calculated for the last
+              * time.
+              */

This comment explains what the code is doing, which is almost always obvious from reading the code! A better comment will describe *why*
the code is doing whatever is does. "why, not what", please.

I think this comment is redundant and will be deleted.

Quoted 5 lines
Quoted 4 lines
mm/page_alloc.c +1 -0
+             min_free_kbytes = user_min_free_kbytes;
              pr_warn("min_free_kbytes is not updated to %d because user defined value %d is preferred\n",
                              new_min_free_kbytes, user_min_free_kbytes);
      }