Skip to contentSkip to conversation

samples/bpf: relicense bpf_insn.h as GPL-2.0-only OR BSD-2-Clause

PATCH Applied [email protected] 12 participants 19 messages Sep 23, 2021 – Sep 29, 2021 2 messages not in the archive BPF

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 samples/bpf: relicense bpf_insn.h as GPL-2.0-only OR BSD-2-Clause

From: Luca Boccassi <[email protected]>

libbpf and bpftool have been dual-licensed to facilitate inclusion in software that is not compatible with GPL2-only (ie: Apache2), but the samples are still GPL2-only.

Given these files are samples, they get naturally copied around. For example it is the case for samples/bpf/bpf_insn.h which was copied into the systemd
tree: https://github.com/systemd/systemd/blob/main/src/shared/linux/bpf_insn.h

Dual-license this header as GPL-2.0-only OR BSD-2-Clause to follow the same licensing used by libbpf and bpftool:

1bc38b8ff6cc ("libbpf: relicense libbpf as LGPL-2.1 OR BSD-2-Clause") 907b22365115 ("tools: bpftool: dual license all files")

---
Most of systemd is (L)GPL2-or-later, which means there is no perceived incompatibility with Apache2 softwares and can thus be linked with OpenSSL 3.0. But given this GPL2-only header is included this is currently not possible.
Dual-licensing this header solves this problem for us as we are scoping moving to OpenSSL 3.0, see:

https://lists.freedesktop.org/archives/systemd-devel/2021-September/046882.html

The authors of this file according to git log are:

Alexei Starovoitov <[email protected]>
Björn Töpel <[email protected]>
Brendan Jackman <[email protected]>
Chenbo Feng <[email protected]>
Daniel Borkmann <[email protected]>
Daniel Mack <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>
Joe Stringer <[email protected]>
Josef Bacik <[email protected]>

(excludes a commit adding the SPDX header)

All authors and maintainers are CC'ed. An Acked-by from everyone in the above list of authors will be necessary.

One could probably argue for relicensing all the samples/bpf/ files given both libbpf and bpftool are, however the authors list would be much larger and thus it would be much more difficult, so I'd really appreciate if this header could be handled first by itself, as it solves a real license incompatibility issue we are currently facing.

 samples/bpf/bpf_insn.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
samples/bpf/bpf_insn.h +1 -1
index aee04534483a..29c3bb6ad1cd 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
 /* eBPF instruction mini library */
 #ifndef __BPF_INSN_H
 #define __BPF_INSN_H
Signature · 1 line
2.33.0
#1 lore raw
Quoted 70 lines · On Thu, 2021-09-23 at 01:05 +0100, [email protected] wrote:

From: Luca Boccassi <[email protected]>

libbpf and bpftool have been dual-licensed to facilitate inclusion in software that is not compatible with GPL2-only (ie: Apache2), but the samples are still GPL2-only.

Given these files are samples, they get naturally copied around. For example
it is the case for samples/bpf/bpf_insn.h which was copied into the systemd
tree:
https://github.com/systemd/systemd/blob/main/src/shared/linux/bpf_insn.h

Dual-license this header as GPL-2.0-only OR BSD-2-Clause to follow the same licensing used by libbpf and bpftool:

1bc38b8ff6cc ("libbpf: relicense libbpf as LGPL-2.1 OR BSD-2-Clause") 907b22365115 ("tools: bpftool: dual license all files")

---
Most of systemd is (L)GPL2-or-later, which means there is no perceived
incompatibility with Apache2 softwares and can thus be linked with OpenSSL 3.0. But given this GPL2-only header is included this is currently
not possible.
Dual-licensing this header solves this problem for us as we are scoping
moving to OpenSSL 3.0, see:

https://lists.freedesktop.org/archives/systemd-devel/2021-September/046882.html

The authors of this file according to git log are:

Alexei Starovoitov <[email protected]>
Björn Töpel <[email protected]>
Brendan Jackman <[email protected]>
Chenbo Feng <[email protected]>
Daniel Borkmann <[email protected]>
Daniel Mack <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>
Joe Stringer <[email protected]>
Josef Bacik <[email protected]>

(excludes a commit adding the SPDX header)

All authors and maintainers are CC'ed. An Acked-by from everyone in the
above list of authors will be necessary.

One could probably argue for relicensing all the samples/bpf/ files given both
libbpf and bpftool are, however the authors list would be much larger and thus
it would be much more difficult, so I'd really appreciate if this header could
be handled first by itself, as it solves a real license incompatibility issue
we are currently facing.

 samples/bpf/bpf_insn.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
samples/bpf/bpf_insn.h +0 -0
index aee04534483a..29c3bb6ad1cd 100644

samples/bpf/bpf_insn.h line 4

Quoted 5 lines
samples/bpf/bpf_insn.h +1 -1
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
  /* eBPF instruction mini library */
  #ifndef __BPF_INSN_H
  #define __BPF_INSN_H

Got "address not found" for the following:

Björn Töpel <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>

Trying again with different aliases from more recent commits for Björn and Jakub.

I cannot find other commits from Jiong with a different email address - Jakub, do you happen to know how we can reach Jiong? Perhaps it's not necessary as it's Netronome that owns the copyright and thus your ack would cover both contributions?

Signature · 2 lines
Kind regards,
Luca Boccassi
#2 lore raw

2021-09-23 11:41 UTC+0100 ~ Luca Boccassi <[email protected]>

Quoted 83 lines · On Thu, 2021-09-23 at 01:05 +0100, [email protected] wrote:
Quoted 70 lines

From: Luca Boccassi <[email protected]>

libbpf and bpftool have been dual-licensed to facilitate inclusion in software that is not compatible with GPL2-only (ie: Apache2), but the samples are still GPL2-only.

Given these files are samples, they get naturally copied around. For example
it is the case for samples/bpf/bpf_insn.h which was copied into the systemd
tree:
https://github.com/systemd/systemd/blob/main/src/shared/linux/bpf_insn.h

Dual-license this header as GPL-2.0-only OR BSD-2-Clause to follow the same licensing used by libbpf and bpftool:

1bc38b8ff6cc ("libbpf: relicense libbpf as LGPL-2.1 OR BSD-2-Clause") 907b22365115 ("tools: bpftool: dual license all files")

---
Most of systemd is (L)GPL2-or-later, which means there is no perceived
incompatibility with Apache2 softwares and can thus be linked with OpenSSL 3.0. But given this GPL2-only header is included this is currently
not possible.
Dual-licensing this header solves this problem for us as we are scoping
moving to OpenSSL 3.0, see:

https://lists.freedesktop.org/archives/systemd-devel/2021-September/046882.html

The authors of this file according to git log are:

Alexei Starovoitov <[email protected]>
Björn Töpel <[email protected]>
Brendan Jackman <[email protected]>
Chenbo Feng <[email protected]>
Daniel Borkmann <[email protected]>
Daniel Mack <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>
Joe Stringer <[email protected]>
Josef Bacik <[email protected]>

(excludes a commit adding the SPDX header)

All authors and maintainers are CC'ed. An Acked-by from everyone in the
above list of authors will be necessary.

One could probably argue for relicensing all the samples/bpf/ files given both
libbpf and bpftool are, however the authors list would be much larger and thus
it would be much more difficult, so I'd really appreciate if this header could
be handled first by itself, as it solves a real license incompatibility issue
we are currently facing.

 samples/bpf/bpf_insn.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
samples/bpf/bpf_insn.h +0 -0
index aee04534483a..29c3bb6ad1cd 100644

samples/bpf/bpf_insn.h line 4

Quoted 5 lines
samples/bpf/bpf_insn.h +1 -1
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
  /* eBPF instruction mini library */
  #ifndef __BPF_INSN_H
  #define __BPF_INSN_H

Got "address not found" for the following:

Björn Töpel <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>

Quoted 8 lines

Trying again with different aliases from more recent commits for Björn and Jakub.

I cannot find other commits from Jiong with a different email address - Jakub, do you happen to know how we can reach Jiong? Perhaps it's not necessary as it's Netronome that owns the copyright and thus your ack would cover both contributions?

Hi Luca, I believe Simon can handle this for Netronome, I'm adding him in copy.

Quentin

Acked-by
#3 lore raw
Quoted 87 lines · Quentin Monnet

2021-09-23 11:41 UTC+0100 ~ Luca Boccassi <[email protected]>

Quoted 86 lines · On Thu, 2021-09-23 at 01:05 +0100, [email protected] wrote:
Quoted 70 lines

From: Luca Boccassi <[email protected]>

libbpf and bpftool have been dual-licensed to facilitate inclusion in software that is not compatible with GPL2-only (ie: Apache2), but the samples are still GPL2-only.

Given these files are samples, they get naturally copied around. For example
it is the case for samples/bpf/bpf_insn.h which was copied into the systemd
tree:
https://github.com/systemd/systemd/blob/main/src/shared/linux/bpf_insn.h

Dual-license this header as GPL-2.0-only OR BSD-2-Clause to follow the same licensing used by libbpf and bpftool:

1bc38b8ff6cc ("libbpf: relicense libbpf as LGPL-2.1 OR BSD-2-Clause") 907b22365115 ("tools: bpftool: dual license all files")

---
Most of systemd is (L)GPL2-or-later, which means there is no perceived
incompatibility with Apache2 softwares and can thus be linked with OpenSSL 3.0. But given this GPL2-only header is included this is currently
not possible.
Dual-licensing this header solves this problem for us as we are scoping
moving to OpenSSL 3.0, see:

https://lists.freedesktop.org/archives/systemd-devel/2021-September/046882.html

The authors of this file according to git log are:

Alexei Starovoitov <[email protected]>
Björn Töpel <[email protected]>
Brendan Jackman <[email protected]>
Chenbo Feng <[email protected]>
Daniel Borkmann <[email protected]>
Daniel Mack <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>
Joe Stringer <[email protected]>
Josef Bacik <[email protected]>

(excludes a commit adding the SPDX header)

All authors and maintainers are CC'ed. An Acked-by from everyone in the
above list of authors will be necessary.

One could probably argue for relicensing all the samples/bpf/ files given both
libbpf and bpftool are, however the authors list would be much larger and thus
it would be much more difficult, so I'd really appreciate if this header could
be handled first by itself, as it solves a real license incompatibility issue
we are currently facing.

 samples/bpf/bpf_insn.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
samples/bpf/bpf_insn.h +0 -0
index aee04534483a..29c3bb6ad1cd 100644

samples/bpf/bpf_insn.h line 4

Quoted 5 lines
samples/bpf/bpf_insn.h +1 -1
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
  /* eBPF instruction mini library */
  #ifndef __BPF_INSN_H
  #define __BPF_INSN_H

Got "address not found" for the following:

Björn Töpel <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>

Trying again with different aliases from more recent commits for Björn and Jakub.

Quoted 8 lines
Quoted 5 lines

I cannot find other commits from Jiong with a different email address - Jakub, do you happen to know how we can reach Jiong? Perhaps it's not necessary as it's Netronome that owns the copyright and thus your ack would cover both contributions?

Hi Luca, I believe Simon can handle this for Netronome, I'm adding him in copy.

Yes, in the recent past we have handled a similar request like this:

#4 lore raw
In reply to Luca Boccassi
Quoted 83 lines · Luca Boccassi
Quoted 70 lines · On Thu, 2021-09-23 at 01:05 +0100, [email protected] wrote:

From: Luca Boccassi <[email protected]>

libbpf and bpftool have been dual-licensed to facilitate inclusion in software that is not compatible with GPL2-only (ie: Apache2), but the samples are still GPL2-only.

Given these files are samples, they get naturally copied around. For example
it is the case for samples/bpf/bpf_insn.h which was copied into the systemd
tree:
https://github.com/systemd/systemd/blob/main/src/shared/linux/bpf_insn.h

Dual-license this header as GPL-2.0-only OR BSD-2-Clause to follow the same licensing used by libbpf and bpftool:

1bc38b8ff6cc ("libbpf: relicense libbpf as LGPL-2.1 OR BSD-2-Clause") 907b22365115 ("tools: bpftool: dual license all files")

---
Most of systemd is (L)GPL2-or-later, which means there is no perceived
incompatibility with Apache2 softwares and can thus be linked with OpenSSL 3.0. But given this GPL2-only header is included this is currently
not possible.
Dual-licensing this header solves this problem for us as we are scoping
moving to OpenSSL 3.0, see:

https://lists.freedesktop.org/archives/systemd-devel/2021-September/046882.html

The authors of this file according to git log are:

Alexei Starovoitov <[email protected]>
Björn Töpel <[email protected]>
Brendan Jackman <[email protected]>
Chenbo Feng <[email protected]>
Daniel Borkmann <[email protected]>
Daniel Mack <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>
Joe Stringer <[email protected]>
Josef Bacik <[email protected]>

(excludes a commit adding the SPDX header)

All authors and maintainers are CC'ed. An Acked-by from everyone in the
above list of authors will be necessary.

One could probably argue for relicensing all the samples/bpf/ files given both
libbpf and bpftool are, however the authors list would be much larger and thus
it would be much more difficult, so I'd really appreciate if this header could
be handled first by itself, as it solves a real license incompatibility issue
we are currently facing.

 samples/bpf/bpf_insn.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
samples/bpf/bpf_insn.h +0 -0
index aee04534483a..29c3bb6ad1cd 100644

samples/bpf/bpf_insn.h line 4

Quoted 5 lines
samples/bpf/bpf_insn.h +1 -1
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
  /* eBPF instruction mini library */
  #ifndef __BPF_INSN_H
  #define __BPF_INSN_H

Got "address not found" for the following:

Björn Töpel <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>

Quoted 7 lines

Trying again with different aliases from more recent commits for Björn and Jakub.

I cannot find other commits from Jiong with a different email address - Jakub, do you happen to know how we can reach Jiong? Perhaps it's not necessary as it's Netronome that owns the copyright and thus your ack would cover both contributions?

Gentle ping. We got ACKs from Netronome and Google so far (thanks!).

Signature · 2 lines
Kind regards,
Luca Boccassi
Acked-by
#5 lore raw
Quoted 87 lines · Luca Boccassi
Quoted 86 lines · Luca Boccassi
Quoted 70 lines · On Thu, 2021-09-23 at 01:05 +0100, [email protected] wrote:

From: Luca Boccassi <[email protected]>

libbpf and bpftool have been dual-licensed to facilitate inclusion in software that is not compatible with GPL2-only (ie: Apache2), but the samples are still GPL2-only.

Given these files are samples, they get naturally copied around. For example
it is the case for samples/bpf/bpf_insn.h which was copied into the systemd
tree:
https://github.com/systemd/systemd/blob/main/src/shared/linux/bpf_insn.h

Dual-license this header as GPL-2.0-only OR BSD-2-Clause to follow the same licensing used by libbpf and bpftool:

1bc38b8ff6cc ("libbpf: relicense libbpf as LGPL-2.1 OR BSD-2-Clause") 907b22365115 ("tools: bpftool: dual license all files")

---
Most of systemd is (L)GPL2-or-later, which means there is no perceived
incompatibility with Apache2 softwares and can thus be linked with OpenSSL 3.0. But given this GPL2-only header is included this is currently
not possible.
Dual-licensing this header solves this problem for us as we are scoping
moving to OpenSSL 3.0, see:

https://lists.freedesktop.org/archives/systemd-devel/2021-September/046882.html

The authors of this file according to git log are:

Alexei Starovoitov <[email protected]>
Björn Töpel <[email protected]>
Brendan Jackman <[email protected]>
Chenbo Feng <[email protected]>
Daniel Borkmann <[email protected]>
Daniel Mack <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>
Joe Stringer <[email protected]>
Josef Bacik <[email protected]>

(excludes a commit adding the SPDX header)

All authors and maintainers are CC'ed. An Acked-by from everyone in the
above list of authors will be necessary.

One could probably argue for relicensing all the samples/bpf/ files given both
libbpf and bpftool are, however the authors list would be much larger and thus
it would be much more difficult, so I'd really appreciate if this header could
be handled first by itself, as it solves a real license incompatibility issue
we are currently facing.

 samples/bpf/bpf_insn.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
samples/bpf/bpf_insn.h +0 -0
index aee04534483a..29c3bb6ad1cd 100644

samples/bpf/bpf_insn.h line 4

Quoted 5 lines
samples/bpf/bpf_insn.h +1 -1
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
  /* eBPF instruction mini library */
  #ifndef __BPF_INSN_H
  #define __BPF_INSN_H

Got "address not found" for the following:

Björn Töpel <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>

Trying again with different aliases from more recent commits for Björn and Jakub.

Quoted 7 lines
Quoted 4 lines

I cannot find other commits from Jiong with a different email address - Jakub, do you happen to know how we can reach Jiong? Perhaps it's not necessary as it's Netronome that owns the copyright and thus your ack would cover both contributions?

Gentle ping. We got ACKs from Netronome and Google so far (thanks!).

For my bits:

Thanks,
Daniel

#6 lore raw
In reply to [email protected]
Quoted 59 lines · On Thu, 2021-09-23 at 01:05 +0100, [email protected] wrote:

From: Luca Boccassi <[email protected]>

libbpf and bpftool have been dual-licensed to facilitate inclusion in software that is not compatible with GPL2-only (ie: Apache2), but the samples are still GPL2-only.

Given these files are samples, they get naturally copied around. For example it is the case for samples/bpf/bpf_insn.h which was copied into the systemd
tree: https://github.com/systemd/systemd/blob/main/src/shared/linux/bpf_insn.h

Dual-license this header as GPL-2.0-only OR BSD-2-Clause to follow the same licensing used by libbpf and bpftool:

1bc38b8ff6cc ("libbpf: relicense libbpf as LGPL-2.1 OR BSD-2-Clause") 907b22365115 ("tools: bpftool: dual license all files")

---
Most of systemd is (L)GPL2-or-later, which means there is no perceived incompatibility with Apache2 softwares and can thus be linked with OpenSSL 3.0. But given this GPL2-only header is included this is currently not possible.
Dual-licensing this header solves this problem for us as we are scoping moving to OpenSSL 3.0, see:

https://lists.freedesktop.org/archives/systemd-devel/2021-September/046882.html

The authors of this file according to git log are:

Alexei Starovoitov <[email protected]>
Björn Töpel <[email protected]>
Brendan Jackman <[email protected]>
Chenbo Feng <[email protected]>
Daniel Borkmann <[email protected]>
Daniel Mack <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>
Joe Stringer <[email protected]>
Josef Bacik <[email protected]>

(excludes a commit adding the SPDX header)

All authors and maintainers are CC'ed. An Acked-by from everyone in the above list of authors will be necessary.

One could probably argue for relicensing all the samples/bpf/ files given both libbpf and bpftool are, however the authors list would be much larger and thus it would be much more difficult, so I'd really appreciate if this header could be handled first by itself, as it solves a real license incompatibility issue we are currently facing.

 samples/bpf/bpf_insn.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
samples/bpf/bpf_insn.h +0 -0
index aee04534483a..29c3bb6ad1cd 100644

samples/bpf/bpf_insn.h line 4

Quoted 5 lines
samples/bpf/bpf_insn.h +1 -1
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
  /* eBPF instruction mini library */
  #ifndef __BPF_INSN_H
  #define __BPF_INSN_H

CC'ing Josef with a different address as requested.

Signature · 2 lines
Kind regards,
Luca Boccassi
Acked-by
#7 lore raw
Quoted 55 lines · Luca Boccassi
Quoted 54 lines · On Thu, 2021-09-23 at 01:05 +0100, [email protected] wrote:

From: Luca Boccassi <[email protected]>

libbpf and bpftool have been dual-licensed to facilitate inclusion in software that is not compatible with GPL2-only (ie: Apache2), but the samples are still GPL2-only.

Given these files are samples, they get naturally copied around. For example it is the case for samples/bpf/bpf_insn.h which was copied into the systemd
tree: https://github.com/systemd/systemd/blob/main/src/shared/linux/bpf_insn.h

Dual-license this header as GPL-2.0-only OR BSD-2-Clause to follow the same licensing used by libbpf and bpftool:

1bc38b8ff6cc ("libbpf: relicense libbpf as LGPL-2.1 OR BSD-2-Clause") 907b22365115 ("tools: bpftool: dual license all files")

---
Most of systemd is (L)GPL2-or-later, which means there is no perceived incompatibility with Apache2 softwares and can thus be linked with OpenSSL 3.0. But given this GPL2-only header is included this is currently not possible.
Dual-licensing this header solves this problem for us as we are scoping moving to OpenSSL 3.0, see:

https://lists.freedesktop.org/archives/systemd-devel/2021-September/046882.html

The authors of this file according to git log are:

Alexei Starovoitov <[email protected]>
Björn Töpel <[email protected]>
Brendan Jackman <[email protected]>
Chenbo Feng <[email protected]>
Daniel Borkmann <[email protected]>
Daniel Mack <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>
Joe Stringer <[email protected]>
Josef Bacik <[email protected]>

(excludes a commit adding the SPDX header)

All authors and maintainers are CC'ed. An Acked-by from everyone in the above list of authors will be necessary.

One could probably argue for relicensing all the samples/bpf/ files given both libbpf and bpftool are, however the authors list would be much larger and thus it would be much more difficult, so I'd really appreciate if this header could be handled first by itself, as it solves a real license incompatibility issue we are currently facing.

  samples/bpf/bpf_insn.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

samples/bpf/bpf_insn.h line 4

Quoted 10 lines
samples/bpf/bpf_insn.h +1 -1
index aee04534483a..29c3bb6ad1cd 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
  /* eBPF instruction mini library */
  #ifndef __BPF_INSN_H
  #define __BPF_INSN_H

CC'ing Josef with a different address as requested.

Thanks, my @fb email gets mangled so I don't use it anymore. You can add

Josef

#8 lore raw
In reply to [email protected]
Quoted 59 lines · On Thu, 2021-09-23 at 01:05 +0100, [email protected] wrote:

From: Luca Boccassi <[email protected]>

libbpf and bpftool have been dual-licensed to facilitate inclusion in software that is not compatible with GPL2-only (ie: Apache2), but the samples are still GPL2-only.

Given these files are samples, they get naturally copied around. For example it is the case for samples/bpf/bpf_insn.h which was copied into the systemd
tree: https://github.com/systemd/systemd/blob/main/src/shared/linux/bpf_insn.h

Dual-license this header as GPL-2.0-only OR BSD-2-Clause to follow the same licensing used by libbpf and bpftool:

1bc38b8ff6cc ("libbpf: relicense libbpf as LGPL-2.1 OR BSD-2-Clause") 907b22365115 ("tools: bpftool: dual license all files")

---
Most of systemd is (L)GPL2-or-later, which means there is no perceived incompatibility with Apache2 softwares and can thus be linked with OpenSSL 3.0. But given this GPL2-only header is included this is currently not possible.
Dual-licensing this header solves this problem for us as we are scoping moving to OpenSSL 3.0, see:

https://lists.freedesktop.org/archives/systemd-devel/2021-September/046882.html

The authors of this file according to git log are:

Alexei Starovoitov <[email protected]>
Björn Töpel <[email protected]>
Brendan Jackman <[email protected]>
Chenbo Feng <[email protected]>
Daniel Borkmann <[email protected]>
Daniel Mack <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>
Joe Stringer <[email protected]>
Josef Bacik <[email protected]>

(excludes a commit adding the SPDX header)

All authors and maintainers are CC'ed. An Acked-by from everyone in the above list of authors will be necessary.

One could probably argue for relicensing all the samples/bpf/ files given both libbpf and bpftool are, however the authors list would be much larger and thus it would be much more difficult, so I'd really appreciate if this header could be handled first by itself, as it solves a real license incompatibility issue we are currently facing.

 samples/bpf/bpf_insn.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
samples/bpf/bpf_insn.h +0 -0
index aee04534483a..29c3bb6ad1cd 100644

samples/bpf/bpf_insn.h line 4

Quoted 5 lines
samples/bpf/bpf_insn.h +1 -1
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
  /* eBPF instruction mini library */
  #ifndef __BPF_INSN_H
  #define __BPF_INSN_H

Gentle ping. Björn and Joe, would be great to hear from you on the above. TIA!

Signature · 2 lines
Kind regards,
Luca Boccassi
Acked-by
#9 lore raw
Quoted 1 line · Luca Boccassi

[...]

Quoted 4 lines

Gentle ping. Björn and Joe, would be great to hear from you on the above. TIA!

Luca, apologies for the slow response. I'm no longer at Intel, and I'm not sure if an Intel-person needs to do anything? Magnus, do you know?

FWIW:

Quoted 3 lines

--
Kind regards,
Luca Boccassi

#10 lore raw
Quoted 10 lines · Björn Töpel
Quoted 1 line · Luca Boccassi

[...]

Quoted 4 lines

Gentle ping. Björn and Joe, would be great to hear from you on the above. TIA!

Quoted 5 lines

Luca, apologies for the slow response. I'm no longer at Intel, and I'm not sure if an Intel-person needs to do anything? Magnus, do you know?

FWIW:

No worries! Unless you had an arrangement in place that made you the copyright owner of that contribution (eg: it was done in spare time, etc), then yes we'd need an ack to the relicense from an intel.com email address to be above board.

John, is this something you could help with, using your manager hat? Full context:

https://lore.kernel.org/bpf/[email protected]/T/#u

Signature · 2 lines
Kind regards,
Luca Boccassi
#11 lore raw
Quoted 15 lines · Luca Boccassi
Quoted 13 lines · Björn Töpel
Quoted 1 line · Luca Boccassi

[...]

Quoted 4 lines

Gentle ping. Björn and Joe, would be great to hear from you on the above. TIA!

Luca, apologies for the slow response. I'm no longer at Intel, and I'm not sure if an Intel-person needs to do anything? Magnus, do you know?

Quoted 7 lines
Quoted 2 lines

FWIW:

No worries! Unless you had an arrangement in place that made you the copyright owner of that contribution (eg: it was done in spare time, etc), then yes we'd need an ack to the relicense from an intel.com email address to be above board.

Will this do?

Quoted 8 lines

John, is this something you could help with, using your manager hat? Full context:

https://lore.kernel.org/bpf/[email protected]/T/#u

--
Kind regards,
Luca Boccassi

#12 lore raw
Quoted 19 lines · Magnus Karlsson
Quoted 18 lines · Luca Boccassi
Quoted 15 lines · Björn Töpel
Quoted 1 line · Luca Boccassi

[...]

Quoted 4 lines

Gentle ping. Björn and Joe, would be great to hear from you on the above. TIA!

Luca, apologies for the slow response. I'm no longer at Intel, and I'm not sure if an Intel-person needs to do anything? Magnus, do you know?

FWIW:

Quoted 8 lines
Quoted 4 lines

No worries! Unless you had an arrangement in place that made you the copyright owner of that contribution (eg: it was done in spare time, etc), then yes we'd need an ack to the relicense from an intel.com email address to be above board.

Will this do?

Good enough for me, thank you!

Signature · 2 lines
Kind regards,
Luca Boccassi

A message that is not in the archive (sent off-list or not yet received): CA+i-1C3sjrwtskbSZzera7ANL8dTiVWMBwLRhe=+1Ft6NgfL=A@mail.gmail.com

Acked-by
#14 lore raw
Quoted 63 lines · Brendan Jackman
Quoted 26 lines · On Thu, 23 Sept 2021 at 02:06, <[email protected]> wrote:

From: Luca Boccassi <[email protected]>

libbpf and bpftool have been dual-licensed to facilitate inclusion in software that is not compatible with GPL2-only (ie: Apache2), but the samples are still GPL2-only.

Given these files are samples, they get naturally copied around. For example it is the case for samples/bpf/bpf_insn.h which was copied into the systemd
tree: https://github.com/systemd/systemd/blob/main/src/shared/linux/bpf_insn.h

Dual-license this header as GPL-2.0-only OR BSD-2-Clause to follow the same licensing used by libbpf and bpftool:

1bc38b8ff6cc ("libbpf: relicense libbpf as LGPL-2.1 OR BSD-2-Clause") 907b22365115 ("tools: bpftool: dual license all files")

---
Most of systemd is (L)GPL2-or-later, which means there is no perceived incompatibility with Apache2 softwares and can thus be linked with OpenSSL 3.0. But given this GPL2-only header is included this is currently not possible.
Dual-licensing this header solves this problem for us as we are scoping moving to OpenSSL 3.0, see:

Quoted 7 lines

https://lists.freedesktop.org/archives/systemd-devel/2021-September/046882.html

The authors of this file according to git log are:

Alexei Starovoitov <[email protected]>
Björn Töpel <[email protected]>
Brendan Jackman <[email protected]>

Quoted 22 lines

Chenbo Feng <[email protected]>
Daniel Borkmann <[email protected]>
Daniel Mack <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>
Joe Stringer <[email protected]>
Josef Bacik <[email protected]>

(excludes a commit adding the SPDX header)

All authors and maintainers are CC'ed. An Acked-by from everyone in the above list of authors will be necessary.

One could probably argue for relicensing all the samples/bpf/ files given both libbpf and bpftool are, however the authors list would be much larger and thus it would be much more difficult, so I'd really appreciate if this header could be handled first by itself, as it solves a real license incompatibility issue we are currently facing.

 samples/bpf/bpf_insn.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines
Quoted 11 lines
samples/bpf/bpf_insn.h +1 -2
index aee04534483a..29c3bb6ad1cd 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
 /* eBPF instruction mini library */
 #ifndef __BPF_INSN_H
 #define __BPF_INSN_H
--
Quoted 2 lines

2.33.0

A message that is not in the archive (sent off-list or not yet received): CAMOXUJ=gLLCDv0ZuEz77Qvepx9r0uTfy3J3phWuGPMQXsM1FGA@mail.gmail.com

Acked-by
#16 lore raw
Quoted 84 lines · Chenbo Feng
Quoted 80 lines · Joe Stringer
Quoted 63 lines · Brendan Jackman
Quoted 26 lines · On Thu, 23 Sept 2021 at 02:06, <[email protected]> wrote:

From: Luca Boccassi <[email protected]>

libbpf and bpftool have been dual-licensed to facilitate inclusion in software that is not compatible with GPL2-only (ie: Apache2), but the samples are still GPL2-only.

Given these files are samples, they get naturally copied around. For example it is the case for samples/bpf/bpf_insn.h which was copied into the systemd
tree: https://github.com/systemd/systemd/blob/main/src/shared/linux/bpf_insn.h

Dual-license this header as GPL-2.0-only OR BSD-2-Clause to follow the same licensing used by libbpf and bpftool:

1bc38b8ff6cc ("libbpf: relicense libbpf as LGPL-2.1 OR BSD-2-Clause") 907b22365115 ("tools: bpftool: dual license all files")

---
Most of systemd is (L)GPL2-or-later, which means there is no perceived incompatibility with Apache2 softwares and can thus be linked with OpenSSL 3.0. But given this GPL2-only header is included this is currently not possible.
Dual-licensing this header solves this problem for us as we are scoping moving to OpenSSL 3.0, see:

Quoted 7 lines

https://lists.freedesktop.org/archives/systemd-devel/2021-September/046882.html

The authors of this file according to git log are:

Alexei Starovoitov <[email protected]>
Björn Töpel <[email protected]>
Brendan Jackman <[email protected]>

Quoted 22 lines

Chenbo Feng <[email protected]>
Daniel Borkmann <[email protected]>
Daniel Mack <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>
Joe Stringer <[email protected]>
Josef Bacik <[email protected]>

(excludes a commit adding the SPDX header)

All authors and maintainers are CC'ed. An Acked-by from everyone in the above list of authors will be necessary.

One could probably argue for relicensing all the samples/bpf/ files given both libbpf and bpftool are, however the authors list would be much larger and thus it would be much more difficult, so I'd really appreciate if this header could be handled first by itself, as it solves a real license incompatibility issue we are currently facing.

 samples/bpf/bpf_insn.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines
Quoted 11 lines
samples/bpf/bpf_insn.h +1 -2
index aee04534483a..29c3bb6ad1cd 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
 /* eBPF instruction mini library */
 #ifndef __BPF_INSN_H
 #define __BPF_INSN_H
--
Quoted 2 lines

2.33.0

Acked-by Brendan Jackman Acked-by Chenbo Feng Acked-by Joe Stringer Acked-by Simon Horman Acked-by Daniel Mack Acked-by Josef Bacik Acked-by Magnus Karlsson on v1 1/1
#17 lore raw
In reply to [email protected]
Quoted 59 lines · On Thu, 2021-09-23 at 01:05 +0100, [email protected] wrote:

From: Luca Boccassi <[email protected]>

libbpf and bpftool have been dual-licensed to facilitate inclusion in software that is not compatible with GPL2-only (ie: Apache2), but the samples are still GPL2-only.

Given these files are samples, they get naturally copied around. For example it is the case for samples/bpf/bpf_insn.h which was copied into the systemd
tree: https://github.com/systemd/systemd/blob/main/src/shared/linux/bpf_insn.h

Dual-license this header as GPL-2.0-only OR BSD-2-Clause to follow the same licensing used by libbpf and bpftool:

1bc38b8ff6cc ("libbpf: relicense libbpf as LGPL-2.1 OR BSD-2-Clause") 907b22365115 ("tools: bpftool: dual license all files")

---
Most of systemd is (L)GPL2-or-later, which means there is no perceived incompatibility with Apache2 softwares and can thus be linked with OpenSSL 3.0. But given this GPL2-only header is included this is currently not possible.
Dual-licensing this header solves this problem for us as we are scoping moving to OpenSSL 3.0, see:

https://lists.freedesktop.org/archives/systemd-devel/2021-September/046882.html

The authors of this file according to git log are:

Alexei Starovoitov <[email protected]>
Björn Töpel <[email protected]>
Brendan Jackman <[email protected]>
Chenbo Feng <[email protected]>
Daniel Borkmann <[email protected]>
Daniel Mack <[email protected]>
Jakub Kicinski <[email protected]>
Jiong Wang <[email protected]>
Joe Stringer <[email protected]>
Josef Bacik <[email protected]>

(excludes a commit adding the SPDX header)

All authors and maintainers are CC'ed. An Acked-by from everyone in the above list of authors will be necessary.

One could probably argue for relicensing all the samples/bpf/ files given both libbpf and bpftool are, however the authors list would be much larger and thus it would be much more difficult, so I'd really appreciate if this header could be handled first by itself, as it solves a real license incompatibility issue we are currently facing.

 samples/bpf/bpf_insn.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
samples/bpf/bpf_insn.h +0 -0
index aee04534483a..29c3bb6ad1cd 100644

samples/bpf/bpf_insn.h line 4

Quoted 5 lines
samples/bpf/bpf_insn.h +1 -1
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
  /* eBPF instruction mini library */
  #ifndef __BPF_INSN_H
  #define __BPF_INSN_H

Hello Alexei and Daniel,

We got the following acks so far:

Magnus covers Intel's portion, and Simon covers Netronome's portion.

So as far as I understand, only your two acks are missing and then it's job done and we can go home!

Signature · 2 lines
Kind regards,
Luca Boccassi
maintainer
#18 lore raw

On 9/29/21 6:06 PM, Luca Boccassi wrote:
[...]

Quoted 2 lines

So as far as I understand, only your two acks are missing and then it's job done and we can go home!

Already applied including both our ACKs.

Thanks!
Daniel

#19 lore raw
Quoted 9 lines · Daniel Borkmann

On 9/29/21 6:06 PM, Luca Boccassi wrote:
[...]

Quoted 2 lines

So as far as I understand, only your two acks are missing and then it's job done and we can go home!

Already applied including both our ACKs.

Thanks!
Daniel

Fantastic, thank you so much!

Signature · 2 lines
Kind regards,
Luca Boccassi
#20 lore raw
In reply to [email protected]
This patch was applied to bpf/bpf.git (refs/heads/master):

Hello:

This patch was applied to bpf/bpf.git (refs/heads/master):

Quoted 11 lines · On Thu, 23 Sep 2021 01:05:40 +0100 you wrote:

From: Luca Boccassi <[email protected]>

libbpf and bpftool have been dual-licensed to facilitate inclusion in software that is not compatible with GPL2-only (ie: Apache2), but the samples are still GPL2-only.

Given these files are samples, they get naturally copied around. For example it is the case for samples/bpf/bpf_insn.h which was copied into the systemd
tree: https://github.com/systemd/systemd/blob/main/src/shared/linux/bpf_insn.h

[...]

Here is the summary with links:
- samples/bpf: relicense bpf_insn.h as GPL-2.0-only OR BSD-2-Clause

    https://git.kernel.org/bpf/bpf/c/d75fe9cb1dd0

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html