Skip to contentSkip to conversation

mempool/stack: build on Windows

PATCH Superseded Jie Zhou 3 participants 5 messages Sep 30, 2021 – Oct 1, 2021

Subsystems (2)
Library code Arm/Amlogic Meson SoC support
lore
Share & tools
lore

Jie Zhou

author
#0 lore raw

PATCH 1/1 mempool/stack: build on Windows

Enable the build of mempool/stack on Windows

Signed-off-by Jie Zhou <[email protected]>
---
 drivers/mempool/stack/meson.build | 5 -----
 1 file changed, 5 deletions(-)
drivers/mempool/stack/meson.build +0 -5
index 371cf131b1..580dde79eb 100644
@@ -1,11 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017-2019 Intel Corporation
 
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-endif
-
 sources = files('rte_mempool_stack.c')
 
 deps += ['stack']
Signature · 1 line
2.31.0.vfs.0.1
author
#1 lore raw

PATCH v2 1/1 mempool/stack: build on Windows

enable build mempool/stack on Windows

----
V2 change:
- enable build lib stack on Windows which mempool/stack depends on

Signed-off-by Jie Zhou <[email protected]>
---
 drivers/mempool/stack/meson.build | 5 -----
 lib/meson.build                   | 1 +
 2 files changed, 1 insertion(+), 5 deletions(-)
drivers/mempool/stack/meson.build +0 -5
index 371cf131b1..580dde79eb 100644
@@ -1,11 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017-2019 Intel Corporation
 
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-endif
-
 sources = files('rte_mempool_stack.c')
 
 deps += ['stack']
lib/meson.build +1 -0
index 1673ca4323..9c4841fe40 100644
@@ -85,6 +85,7 @@ if is_windows
             'gso',
             'latencystats',
             'pdump',
+            'stack',
     ] # only supported libraries for windows
 endif
Signature · 1 line
2.31.0.vfs.0.1
Applied
#3 lore raw

01/10/2021 09:42, Dmitry Kozlyuk:

Quoted 5 lines

2021-09-30 17:50 (UTC-0700), Jie Zhou:

Quoted 1 line

enable build mempool/stack on Windows

Nit: in commit body, we use correct capitalization, punctuation, and spelling.

Quoted 8 lines
Quoted 6 lines

----
V2 change:
- enable build lib stack on Windows which mempool/stack depends on

Signed-off-by Jie Zhou <[email protected]>
Acked-by Dmitry Kozlyuk <[email protected]>

Applied, thanks.

#4 lore raw

01/10/2021 16:44, Thomas Monjalon:

Quoted 11 lines

01/10/2021 09:42, Dmitry Kozlyuk:

Quoted 10 lines

2021-09-30 17:50 (UTC-0700), Jie Zhou:

Quoted 1 line

enable build mempool/stack on Windows

Nit: in commit body, we use correct capitalization, punctuation, and spelling.

Quoted 5 lines

----
V2 change:
- enable build lib stack on Windows which mempool/stack depends on

Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Jie Zhou <[email protected]>
Acked-by Dmitry Kozlyuk <[email protected]>

Applied, thanks.

Note: I had to add #include <sys/queue.h> because of a recent commit.