Skip to contentSkip to conversation

heartbeat: fix license issue

PATCH In review Armin Kuster 7 participants 9 messages Feb 14, 2015 – Feb 17, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 heartbeat: fix license issue

From: Armin Kuster <[email protected]>

WARNING: heartbeat: LICENSE value "GPLv2 LGPLv2+" has an invalid format - license names must be separated by the following characters to indicate the license selection: &|()

---
 meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb +1 -1
index a866f0f..7ec7c5d 100644
@@ -22,7 +22,7 @@ It implements the following kinds of heartbeats: \
 "
 HOMEPAGE = "http://linux-ha.org/"
 SECTION = "System Environment/Daemons"
-LICENSE = "GPLv2 LGPLv2+"
+LICENSE = "GPLv2 | LGPLv2+"
 LIC_FILES_CHKSUM = " \
     file://doc/COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b \
     file://doc/COPYING.LGPL;md5=d8045f3b8f929c1cb29a1e3fd737b499 \
Signature · 1 line
1.9.1
#1 lore raw

Thank you for the patch.Applied and merged it upstream.

     On Saturday, February 14, 2015 7:00 AM, Armin Kuster <[email protected]> wrote:

From: Armin Kuster <[email protected]>

WARNING: heartbeat: LICENSE value "GPLv2 LGPLv2+" has an invalid format - license names must be separated by the following characters to indicate the license selection: &|()

---
 meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb +1 -1
index a866f0f..7ec7c5d 100644
@@ -22,7 +22,7 @@ It implements the following kinds of heartbeats: \
 "
 HOMEPAGE = "http://linux-ha.org/"
 SECTION = "System Environment/Daemons"
-LICENSE = "GPLv2 LGPLv2+"
+LICENSE = "GPLv2 | LGPLv2+"
 LIC_FILES_CHKSUM = " \

    file://doc/COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b \
    file://doc/COPYING.LGPL;md5=d8045f3b8f929c1cb29a1e3fd737b499 \

Signature · 7 lines
1.9.1

-- 
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
#2 lore raw
In reply to Armin Kuster

meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb It implements the following kinds of heartbeats: \ · line 25

Quoted 3 lines · Armin Kuster
meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb +1 -1
-LICENSE = "GPLv2 LGPLv2+"
+LICENSE = "GPLv2 | LGPLv2+"

Are you sure this is correct? Afaict this is wrong, as there are parts of the source tree under the GPL, and parts under LGPL, which means it's an AND relationship -- both apply, not an OR relationship, where you can choose which to use.

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
#3 lore raw

Hello Christopher,

Your observation is very accurate.
After a quick inspection I observed the following:

Inside heartbeat-suse.spec the next information: License: GPL v2 only; LGPL v2.1 or later
Link here: http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-suse.spec

Inside heartbeat-fedora.spec the next information: License: GPLv2 and LGPLv2+
Link here: http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-fedora.spec

I added Lars Ellenberg one of the authors behind heartbeat or drbd to the discussion. Hello Lars, sorry for disturbing you but maybe you could help us with our little problem.

If anyone from the Yocto Project community has any input on this matter please help.
For me at least this problem is not clear. Should the “|” sign remain or should it be replaced with the “&” one between the licenses.

Thanks guys,
Alex Vaduva

From: [email protected] [mailto:[email protected]] On Behalf Of Christopher Larson
Sent: Sunday, February 15, 2015 4:01 PM
To: Armin Kuster
Cc: yocto
Subject: Re: [yocto] [meta-cgl][PATCH] heartbeat: fix license issue

On Fri, Feb 13, 2015 at 10:00 PM, Armin Kuster <[email protected]<mailto:[email protected]>> wrote:
-LICENSE = "GPLv2 LGPLv2+"
+LICENSE = "GPLv2 | LGPLv2+"

Are you sure this is correct? Afaict this is wrong, as there are parts of the source tree under the GPL, and parts under LGPL, which means it's an AND relationship -- both apply, not an OR relationship, where you can choose which to use. --
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

#4 lore raw
Quoted 11 lines · On Monday 16 February 2015 09:18:29 Alexandru Vaduva wrote:

After a quick inspection I observed the following:

Inside heartbeat-suse.spec the next information:
License: GPL v2 only; LGPL v2.1 or later Link here:
http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-sus
e.spec
Inside heartbeat-fedora.spec the next information:
License: GPLv2 and LGPLv2+
Link here:
http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-fed
ora.spec

Quoted 8 lines

I added Lars Ellenberg one of the authors behind heartbeat or drbd to the discussion.
Hello Lars, sorry for disturbing you but maybe you could help us with our little problem.
If anyone from the Yocto Project community has any input on this matter please help.
For me at least this problem is not clear. Should the “|”
sign remain or should it be replaced with the “&” one between the licenses.

What you have found above correlates with what Chris was saying - both licenses apply, therefore you must use &.

Cheers,
Paul

Quoted 17 lines

From: [email protected] [mailto:[email protected]] On Behalf Of Christopher Larson
Sent: Sunday, February 15, 2015 4:01 PM
To: Armin Kuster
Cc: yocto
Subject: Re: [yocto] [meta-cgl][PATCH] heartbeat: fix license issue

On Fri, Feb 13, 2015 at 10:00 PM, Armin Kuster <[email protected]<mailto:[email protected]>> wrote:

meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb +1 -1
-LICENSE = "GPLv2 LGPLv2+"
+LICENSE = "GPLv2 | LGPLv2+"

Are you sure this is correct? Afaict this is wrong, as there are parts of the source tree under the GPL, and parts under LGPL, which means it's an AND relationship -- both apply, not an OR relationship, where you can choose which to use.

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#5 lore raw

Ok,
Thanks,I will try to do the change accordingly.I spotted a new mistake, this time in one of my patches and I will try to send them both tomorrow for review.

On Monday, February 16, 2015 6:31 PM, Paul Eggleton <[email protected]> wrote:

Quoted 11 lines · On Monday 16 February 2015 09:18:29 Alexandru Vaduva wrote:

After a quick inspection I observed the following:

                    Inside heartbeat-suse.spec the next information:
License:        GPL v2 only; LGPL v2.1 or later Link here:
http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-sus
e.spec
                    Inside heartbeat-fedora.spec the next information:
License:          GPLv2 and LGPLv2+
Link here:
http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-fed
ora.spec

Quoted 8 lines

I added Lars Ellenberg one of the authors behind heartbeat or drbd to the discussion.
Hello Lars, sorry for disturbing you but maybe you could help us with our little problem.
If anyone from the Yocto Project community has any input on this matter please help.
For me at least this problem is not clear. Should the “|”
sign remain or should it be replaced with the “&” one between the licenses.

What you have found above correlates with what Chris was saying - both licenses apply, therefore you must use &.

Cheers,
Paul

Quoted 17 lines

From: [email protected] [mailto:[email protected]] On Behalf Of Christopher Larson
Sent: Sunday, February 15, 2015 4:01 PM
To: Armin Kuster
Cc: yocto
Subject: Re: [yocto] [meta-cgl][PATCH] heartbeat: fix license issue

On Fri, Feb 13, 2015 at 10:00 PM, Armin Kuster <[email protected]<mailto:[email protected]>> wrote:

meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb +1 -1
-LICENSE = "GPLv2 LGPLv2+"
+LICENSE = "GPLv2 | LGPLv2+"

Are you sure this is correct? Afaict this is wrong, as there are parts of the source tree under the GPL, and parts under LGPL, which means it's an AND relationship -- both apply, not an OR relationship, where you can choose which to use.

Signature · 7 lines
Paul Eggleton
Intel Open Source Technology Centre
-- 
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
#6 lore raw
In reply to Alexandru Vaduva

Am 16. Februar 2015 10:18:29 MEZ, schrieb Alexandru Vaduva <[email protected]>:

Quoted 44 lines

Hello Christopher,

Your observation is very accurate.
After a quick inspection I observed the following:

Inside heartbeat-suse.spec the next information: License: GPL v2
only; LGPL v2.1 or later
Link here:
http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-suse.spec

Inside heartbeat-fedora.spec the next information: License:
GPLv2 and LGPLv2+
Link here:
http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-fedora.spec

I added Lars Ellenberg one of the authors behind heartbeat or drbd to the discussion.
Hello Lars, sorry for disturbing you but maybe you could help us with our little problem.

If anyone from the Yocto Project community has any input on this matter please help.
For me at least this problem is not clear. Should the “|” sign remain or should it be replaced with the “&” one between the licenses.

Thanks guys,
Alex Vaduva

From: [email protected] [mailto:[email protected]] On Behalf Of Christopher Larson
Sent: Sunday, February 15, 2015 4:01 PM
To: Armin Kuster
Cc: yocto
Subject: Re: [yocto] [meta-cgl][PATCH] heartbeat: fix license issue

On Fri, Feb 13, 2015 at 10:00 PM, Armin Kuster <[email protected]<mailto:[email protected]>> wrote:

meta-cgl-common/recipes-cgl/heartbeat/heartbeat_3.0.5.bb +1 -1
-LICENSE = "GPLv2 LGPLv2+"
+LICENSE = "GPLv2 | LGPLv2+"
Quoted 10 lines

Are you sure this is correct? Afaict this is wrong, as there are parts of the source tree under the GPL, and parts under LGPL, which means it's an AND relationship -- both apply, not an OR relationship, where you can choose which to use.
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

It is an "and".
Some parts have been taken from LGPL or dual license whatever/LGPL origin. Some GPL. So it is both, not an option or choice. Which parts are what however I do not know from the top of my head, I'd have to check, if it is relevant to you.

Thanks,
Lars

author
#7 lore raw

It should be an ""&" (and). I will send a updated patch soon.

- armin

Quoted 71 lines · Lars Ellenberg

Am 16. Februar 2015 10:18:29 MEZ, schrieb Alexandru Vaduva <[email protected]>:

Hello Christopher,

Your observation is very accurate.

After a quick inspection I observed the following:

Inside heartbeat-suse.spec the next information:License: GPL v2 only; LGPL v2.1 or later

Link here:
http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-suse.spec

Inside heartbeat-fedora.spec the next information:License: GPLv2 and LGPLv2+

Link here:
http://hg.linux-ha.org/heartbeat-STABLE_3_0/file/545554f6fc0a/heartbeat-fedora.spec

I added Lars Ellenberg one of the authors behind heartbeat or drbd to the discussion.

Hello Lars, sorry for disturbing you but maybe you could help us with our little problem.

If anyone from the Yocto Project community has any input on this matter please help.

For me at least this problem is not clear. Should the “|”sign remain or should it be replaced with the “&”one between the licenses.

Thanks guys,

Alex Vaduva

*From:*[email protected] [mailto:[email protected]] *On Behalf Of *Christopher Larson
*Sent:* Sunday, February 15, 2015 4:01 PM
*To:* Armin Kuster
*Cc:* yocto
*Subject:* Re: [yocto] [meta-cgl][PATCH] heartbeat: fix license issue

On Fri, Feb 13, 2015 at 10:00 PM, Armin Kuster <[email protected] <mailto:[email protected]>> wrote:

-LICENSE = "GPLv2 LGPLv2+"
+LICENSE = "GPLv2 | LGPLv2+"

Are you sure this is correct? Afaict this is wrong, as there are parts of the source tree under the GPL, and parts under LGPL, which means it's an AND relationship -- both apply, not an OR relationship, where you can choose which to use.
--

Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

It is an "and".
Some parts have been taken from LGPL or dual license whatever/LGPL origin. Some GPL. So it is both, not an option or choice. Which parts are what however I do not know from the top of my head, I'd have to check, if it is relevant to you.

Thanks,
Lars

#8 lore raw
In reply to Christopher Larson

Chris,

Thanks for catching this. I want to make sure I get these right.

Mahalo,
Armin

Quoted 20 lines · Christopher Larson

On Fri, Feb 13, 2015 at 10:00 PM, Armin Kuster <[email protected] <mailto:[email protected]>> wrote:

    -LICENSE = "GPLv2 LGPLv2+"
    +LICENSE = "GPLv2 | LGPLv2+"

Are you sure this is correct? Afaict this is wrong, as there are parts of the source tree under the GPL, and parts under LGPL, which means it's an AND relationship -- both apply, not an OR relationship, where you can choose which to use.
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics