Skip to contentSkip to conversation

dove: mark 'putc' as inline

PATCH Applied Arnd Bergmann 3 participants 3 messages Sep 27, 2021 – Oct 5, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dove: mark 'putc' as inline

From: Arnd Bergmann <[email protected]>

This can cause a randconfig warning without the 'inline' flag that every other platform uses:

In file included from arch/arm/boot/compressed/misc.c:29:
arch/arm/mach-dove/include/mach/uncompress.h:14:13: error: 'putc' defined but not used [-Werror=unused-function]
14 | static void putc(const char c)

      |             ^~~~
---
 arch/arm/mach-dove/include/mach/uncompress.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-dove/include/mach/uncompress.h +2 -2
index 7a4bd8838036..ddf873f35e2b 100644
@@ -11,7 +11,7 @@
 
 #define LSR_THRE	0x20
 
-static void putc(const char c)
+static inline void putc(const char c)
 {
 	int i;
 
@@ -24,7 +24,7 @@ static void putc(const char c)
 	*UART_THR = c;
 }
 
-static void flush(void)
+static inline void flush(void)
 {
 }
 
Signature · 1 line
2.29.2
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

This can cause a randconfig warning without the 'inline' flag that every other platform uses:

In file included from arch/arm/boot/compressed/misc.c:29:
arch/arm/mach-dove/include/mach/uncompress.h:14:13: error: 'putc' defined but not used [-Werror=unused-function]
14 | static void putc(const char c)

      |             ^~~~

Andrew

#2 lore raw
In reply to Arnd Bergmann
This patch was applied to soc/soc.git (refs/heads/arm/fixes):

Hello:

This patch was applied to soc/soc.git (refs/heads/arm/fixes):

Quoted 11 lines · On Mon, 27 Sep 2021 11:53:33 +0200 you wrote:

From: Arnd Bergmann <[email protected]>

This can cause a randconfig warning without the 'inline' flag that every other platform uses:

In file included from arch/arm/boot/compressed/misc.c:29:
arch/arm/mach-dove/include/mach/uncompress.h:14:13: error: 'putc' defined but not used [-Werror=unused-function]
14 | static void putc(const char c)

      |             ^~~~

[...]

Here is the summary with links:
- dove: mark 'putc' as inline

    https://git.kernel.org/soc/soc/c/b9af50bcbcd2

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html