Linux 4.4.288
Greg Kroah-Hartman
maintainerI'm announcing the release of the 4.4.288 kernel.
All users of the 4.4 kernel series must upgrade.
The updated 4.4.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.4.y
and can be browsed at the normal kernel.org git web browser:
https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary
thanks,
greg k-h
------------
Makefile | 2 +- arch/sparc/lib/iomap.c | 2 ++ drivers/ata/libata-core.c | 34 ++++++++++++++++++++++++++++++++-- drivers/net/xen-netback/netback.c | 2 +- drivers/scsi/sd.c | 9 +++++---- fs/ext2/balloc.c | 14 ++++++-------- include/linux/libata.h | 1 + include/net/sock.h | 2 ++ net/core/sock.c | 12 +++++++++--- net/unix/af_unix.c | 34 ++++++++++++++++++++++++++++------ tools/usb/testusb.c | 14 ++++++++------ 11 files changed, 95 insertions(+), 31 deletions(-)
Dan Carpenter (1):
ext2: fix sleeping in atomic bugs on error
Eric Dumazet (1):
af_unix: fix races in sk_peer_pid and sk_peer_cred accesses
Faizel K B (1):
usb: testusb: Fix for showing the connection speed
Greg Kroah-Hartman (1):
Linux 4.4.288
Jan Beulich (1):
xen-netback: correct success/error reporting for the SKB-with-fraglist case
Kate Hsuan (1):
libata: Add ATA_HORKAGE_NO_NCQ_ON_ATI for Samsung 860 and 870 SSD.
Linus Torvalds (1):
sparc64: fix pci_iounmap() when CONFIG_PCI is not set
Ming Lei (1):
scsi: sd: Free scsi_disk device via put_device()
Greg Kroah-Hartman
maintainerMakefile +1 -1
@@ -1,6 +1,6 @@ VERSION = 4 PATCHLEVEL = 4 -SUBLEVEL = 287 +SUBLEVEL = 288 EXTRAVERSION = NAME = Blurry Fish Butt
arch/sparc/lib/iomap.c +2 -0
@@ -18,8 +18,10 @@ void ioport_unmap(void __iomem *addr)EXPORT_SYMBOL (ioport_map);EXPORT_SYMBOL (ioport_unmap); +#ifdef CONFIG_PCI void pci_iounmap (struct pci_dev *dev,void __iomem * addr) {/* nothing to do */ }EXPORT_SYMBOL (pci_iounmap); +#endif
drivers/ata/libata-core.c +32 -2
@@ -2077,6 +2077,25 @@ static inline u8 ata_dev_knobble(struct ata_device *dev)return ((ap->cbl ==ATA_CBL_SATA ) && (!ata_id_is_sata (dev->id))); } +static bool ata_dev_check_adapter (struct ata_device *dev, +unsigned short vendor_id) +{ +struct pci_dev *pcidev =NULL ; +struct device *parent_dev =NULL ; + +for (parent_dev = dev->tdev.parent; parent_dev !=NULL ; + parent_dev = parent_dev->parent) { +if (dev_is_pci (parent_dev)) { + pcidev =to_pci_dev (parent_dev); +if (pcidev->vendor == vendor_id) +return true; +break ; + } + } + +return false; +} +static int ata_dev_config_ncq (struct ata_device *dev,char *desc,size_t desc_sz) {
@@ -2093,6 +2112,13 @@ static int ata_dev_config_ncq(struct ata_device *dev,snprintf (desc, desc_sz,"NCQ (not used)" );return 0 ; } + +if (dev->horkage &ATA_HORKAGE_NO_NCQ_ON_ATI && +ata_dev_check_adapter (dev,PCI_VENDOR_ID_ATI )) { +snprintf (desc, desc_sz,"NCQ (not used)" ); +return 0 ; + } +if (ap->flags &ATA_FLAG_NCQ ) { hdepth =min (ap->scsi_host->can_queue,ATA_MAX_QUEUE -1 ); dev->flags |=ATA_DFLAG_NCQ ;
@@ -4270,9 +4296,11 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = { {"Samsung SSD 850*" ,NULL ,ATA_HORKAGE_NO_NCQ_TRIM | ATA_HORKAGE_ZERO_AFTER_TRIM, }, { "Samsung SSD 860*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | - ATA_HORKAGE_ZERO_AFTER_TRIM, }, +ATA_HORKAGE_ZERO_AFTER_TRIM | + ATA_HORKAGE_NO_NCQ_ON_ATI, }, { "Samsung SSD 870*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | - ATA_HORKAGE_ZERO_AFTER_TRIM, }, +ATA_HORKAGE_ZERO_AFTER_TRIM | + ATA_HORKAGE_NO_NCQ_ON_ATI, }, { "FCCT*M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | ATA_HORKAGE_ZERO_AFTER_TRIM, },
@@ -6520,6 +6548,8 @@ static int __init ata_parse_force_one(char **cur, { "ncq", .horkage_off = ATA_HORKAGE_NONCQ }, { "noncqtrim", .horkage_on = ATA_HORKAGE_NO_NCQ_TRIM }, { "ncqtrim", .horkage_off = ATA_HORKAGE_NO_NCQ_TRIM }, + { "noncqati", .horkage_on = ATA_HORKAGE_NO_NCQ_ON_ATI }, + { "ncqati", .horkage_off = ATA_HORKAGE_NO_NCQ_ON_ATI }, { "dump_id", .horkage_on = ATA_HORKAGE_DUMP_ID }, { "pio0", .xfer_mask = 1 << (ATA_SHIFT_PIO + 0) }, { "pio1", .xfer_mask = 1 << (ATA_SHIFT_PIO + 1) },
drivers/net/xen-netback/netback.c +1 -1
@@ -994,7 +994,7 @@ check_frags:* the header's copy failed, and they are * sharing a slot, send an error */ -if (i ==0 && sharedslot) +if (i ==0 && !first_shinfo && sharedslot)xenvif_idx_release (queue, pending_idx,XEN_NETIF_RSP_ERROR );else
drivers/scsi/sd.c +5 -4
@@ -3146,15 +3146,16 @@ static int sd_probe(struct device *dev) }device_initialize (&sdkp->dev); - sdkp->dev.parent = dev; + sdkp->dev.parent =get_device (dev); sdkp->dev.class = &sd_disk_class;dev_set_name (&sdkp->dev,"%s" ,dev_name (dev)); error =device_add (&sdkp->dev); -if (error) - goto out_free_index; +if (error) { +put_device (&sdkp->dev); + goto out; + } -get_device (dev);dev_set_drvdata (dev, sdkp);get_device (&sdkp->dev);/* prevent release before async_schedule */
fs/ext2/balloc.c +6 -8
@@ -46,10 +46,9 @@ struct ext2_group_desc * ext2_get_group_desc(struct super_block * sb,struct ext2_sb_info *sbi =EXT2_SB (sb);if (block_group >= sbi->s_groups_count) { -ext2_error (sb,"ext2_get_group_desc" , -"block_group >= groups_count - " -"block_group = %d, groups_count = %lu" , - block_group, sbi->s_groups_count); +WARN (1 ,"block_group >= groups_count - " +"block_group = %d, groups_count = %lu" , + block_group, sbi->s_groups_count);return NULL ; }
@@ -57,10 +56,9 @@ struct ext2_group_desc * ext2_get_group_desc(struct super_block * sb, group_desc = block_group >>EXT2_DESC_PER_BLOCK_BITS (sb); offset = block_group & (EXT2_DESC_PER_BLOCK (sb) -1 );if (!sbi->s_group_desc[group_desc]) { -ext2_error (sb,"ext2_get_group_desc" , -"Group descriptor not loaded - " -"block_group = %d, group_desc = %lu, desc = %lu" , - block_group, group_desc, offset); +WARN (1 ,"Group descriptor not loaded - " +"block_group = %d, group_desc = %lu, desc = %lu" , + block_group, group_desc, offset);return NULL ; }
include/linux/libata.h +1 -0
@@ -437,6 +437,7 @@ enum {ATA_HORKAGE_NO_NCQ_LOG = (1 <<23 ),/* don't use NCQ for log read */ ATA_HORKAGE_NOTRIM = (1 <<24 ),/* don't use TRIM */ ATA_HORKAGE_MAX_SEC_1024 = (1 <<25 ),/* Limit max sects to 1024 */ + ATA_HORKAGE_NO_NCQ_ON_ATI = (1 << 27), /* Disable NCQ on ATI chipset *//* DMA mask for user DMA control: User visible values; DO NOT renumber */
include/net/sock.h +2 -0
@@ -429,8 +429,10 @@ struct sock {#if IS_ENABLED (CONFIG_CGROUP_NET_PRIO )__u32 sk_cgrp_prioidx;#endif +spinlock_t sk_peer_lock;struct pid *sk_peer_pid;const struct cred *sk_peer_cred; +long sk_rcvtimeo;long sk_sndtimeo;struct timer_list sk_timer;
net/core/sock.c +9 -3
@@ -1014,7 +1014,6 @@ set_rcvbuf: }EXPORT_SYMBOL (sock_setsockopt); -static void cred_to_ucred (struct pid *pid,const struct cred *cred,struct ucred *ucred) {
@@ -1174,7 +1173,11 @@ int sock_getsockopt(struct socket *sock, int level, int optname,struct ucred peercred;if (len >sizeof (peercred)) len =sizeof (peercred); + +spin_lock (&sk->sk_peer_lock);cred_to_ucred (sk->sk_peer_pid, sk->sk_peer_cred, &peercred); +spin_unlock (&sk->sk_peer_lock); +if (copy_to_user (optval, &peercred, len))return -EFAULT ; goto lenout;
@@ -1467,9 +1470,10 @@ void sk_destruct(struct sock *sk) sk->sk_frag.page =NULL ; } -if (sk->sk_peer_cred) -put_cred (sk->sk_peer_cred); +/* We do not need to acquire sk->sk_peer_lock, we are the last user. */ +put_cred (sk->sk_peer_cred);put_pid (sk->sk_peer_pid); +if (likely (sk->sk_net_refcnt))put_net (sock_net (sk));sk_prot_free (sk->sk_prot_creator, sk);
@@ -2442,6 +2446,8 @@ void sock_init_data(struct socket *sock, struct sock *sk) sk->sk_peer_pid =NULL ; sk->sk_peer_cred =NULL ; +spin_lock_init (&sk->sk_peer_lock); + sk->sk_write_pending =0 ; sk->sk_rcvlowat =1 ; sk->sk_rcvtimeo =MAX_SCHEDULE_TIMEOUT ;
net/unix/af_unix.c +28 -6
@@ -594,20 +594,42 @@ static void unix_release_sock(struct sock *sk, int embrion)static void init_peercred (struct sock *sk) { -put_pid (sk->sk_peer_pid); -if (sk->sk_peer_cred) -put_cred (sk->sk_peer_cred); +const struct cred *old_cred; +struct pid *old_pid; + +spin_lock (&sk->sk_peer_lock); + old_pid = sk->sk_peer_pid; + old_cred = sk->sk_peer_cred; sk->sk_peer_pid =get_pid (task_tgid (current)); sk->sk_peer_cred =get_current_cred (); +spin_unlock (&sk->sk_peer_lock); + +put_pid (old_pid); +put_cred (old_cred); }static void copy_peercred (struct sock *sk,struct sock *peersk) { -put_pid (sk->sk_peer_pid); -if (sk->sk_peer_cred) -put_cred (sk->sk_peer_cred); +const struct cred *old_cred; +struct pid *old_pid; + +if (sk < peersk) { +spin_lock (&sk->sk_peer_lock); +spin_lock_nested (&peersk->sk_peer_lock,SINGLE_DEPTH_NESTING ); + }else { +spin_lock (&peersk->sk_peer_lock); +spin_lock_nested (&sk->sk_peer_lock,SINGLE_DEPTH_NESTING ); + } + old_pid = sk->sk_peer_pid; + old_cred = sk->sk_peer_cred; sk->sk_peer_pid =get_pid (peersk->sk_peer_pid); sk->sk_peer_cred =get_cred (peersk->sk_peer_cred); + +spin_unlock (&sk->sk_peer_lock); +spin_unlock (&peersk->sk_peer_lock); + +put_pid (old_pid); +put_cred (old_cred); }static int unix_listen (struct socket *sock,int backlog)
tools/usb/testusb.c +8 -6
@@ -278,12 +278,6 @@ nomem: } entry->ifnum = ifnum; - -/* FIXME update USBDEVFS_CONNECTINFO so it tells about high speed etc */ - -fprintf (stderr,"%s speed\t%s\t%u\n" , -speed (entry->speed), entry->name, entry->ifnum); - entry->next = testdevs; testdevs = entry;return 0 ;
@@ -312,6 +306,14 @@ static void *handle_testdev (void *arg)return 0 ; } + status =ioctl (fd,USBDEVFS_GET_SPEED ,NULL ); +if (status <0 ) +fprintf (stderr,"USBDEVFS_GET_SPEED failed %d\n" , status); +else + dev->speed = status; +fprintf (stderr,"%s speed\t%s\t%u\n" , +speed (dev->speed), dev->name, dev->ifnum); + restart:for (i =0 ; i <TEST_CASES ; i++) {if (dev->test !=-1 && dev->test != i)