FAILED: patch "[PATCH] staging: vc04_services: shut up out-of-range warning" failed to apply to 5.4-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 5.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 7ff4034e910fe00a90d985f0d05bacf60c162f02 Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <[email protected]>
Date: Mon, 27 Sep 2021 13:36:56 +0200
Subject: [PATCH] staging: vc04_services: shut up out-of-range warning
The comparison against SIZE_MAX produces a harmless warning on 64-bit architectures:
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:185:16: error: result of comparison of constant 419244183493398898 with expression of type 'unsigned int' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
if (num_pages > (SIZE_MAX - sizeof(struct pagelist) -
~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Shut up that warning by adding a cast to a longer type.
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +1 -1
@@ -182,7 +182,7 @@ create_pagelist(char *buf, char __user *ubuf, offset = (uintptr_t )ubuf & (PAGE_SIZE -1 ); num_pages =DIV_ROUND_UP (count + offset,PAGE_SIZE ); -if (num_pages > (SIZE_MAX -sizeof (struct pagelist ) - +if ((size_t )num_pages > (SIZE_MAX -sizeof (struct pagelist ) -sizeof (struct vchiq_pagelist_info )) / (sizeof (u32) +sizeof (pages[0 ]) +sizeof (struct scatterlist )))