Skip to contentSkip to conversation

ARM: dts: spear13xx: Drop malformed 'interrupt-map' on PCI nodes

PATCH Applied Rob Herring 2 participants 2 messages Oct 22, 2021 Device tree bindings

lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH v2 1/1 ARM: dts: spear13xx: Drop malformed 'interrupt-map' on PCI nodes

The spear13xx PCI 'interrupt-map' property is not parse-able. '#interrupt-cells' is missing and there are 3 #address-cells. Based on the driver, the only supported interrupt is for MSI. Therefore, 'interrupt-map' is not needed.

---

Arnd, Olof, Please apply.

 arch/arm/boot/dts/spear1310.dtsi | 6 ------
 arch/arm/boot/dts/spear1340.dtsi | 2 --
 2 files changed, 8 deletions(-)
arch/arm/boot/dts/spear1310.dtsi +0 -6
index c4b49baf9804..2f746a9428a7 100644
@@ -82,8 +82,6 @@ pcie0: pcie@b1000000 {
 			reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
 			reg-names = "dbi", "config";
 			interrupts = <0 68 0x4>;
-			interrupt-map-mask = <0 0 0 0>;
-			interrupt-map = <0x0 0 &gic 0 68 0x4>;
 			num-lanes = <1>;
 			phys = <&miphy0 1>;
 			phy-names = "pcie-phy";
@@ -101,8 +99,6 @@ pcie1: pcie@b1800000 {
 			reg = <0xb1800000 0x4000>, <0x90000000 0x20000>;
 			reg-names = "dbi", "config";
 			interrupts = <0 69 0x4>;
-			interrupt-map-mask = <0 0 0 0>;
-			interrupt-map = <0x0 0 &gic 0 69 0x4>;
 			num-lanes = <1>;
 			phys = <&miphy1 1>;
 			phy-names = "pcie-phy";
@@ -120,8 +116,6 @@ pcie2: pcie@b4000000 {
 			reg = <0xb4000000 0x4000>, <0xc0000000 0x20000>;
 			reg-names = "dbi", "config";
 			interrupts = <0 70 0x4>;
-			interrupt-map-mask = <0 0 0 0>;
-			interrupt-map = <0x0 0 &gic 0 70 0x4>;
 			num-lanes = <1>;
 			phys = <&miphy2 1>;
 			phy-names = "pcie-phy";
arch/arm/boot/dts/spear1340.dtsi +0 -2
index 1a8f5e8b10e3..827e887afbda 100644
@@ -47,8 +47,6 @@ pcie0: pcie@b1000000 {
 			reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
 			reg-names = "dbi", "config";
 			interrupts = <0 68 0x4>;
-			interrupt-map-mask = <0 0 0 0>;
-			interrupt-map = <0x0 0 &gic 0 68 0x4>;
 			num-lanes = <1>;
 			phys = <&miphy0 1>;
 			phy-names = "pcie-phy";
Signature · 1 line
2.32.0
#1 lore raw
This patch was applied to soc/soc.git (for-next) by Arnd Bergmann <[email protected]>:

Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <[email protected]>:

Quoted 11 lines · On Fri, 22 Oct 2021 09:11:56 -0500 you wrote:

The spear13xx PCI 'interrupt-map' property is not parse-able. '#interrupt-cells' is missing and there are 3 #address-cells. Based on the driver, the only supported interrupt is for MSI. Therefore, 'interrupt-map' is not needed.

[...]

Here is the summary with links:
- [v2] ARM: dts: spear13xx: Drop malformed 'interrupt-map' on PCI nodes

    https://git.kernel.org/soc/soc/c/5cbd84300b3c

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html