Skip to contentSkip to conversation

dt-bindings: leds: Document none trigger

PATCH Superseded Marek Vasut 3 participants 9 messages Oct 24, 2021 – Nov 8, 2021

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: leds: Document none trigger

There is a trigger called "none" which triggers never, add it to the list of valid trigger values.

Cc Jacek Anaszewski <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Rob Herring <[email protected]>

To: [email protected]

---
 Documentation/devicetree/bindings/leds/common.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/leds/common.yaml +2 -0
index 697102707703a..22197376fa3c7 100644
@@ -92,6 +92,8 @@ properties:
         # LED indicates IDE disk activity (deprecated), in new implementations
         # use "disk-activity"
       - ide-disk
+        # LED is not triggered
+      - none
         # LED flashes at a fixed, configurable rate
       - timer
         # LED alters the brightness for the specified duration with one software
Signature · 1 line
2.33.0
#1 lore raw

PATCH 2/2 dt-bindings: leds: Document mmc trigger

The mmc subsystem supports triggering leds on card activity, document the trigger value here. The value is a pattern in this case.

Cc Jacek Anaszewski <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Rob Herring <[email protected]>

To: [email protected]

---
 .../devicetree/bindings/leds/common.yaml      | 43 ++++++++++---------
 1 file changed, 23 insertions(+), 20 deletions(-)
Documentation/devicetree/bindings/leds/common.yaml +23 -20
index 22197376fa3c7..40afb06072d9c 100644
@@ -79,26 +79,29 @@ properties:
       the LED.
     $ref: /schemas/types.yaml#/definitions/string
 
-    enum:
-        # LED will act as a back-light, controlled by the framebuffer system
-      - backlight
-        # LED will turn on (but for leds-gpio see "default-state" property in
-        # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
-      - default-on
-        # LED "double" flashes at a load average based rate
-      - heartbeat
-        # LED indicates disk activity
-      - disk-activity
-        # LED indicates IDE disk activity (deprecated), in new implementations
-        # use "disk-activity"
-      - ide-disk
-        # LED is not triggered
-      - none
-        # LED flashes at a fixed, configurable rate
-      - timer
-        # LED alters the brightness for the specified duration with one software
-        # timer (requires "led-pattern" property)
-      - pattern
+    oneOf:
+      - enum:
+          # LED will act as a back-light, controlled by the framebuffer system
+        - backlight
+          # LED will turn on (but for leds-gpio see "default-state" property in
+          # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
+        - default-on
+          # LED "double" flashes at a load average based rate
+        - heartbeat
+          # LED indicates disk activity
+        - disk-activity
+          # LED indicates IDE disk activity (deprecated), in new implementations
+          # use "disk-activity"
+        - ide-disk
+          # LED is not triggered
+        - none
+          # LED flashes at a fixed, configurable rate
+        - timer
+          # LED alters the brightness for the specified duration with one software
+          # timer (requires "led-pattern" property)
+        - pattern
+        # LED is triggered by SD/MMC activity
+      - pattern: "^mmc[0-9]+$"
 
   led-pattern:
     description: |
Signature · 1 line
2.33.0
#2 lore raw

Re: [PATCH 2/2] dt-bindings: leds: Document mmc trigger

Hi!

Quoted 2 lines

The mmc subsystem supports triggering leds on card activity, document the trigger value here. The value is a pattern in this case.

I don't believe this is suitable as devicetree does not know about mmc numbers.

Best regards,
Pavel

Signature · 1 line
http://www.livejournal.com/~pavelmachek
#3 lore raw

Re: [PATCH 2/2] dt-bindings: leds: Document mmc trigger

Quoted 7 lines · Pavel Machek

Hi!

Quoted 2 lines

The mmc subsystem supports triggering leds on card activity, document the trigger value here. The value is a pattern in this case.

I don't believe this is suitable as devicetree does not know about mmc numbers.

There are multiple instances of this trigger type in existing DTs, see:

$ git grep linux.default-trigger.=..mmc | wc -l
85

So what alternative do you suggest ?

maintainer
#4 lore raw

Re: [PATCH 2/2] dt-bindings: leds: Document mmc trigger

In reply to Marek Vasut
Quoted 8 lines · Marek Vasut

The mmc subsystem supports triggering leds on card activity, document the trigger value here. The value is a pattern in this case.

Cc Jacek Anaszewski <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Rob Herring <[email protected]>
Quoted 5 lines

To: [email protected]

---
 .../devicetree/bindings/leds/common.yaml      | 43 ++++++++++---------
 1 file changed, 23 insertions(+), 20 deletions(-)

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/leds/common.yaml:85:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1545330

This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit.

#5 lore raw
In reply to Marek Vasut

Hi!

Quoted 2 lines

There is a trigger called "none" which triggers never, add it to the list of valid trigger values.

We can do this, but is it useful? If you avoid putting trigger property, it will do the same thing.

Best regards,
Pavel

Signature · 1 line
http://www.livejournal.com/~pavelmachek
#6 lore raw
Quoted 7 lines · Pavel Machek

Hi!

Quoted 2 lines

There is a trigger called "none" which triggers never, add it to the list of valid trigger values.

We can do this, but is it useful? If you avoid putting trigger property, it will do the same thing.

It's not that simple. If you have a DT which specifies a trigger type and a DTO which overrides that trigger type, then the DTO cannot remove the trigger from the base DT, it has to set trigger type to "none". So I believe there is a valid use case for existence of the "none" type.

maintainer
#7 lore raw
Quoted 6 lines · Marek Vasut
Quoted 5 lines · Pavel Machek

Hi!

Quoted 2 lines

There is a trigger called "none" which triggers never, add it to the list of valid trigger values.

Quoted 7 lines
Quoted 2 lines

We can do this, but is it useful? If you avoid putting trigger property, it will do the same thing.

It's not that simple. If you have a DT which specifies a trigger type and a DTO which overrides that trigger type, then the DTO cannot remove the trigger from the base DT, it has to set trigger type to "none". So I believe there is a valid use case for existence of the "none" type.

Sounds like an incorrect partitioning of base and overlays IMO.

There's also already /delete-property/ directive though I'm not sure if that's supported in overlays.

Rob

#8 lore raw
Quoted 10 lines · Rob Herring
Quoted 9 lines · Marek Vasut
Quoted 7 lines · Pavel Machek

Hi!

Quoted 2 lines

There is a trigger called "none" which triggers never, add it to the list of valid trigger values.

We can do this, but is it useful? If you avoid putting trigger property, it will do the same thing.

Quoted 6 lines
Quoted 4 lines

It's not that simple. If you have a DT which specifies a trigger type and a DTO which overrides that trigger type, then the DTO cannot remove the trigger from the base DT, it has to set trigger type to "none". So I believe there is a valid use case for existence of the "none" type.

Sounds like an incorrect partitioning of base and overlays IMO.

Note that you might not have control over the base DT.

Quoted 2 lines

There's also already /delete-property/ directive though I'm not sure if that's supported in overlays.

How do you encode /delete-property/ into the DT overlay blob .dtbo ?
I thought that /delete-property/ and /delete-node/ was a DTC directive and the DT blob has no way to represent either ?