Skip to contentSkip to conversation

arm64: dts: Add i.MX8DXL initial support

PATCH Applied Abel Vesa 4 participants 26 messages Nov 10, 2021 – Nov 29, 2021

Subsystems (5)

v4 of 9 Applied Latest is v9 →

lore
Share & tools
lore

Abel Vesa

author
#0 lore raw

v4 cover arm64: dts: Add i.MX8DXL initial support

Changes since v3:
* Fixed the existing 8QM imx-lpi2c dtbs_check error
* Fixed the existing 8QM fsl-lpuart dtbs_check error
* Fixed the newly added 8DXL imx-lpi2c binding in order to not break others
* Fixed the newly added 8DXL fsl-lpuart binding in order to not break others

Abel Vesa (7):
dt-bindings: i2c: imx-lpi2c: Fix i.MX 8QM compatible matching
dt-bindings: serial: fsl-lpuart: Fix i.MX 8QM compatible matching
arm64: dts: imx8-ss-lsio: Add mu5a mailbox
arm64: dts: freescale: Add adma subsystem dtsi for imx8dxl
dt-bindings: fsl: scu: Add i.MX8DXL ocotp binding
dt-bindings: i2c: imx-lpi2c: Add i.MX8DXL compatible match
dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible

Jacky Bai (5):
arm64: dts: freescale: Add the top level dtsi support for imx8dxl
arm64: dts: freescale: Add the imx8dxl connectivity subsys dtsi
arm64: dts: freescale: Add ddr subsys dtsi for imx8dxl
arm64: dts: freescale: Add lsio subsys dtsi for imx8dxl
arm64: dts: imx8dxl: Add i.MX8DXL evk board support

 .../bindings/arm/freescale/fsl,scu.txt        |   3 +-
 .../bindings/i2c/i2c-imx-lpi2c.yaml           |   6 +-
 .../bindings/serial/fsl-lpuart.yaml           |   7 +
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../boot/dts/freescale/imx8-ss-lsio.dtsi      |   7 +
 arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 266 ++++++++++++++++++
 .../boot/dts/freescale/imx8dxl-ss-adma.dtsi   |  53 ++++
 .../boot/dts/freescale/imx8dxl-ss-conn.dtsi   | 137 +++++++++
 .../boot/dts/freescale/imx8dxl-ss-ddr.dtsi    |  36 +++
 .../boot/dts/freescale/imx8dxl-ss-lsio.dtsi   |  78 +++++
 arch/arm64/boot/dts/freescale/imx8dxl.dtsi    | 245 ++++++++++++++++
 11 files changed, 836 insertions(+), 3 deletions(-)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
 create mode 100644 arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/imx8dxl-ss-ddr.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/imx8dxl-ss-lsio.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/imx8dxl.dtsi
Signature · 1 line
2.31.1
author
#1 lore raw

PATCH v4 1/12 dt-bindings: i2c: imx-lpi2c: Fix i.MX 8QM compatible matching

The i.MX 8QM DTS files use two compatibles, so update the binding to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8qm-mek.dt.yaml: i2c@5a800000:
compatible: ['fsl,imx8qm-lpi2c', 'fsl,imx7ulp-lpi2c'] is too long

---
 Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml +3 -2
index 29b9447f3b84..fe0c89edf7c1 100644
@@ -17,9 +17,10 @@ properties:
     oneOf:
       - enum:
           - fsl,imx7ulp-lpi2c
-          - fsl,imx8qm-lpi2c
       - items:
-          - const: fsl,imx8qxp-lpi2c
+          - enum:
+              - fsl,imx8qxp-lpi2c
+              - fsl,imx8qm-lpi2c
           - const: fsl,imx7ulp-lpi2c
 
   reg:
Signature · 1 line
2.31.1
maintainer Acked-by on v4 1/12
#2 lore raw

Re: [PATCH v4 01/12] dt-bindings: i2c: imx-lpi2c: Fix i.MX 8QM compatible matching

Quoted 11 lines · Abel Vesa

The i.MX 8QM DTS files use two compatibles, so update the binding to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8qm-mek.dt.yaml: i2c@5a800000:
compatible: ['fsl,imx8qm-lpi2c', 'fsl,imx7ulp-lpi2c'] is too long

---
 Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Applied
#3 lore raw

Re: [PATCH v4 01/12] dt-bindings: i2c: imx-lpi2c: Fix i.MX 8QM compatible matching

In reply to Abel Vesa
Quoted 7 lines · Abel Vesa

The i.MX 8QM DTS files use two compatibles, so update the binding to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8qm-mek.dt.yaml: i2c@5a800000:
compatible: ['fsl,imx8qm-lpi2c', 'fsl,imx7ulp-lpi2c'] is too long

Applied to for-next, thanks!

Applied
#4 lore raw

Re: [PATCH v4 01/12] dt-bindings: i2c: imx-lpi2c: Fix i.MX 8QM compatible matching

Quoted 10 lines · Wolfram Sang
Quoted 7 lines · Abel Vesa

The i.MX 8QM DTS files use two compatibles, so update the binding to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8qm-mek.dt.yaml: i2c@5a800000:
compatible: ['fsl,imx8qm-lpi2c', 'fsl,imx7ulp-lpi2c'] is too long

Applied to for-next, thanks!

Sorry, I meant:

Applied to for-current, thanks!

author
#5 lore raw

PATCH v4 2/12 dt-bindings: serial: fsl-lpuart: Fix i.MX 8QM compatible matching

In reply to Abel Vesa

The i.MX 8QM DTS files use two compatibles, so update the binding to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8qm-mek.dt.yaml: serial@5a060000:
compatible: ['fsl,imx8qm-lpuart', 'fsl,imx8qxp-lpuart'] is too long

---
 Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +3 -0
index a90c971b4f1f..dc1f0e07cbd4 100644
@@ -24,6 +24,9 @@ properties:
       - items:
           - const: fsl,imx8qxp-lpuart
           - const: fsl,imx7ulp-lpuart
+      - items:
+          - const: fsl,imx8qm-lpuart
+          - const: fsl,imx8qxp-lpuart
 
   reg:
     maxItems: 1
Signature · 1 line
2.31.1
maintainer Acked-by on v4 2/12
#6 lore raw

Re: [PATCH v4 02/12] dt-bindings: serial: fsl-lpuart: Fix i.MX 8QM compatible matching

Quoted 10 lines · Abel Vesa

The i.MX 8QM DTS files use two compatibles, so update the binding to fix dtbs_check warnings like:

arch/arm64/boot/dts/freescale/imx8qm-mek.dt.yaml: serial@5a060000:
compatible: ['fsl,imx8qm-lpuart', 'fsl,imx8qxp-lpuart'] is too long

---
 Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 3 +++
 1 file changed, 3 insertions(+)
author
#7 lore raw

PATCH v4 3/12 arm64: dts: freescale: Add the top level dtsi support for imx8dxl

In reply to Abel Vesa

From: Jacky Bai <[email protected]>

The i.MX8DXL is a device targeting the automotive and industrial market segments. The flexibility of the architecture allows for use in a wide variety of general embedded applications. The chip is designed to achieve both high performance and low power consumption. The chip relies on the power efficient dual (2x) Cortex-A35 cluster.

Add the reserved memory node property for dsp reserved memory, the wakeup-irq property for SCU node, the imx ion, the rpmsg and the cm4 rproc support.

---
 arch/arm64/boot/dts/freescale/imx8dxl.dtsi | 245 +++++++++++++++++++++
 1 file changed, 245 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8dxl.dtsi
arch/arm64/boot/dts/freescale/imx8dxl.dtsi new file +245 -0
new file mode 100644
index 000000000000..f16f88882c39
@@ -0,0 +1,245 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2019-2021 NXP
+ */
+
+#include <dt-bindings/clock/imx8-clock.h>
+#include <dt-bindings/firmware/imx/rsrc.h>
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/pinctrl/pads-imx8dxl.h>
+#include <dt-bindings/thermal/thermal.h>
+
+/ {
+	interrupt-parent = <&gic>;
+	#address-cells = <2>;
+	#size-cells = <2>;
+
+	aliases {
+		ethernet0 = &fec1;
+		ethernet1 = &eqos;
+		gpio0 = &lsio_gpio0;
+		gpio1 = &lsio_gpio1;
+		gpio2 = &lsio_gpio2;
+		gpio3 = &lsio_gpio3;
+		gpio4 = &lsio_gpio4;
+		gpio5 = &lsio_gpio5;
+		gpio6 = &lsio_gpio6;
+		gpio7 = &lsio_gpio7;
+		i2c2 = &i2c2;
+		i2c3 = &i2c3;
+		mmc0 = &usdhc1;
+		mmc1 = &usdhc2;
+		mu1 = &lsio_mu1;
+		serial0 = &lpuart0;
+		serial1 = &lpuart1;
+		serial2 = &lpuart2;
+		serial3 = &lpuart3;
+	};
+
+	cpus: cpus {
+		#address-cells = <2>;
+		#size-cells = <0>;
+
+		/* We have 1 clusters with 2 Cortex-A35 cores */
+		A35_0: cpu@0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a35";
+			reg = <0x0 0x0>;
+			enable-method = "psci";
+			next-level-cache = <&A35_L2>;
+			clocks = <&clk IMX_SC_R_A35 IMX_SC_PM_CLK_CPU>;
+			#cooling-cells = <2>;
+			operating-points-v2 = <&a35_opp_table>;
+		};
+
+		A35_1: cpu@1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a35";
+			reg = <0x0 0x1>;
+			enable-method = "psci";
+			next-level-cache = <&A35_L2>;
+			clocks = <&clk IMX_SC_R_A35 IMX_SC_PM_CLK_CPU>;
+			#cooling-cells = <2>;
+			operating-points-v2 = <&a35_opp_table>;
+		};
+
+		A35_L2: l2-cache0 {
+			compatible = "cache";
+		};
+	};
+
+	a35_opp_table: opp-table {
+		compatible = "operating-points-v2";
+		opp-shared;
+
+		opp-900000000 {
+			opp-hz = /bits/ 64 <900000000>;
+			opp-microvolt = <1000000>;
+			clock-latency-ns = <150000>;
+		};
+
+		opp-1200000000 {
+			opp-hz = /bits/ 64 <1200000000>;
+			opp-microvolt = <1100000>;
+			clock-latency-ns = <150000>;
+			opp-suspend;
+		};
+	};
+
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		dsp_reserved: dsp@92400000 {
+			reg = <0 0x92400000 0 0x2000000>;
+			no-map;
+		};
+	};
+
+	gic: interrupt-controller@51a00000 {
+		compatible = "arm,gic-v3";
+		reg = <0x0 0x51a00000 0 0x10000>, /* GIC Dist */
+		      <0x0 0x51b00000 0 0xc0000>; /* GICR (RD_base + SGI_base) */
+		#interrupt-cells = <3>;
+		interrupt-controller;
+		interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
+	};
+
+	pmu {
+		compatible = "arm,armv8-pmuv3";
+		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
+	};
+
+	psci {
+		compatible = "arm,psci-1.0";
+		method = "smc";
+	};
+
+	scu {
+		compatible = "fsl,imx-scu";
+		mbox-names = "tx0",
+			     "rx0",
+			     "gip3";
+		mboxes = <&lsio_mu1 0 0
+			  &lsio_mu1 1 0
+			  &lsio_mu1 3 3>;
+
+		pd: imx8dxl-pd {
+			compatible = "fsl,imx8dxl-scu-pd", "fsl,scu-pd";
+			#power-domain-cells = <1>;
+		};
+
+		clk: clock-controller {
+			compatible = "fsl,imx8dxl-clk", "fsl,scu-clk";
+			#clock-cells = <2>;
+			clocks = <&xtal32k &xtal24m>;
+			clock-names = "xtal_32KHz", "xtal_24Mhz";
+		};
+
+		iomuxc: pinctrl {
+			compatible = "fsl,imx8dxl-iomuxc";
+		};
+
+		ocotp: imx8qx-ocotp {
+			compatible = "fsl,imx8dxl-scu-ocotp", "fsl,imx8qxp-scu-ocotp";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			fec_mac0: mac@2c4 {
+				reg = <0x2c4 6>;
+			};
+
+			fec_mac1: mac@2c6 {
+				reg = <0x2c6 6>;
+			};
+		};
+
+		watchdog {
+			compatible = "fsl,imx-sc-wdt";
+			timeout-sec = <60>;
+		};
+
+		tsens: thermal-sensor {
+			compatible = "fsl,imx-sc-thermal";
+			#thermal-sensor-cells = <1>;
+		};
+	};
+
+	timer {
+		compatible = "arm,armv8-timer";
+		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>, /* Physical Secure */
+			     <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>, /* Physical Non-Secure */
+			     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, /* Virtual */
+			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; /* Hypervisor */
+	};
+
+	thermal_zones: thermal-zones {
+		cpu-thermal0 {
+			polling-delay-passive = <250>;
+			polling-delay = <2000>;
+			thermal-sensors = <&tsens IMX_SC_R_SYSTEM>;
+
+			trips {
+				cpu_alert0: trip0 {
+					temperature = <107000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
+				cpu_crit0: trip1 {
+					temperature = <127000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+			cooling-maps {
+				map0 {
+					trip = <&cpu_alert0>;
+					cooling-device =
+					<&A35_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+					<&A35_1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+				};
+			};
+		};
+	};
+
+	clk_dummy: clock-dummy {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <0>;
+		clock-output-names = "clk_dummy";
+	};
+
+	xtal32k: clock-xtal32k {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <32768>;
+		clock-output-names = "xtal_32KHz";
+	};
+
+	xtal24m: clock-xtal24m {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <24000000>;
+		clock-output-names = "xtal_24MHz";
+	};
+
+	sc_pwrkey: sc-powerkey {
+		compatible = "fsl,imx8-pwrkey";
+		linux,keycode = <KEY_POWER>;
+		wakeup-source;
+	};
+
+	/* sorted in register address */
+	#include "imx8-ss-adma.dtsi"
+	#include "imx8-ss-conn.dtsi"
+	#include "imx8-ss-ddr.dtsi"
+	#include "imx8-ss-lsio.dtsi"
+};
+
+#include "imx8dxl-ss-adma.dtsi"
+#include "imx8dxl-ss-conn.dtsi"
+#include "imx8dxl-ss-lsio.dtsi"
+#include "imx8dxl-ss-ddr.dtsi"
Signature · 1 line
2.31.1
author
#8 lore raw

PATCH v4 4/12 arm64: dts: imx8-ss-lsio: Add mu5a mailbox

In reply to Abel Vesa

The mailbox of the lsio mu5a is used by rpmsg on imx8qxp and imx8dxl platforms.

---
 arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi +7 -0
index ee4e585a9c39..76abdab40c75 100644
@@ -141,6 +141,13 @@ lsio_mu4: mailbox@5d1f0000 {
 		status = "disabled";
 	};
 
+	lsio_mu5: mailbox@5d200000 {
+		reg = <0x5d200000 0x10000>;
+		interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
+		#mbox-cells = <2>;
+		power-domains = <&pd IMX_SC_R_MU_5A>;
+	};
+
 	lsio_mu13: mailbox@5d280000 {
 		reg = <0x5d280000 0x10000>;
 		interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
2.31.1
author
#9 lore raw

PATCH v4 5/12 arm64: dts: freescale: Add adma subsystem dtsi for imx8dxl

In reply to Abel Vesa

Override the I2Cs, LPUARTs, audio_ipg_clk and dma_ipg_clk with the i.MX8DXL specific properties.

---
 .../boot/dts/freescale/imx8dxl-ss-adma.dtsi   | 53 +++++++++++++++++++
 1 file changed, 53 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi
arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi new file +53 -0
new file mode 100644
index 000000000000..eccc31ee8f1b
@@ -0,0 +1,53 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2019-2021 NXP
+ */
+
+&audio_ipg_clk {
+	clock-frequency = <160000000>;
+};
+
+&dma_ipg_clk {
+	clock-frequency = <160000000>;
+};
+
+&i2c0 {
+	compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
+	interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&i2c1 {
+	compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
+	interrupts = <GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&i2c2 {
+	compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
+	interrupts = <GIC_SPI 224 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&i2c3 {
+	compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
+	interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lpuart0 {
+	compatible = "fsl,imx8dxl-lpuart", "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+	interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lpuart1 {
+	compatible = "fsl,imx8dxl-lpuart", "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+	interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lpuart2 {
+	compatible = "fsl,imx8dxl-lpuart", "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+	interrupts = <GIC_SPI 230 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lpuart3 {
+	compatible = "fsl,imx8dxl-lpuart", "fsl,imx8qxp-lpuart", "fsl,imx7ulp-lpuart";
+	interrupts = <GIC_SPI 231 IRQ_TYPE_LEVEL_HIGH>;
+};
+
Signature · 1 line
2.31.1
author
#10 lore raw

PATCH v4 6/12 arm64: dts: freescale: Add the imx8dxl connectivity subsys dtsi

In reply to Abel Vesa

From: Jacky Bai <[email protected]>

On i.MX8DXL, the Connectivity subsystem includes below peripherals:
1x ENET with AVB support, 1x ENET with TSN support, 2x USB OTG, 1x eMMC, 2x SD, 1x NAND.

---
 .../boot/dts/freescale/imx8dxl-ss-conn.dtsi   | 137 ++++++++++++++++++
 1 file changed, 137 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi
arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi new file +137 -0
new file mode 100644
index 000000000000..b0059296a03f
@@ -0,0 +1,137 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2019-2021 NXP
+ */
+
+/delete-node/ &enet1_lpcg;
+/delete-node/ &fec2;
+
+&conn_subsys {
+	conn_enet0_root_clk: clock-conn-enet0-root {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <250000000>;
+		clock-output-names = "conn_enet0_root_clk";
+	};
+
+	eqos: ethernet@5b050000 {
+		compatible = "nxp,imx8dxl-dwmac-eqos", "snps,dwmac-5.10a";
+		reg = <0x5b050000 0x10000>;
+		interrupt-parent = <&gic>;
+		interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "eth_wake_irq", "macirq";
+		clocks = <&eqos_lpcg IMX_LPCG_CLK_2>,
+			 <&eqos_lpcg IMX_LPCG_CLK_4>,
+			 <&eqos_lpcg IMX_LPCG_CLK_0>,
+			 <&eqos_lpcg IMX_LPCG_CLK_3>,
+			 <&eqos_lpcg IMX_LPCG_CLK_1>;
+		clock-names = "stmmaceth", "pclk", "ptp_ref", "tx", "mem";
+		assigned-clocks = <&clk IMX_SC_R_ENET_1 IMX_SC_PM_CLK_PER>;
+		assigned-clock-rates = <125000000>;
+		power-domains = <&pd IMX_SC_R_ENET_1>;
+		clk_csr = <0>;
+		status = "disabled";
+	};
+
+	usbotg2: usb@5b0e0000 {
+		compatible = "fsl,imx8dxl-usb", "fsl,imx7ulp-usb";
+		reg = <0x5b0e0000 0x200>;
+		interrupt-parent = <&gic>;
+		interrupts = <GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>;
+		fsl,usbphy = <&usbphy2>;
+		fsl,usbmisc = <&usbmisc2 0>;
+		/*
+		 * usbotg1 and usbotg2 share one clcok
+		 * scfw disable clock access and keep it always on
+		 * in case other core (M4) use one of these.
+		 */
+		clocks = <&clk_dummy>;
+		ahb-burst-config = <0x0>;
+		tx-burst-size-dword = <0x10>;
+		rx-burst-size-dword = <0x10>;
+		#stream-id-cells = <1>;
+		power-domains = <&pd IMX_SC_R_USB_1>;
+		status = "disabled";
+	};
+
+	usbmisc2: usbmisc@5b0e0200 {
+		#index-cells = <1>;
+		compatible = "fsl,imx8dxl-usbmisc", "fsl,imx7ulp-usbmisc";
+		reg = <0x5b0e0200 0x200>;
+	};
+
+	usbphy2: usbphy@0x5b110000 {
+		compatible = "fsl,imx8dxl-usbphy", "fsl,imx7ulp-usbphy";
+		reg = <0x5b110000 0x1000>;
+		clocks = <&usb2_2_lpcg IMX_LPCG_CLK_7>;
+		status = "disabled";
+	};
+
+	eqos_lpcg: clock-controller@5b240000 {
+		compatible = "fsl,imx8qxp-lpcg";
+		reg = <0x5b240000 0x10000>;
+		#clock-cells = <1>;
+		clocks = <&conn_enet0_root_clk>,
+			 <&conn_axi_clk>,
+			 <&conn_axi_clk>,
+			 <&clk IMX_SC_R_ENET_1 IMX_SC_PM_CLK_PER>,
+			 <&conn_ipg_clk>;
+		clock-indices = <IMX_LPCG_CLK_0>,
+				<IMX_LPCG_CLK_2>,
+				<IMX_LPCG_CLK_4>,
+				<IMX_LPCG_CLK_5>,
+				<IMX_LPCG_CLK_6>;
+		clock-output-names = "eqos_ptp",
+				     "eqos_mem_clk",
+				     "eqos_aclk",
+				     "eqos_clk",
+				     "eqos_csr_clk";
+		power-domains = <&pd IMX_SC_R_ENET_1>;
+	};
+
+	usb2_2_lpcg: clock-controller@5b280000 {
+		compatible = "fsl,imx8qxp-lpcg";
+		reg = <0x5b280000 0x10000>;
+		#clock-cells = <1>;
+
+		clock-indices = <IMX_LPCG_CLK_7>;
+		clocks = <&conn_ipg_clk>;
+		clock-output-names = "usboh3_2_phy_ipg_clk";
+	};
+
+};
+
+&enet0_lpcg {
+	clocks = <&conn_enet0_root_clk>,
+		 <&conn_enet0_root_clk>,
+		 <&conn_axi_clk>,
+		 <&clk IMX_SC_R_ENET_0 IMX_SC_C_TXCLK>,
+		 <&conn_ipg_clk>,
+		 <&conn_ipg_clk>;
+};
+
+&fec1 {
+	compatible = "fsl,imx8dxl-fec", "fsl,imx8qm-fec";
+	interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
+		     <GIC_SPI 158 IRQ_TYPE_LEVEL_HIGH>,
+		     <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>,
+		     <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>;
+	assigned-clocks = <&clk IMX_SC_R_ENET_0 IMX_SC_C_CLKDIV>;
+	assigned-clock-rates = <125000000>;
+};
+
+&usdhc1 {
+	compatible = "fsl,imx8dxl-usdhc", "fsl,imx8qxp-usdhc";
+	interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&usdhc2 {
+	compatible = "fsl,imx8dxl-usdhc", "fsl,imx8qxp-usdhc";
+	interrupts = <GIC_SPI 139 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&usdhc3 {
+	compatible = "fsl,imx8dxl-usdhc", "fsl,imx8qxp-usdhc";
+	interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
+};
Signature · 1 line
2.31.1
author
#11 lore raw

PATCH v4 7/12 arm64: dts: freescale: Add ddr subsys dtsi for imx8dxl

In reply to Abel Vesa

From: Jacky Bai <[email protected]>

Add the ddr subsys dtsi for i.MX8DXL. Additional db pmu is added compared to i.MX8QXP.

---
 .../boot/dts/freescale/imx8dxl-ss-ddr.dtsi    | 36 +++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8dxl-ss-ddr.dtsi
arch/arm64/boot/dts/freescale/imx8dxl-ss-ddr.dtsi new file +36 -0
new file mode 100644
index 000000000000..75b482966d94
@@ -0,0 +1,36 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2021 NXP
+ */
+
+&ddr_subsys {
+	db_ipg_clk: clock-db-ipg {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <456000000>;
+		clock-output-names = "db_ipg_clk";
+	};
+
+	db_pmu0: db-pmu@5ca40000 {
+		compatible = "fsl,imx8dxl-db-pmu";
+		reg = <0x5ca40000 0x10000>;
+		interrupt-parent = <&gic>;
+		interrupts = <GIC_SPI 338 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&db_pmu0_lpcg IMX_LPCG_CLK_0>,
+			 <&db_pmu0_lpcg IMX_LPCG_CLK_1>;
+		clock-names = "ipg", "cnt";
+		power-domains = <&pd IMX_SC_R_PERF>;
+	};
+
+	db_pmu0_lpcg: clock-controller@5cae0000 {
+		compatible = "fsl,imx8qxp-lpcg";
+		reg = <0x5cae0000 0x10000>;
+		#clock-cells = <1>;
+		clocks = <&db_ipg_clk>, <&db_ipg_clk>;
+		clock-indices = <IMX_LPCG_CLK_0>,
+				<IMX_LPCG_CLK_1>;
+		clock-output-names = "perf_lpcg_cnt_clk",
+				     "perf_lpcg_ipg_clk";
+		power-domains = <&pd IMX_SC_R_PERF>;
+	};
+};
Signature · 1 line
2.31.1
author
#12 lore raw

PATCH v4 8/12 arm64: dts: freescale: Add lsio subsys dtsi for imx8dxl

In reply to Abel Vesa

From: Jacky Bai <[email protected]>

On i.MX8DXL, the LSIO subsystem includes below devices:

1x Inline Encryption Engine (IEE)
1x FlexSPI
4x Pulse Width Modulator (PWM)
5x General Purpose Timer (GPT)
8x GPIO
14x Message Unit (MU)
256KB On-Chip Memory (OCRAM)

compared to the common imx8-ss-lsio dtsi, some nodes' interrupt property need to be updated.

---
 .../boot/dts/freescale/imx8dxl-ss-lsio.dtsi   | 78 +++++++++++++++++++
 1 file changed, 78 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8dxl-ss-lsio.dtsi
arch/arm64/boot/dts/freescale/imx8dxl-ss-lsio.dtsi new file +78 -0
new file mode 100644
index 000000000000..d90602bab384
@@ -0,0 +1,78 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2019-2021 NXP
+ */
+&lsio_gpio0 {
+	compatible = "fsl,imx8dxl-gpio", "fsl,imx35-gpio";
+	interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lsio_gpio1 {
+	compatible = "fsl,imx8dxl-gpio", "fsl,imx35-gpio";
+	interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lsio_gpio2 {
+	compatible = "fsl,imx8dxl-gpio", "fsl,imx35-gpio";
+	interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lsio_gpio3 {
+	compatible = "fsl,imx8dxl-gpio", "fsl,imx35-gpio";
+	interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lsio_gpio4 {
+	compatible = "fsl,imx8dxl-gpio", "fsl,imx35-gpio";
+	interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lsio_gpio5 {
+	compatible = "fsl,imx8dxl-gpio", "fsl,imx35-gpio";
+	interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lsio_gpio6 {
+	compatible = "fsl,imx8dxl-gpio", "fsl,imx35-gpio";
+	interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lsio_gpio7 {
+	compatible = "fsl,imx8dxl-gpio", "fsl,imx35-gpio";
+	interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lsio_mu0 {
+	compatible = "fsl,imx8dxl-mu", "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
+	interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lsio_mu1 {
+	compatible = "fsl,imx8-mu-scu", "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
+	interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lsio_mu2 {
+	compatible = "fsl,imx8-mu-scu", "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
+	interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lsio_mu3 {
+	compatible = "fsl,imx8-mu-scu", "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
+	interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lsio_mu4 {
+	compatible = "fsl,imx8-mu-scu", "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
+	interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lsio_mu5 {
+	compatible = "fsl,imx8-mu-scu", "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
+	interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&lsio_mu13 {
+	compatible = "fsl,imx8-mu-scu", "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
+	interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
+};
Signature · 1 line
2.31.1
author
#13 lore raw

PATCH v4 9/12 arm64: dts: imx8dxl: Add i.MX8DXL evk board support

In reply to Abel Vesa

From: Jacky Bai <[email protected]>

Add i.MX8DXL EVK board support.

---
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 266 ++++++++++++++++++
 2 files changed, 267 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
arch/arm64/boot/dts/freescale/Makefile +1 -0
index a14a6173b765..c350bbcc601d 100644
@@ -67,6 +67,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mq-pico-pi.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-thor96.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-zii-ultra-rmb3.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mq-zii-ultra-zest.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8dxl-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8qm-mek.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8qxp-ai_ml.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8qxp-colibri-eval-v3.dtb
arch/arm64/boot/dts/freescale/imx8dxl-evk.dts new file +266 -0

266 lines not on this page · raw message

Signature · 1 line
2.31.1
author
#14 lore raw

PATCH v4 10/12 dt-bindings: fsl: scu: Add i.MX8DXL ocotp binding

In reply to Abel Vesa

Add i.MX8DXL ocotp compatible to the SCU bindings documentation.

---
 Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt +2 -1
index fd0061712443..f1470d562156 100644
@@ -141,7 +141,8 @@ OCOTP bindings based on SCU Message Protocol
 Required properties:
 - compatible:		Should be one of:
 			"fsl,imx8qm-scu-ocotp",
-			"fsl,imx8qxp-scu-ocotp".
+			"fsl,imx8qxp-scu-ocotp",
+			"fsl,imx8dxl-scu-ocotp".
 - #address-cells:	Must be 1. Contains byte index
 - #size-cells:		Must be 1. Contains byte length
 
Signature · 1 line
2.31.1
author
#15 lore raw

PATCH v4 11/12 dt-bindings: i2c: imx-lpi2c: Add i.MX8DXL compatible match

In reply to Abel Vesa

Add i.MX8DXL lpi2c compatible to the bindings documentation.

---
 Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml +1 -0
index fe0c89edf7c1..1fb6a0469a25 100644
@@ -20,6 +20,7 @@ properties:
       - items:
           - enum:
               - fsl,imx8qxp-lpi2c
+              - fsl,imx8dxl-lpi2c
               - fsl,imx8qm-lpi2c
           - const: fsl,imx7ulp-lpi2c
 
Signature · 1 line
2.31.1
maintainer Acked-by on v4 11/12
#16 lore raw

Re: [PATCH v4 11/12] dt-bindings: i2c: imx-lpi2c: Add i.MX8DXL compatible match

Quoted 7 lines · Abel Vesa

Add i.MX8DXL lpi2c compatible to the bindings documentation.

---
 Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 1 +
 1 file changed, 1 insertion(+)
author
#18 lore raw

PATCH v4 12/12 dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible

In reply to Abel Vesa

Add i.MX8DXL lpuart compatible to the bindings documentation.

---
 Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +4 -0
index dc1f0e07cbd4..fa8a602ccb22 100644
@@ -27,6 +27,10 @@ properties:
       - items:
           - const: fsl,imx8qm-lpuart
           - const: fsl,imx8qxp-lpuart
+      - items:
+          - const: fsl,imx8dxl-lpuart
+          - const: fsl,imx8qxp-lpuart
+          - const: fsl,imx7ulp-lpuart
 
   reg:
     maxItems: 1
Signature · 1 line
2.31.1
maintainer
#19 lore raw

Re: [PATCH v4 12/12] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible

Quoted 12 lines · Abel Vesa

Add i.MX8DXL lpuart compatible to the bindings documentation.

---
 Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +0 -0
index dc1f0e07cbd4..fa8a602ccb22 100644

Documentation/devicetree/bindings/serial/fsl-lpuart.yaml properties: · line 33

Quoted 7 lines
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +4 -0
@@ -27,6 +27,10 @@ properties:
       - items:
           - const: fsl,imx8qm-lpuart
           - const: fsl,imx8qxp-lpuart
+      - items:
+          - const: fsl,imx8dxl-lpuart
+          - const: fsl,imx8qxp-lpuart
+          - const: fsl,imx7ulp-lpuart

I'm confused why 8dxl is compatible with 7ulp, but 8qm is not? From the driver, it looks like the difference is clocks.

Quoted 7 lines
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +0 -0
   reg:
     maxItems: 1
Signature · 1 line
2.31.1
#20 lore raw

Re: (EXT) Re: [PATCH v4 12/12] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible

Am Donnerstag, dem 18.11.2021 um 19:04 -0600 schrieb Rob Herring:

Quoted 20 lines · Abel Vesa
Quoted 19 lines

Add i.MX8DXL lpuart compatible to the bindings documentation.

Signed-off-by: Abel Vesa <
[email protected]

Quoted 1 line
---
 Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl- lpuart.yaml
index dc1f0e07cbd4..fa8a602ccb22 100644

Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +0 -0
@@ -27,6 +27,10 @@ properties:
       - items:
           - const: fsl,imx8qm-lpuart
           - const: fsl,imx8qxp-lpuart
Quoted 8 lines

Documentation/devicetree/bindings/serial/fsl-lpuart.yaml properties: · line 33

Quoted 4 lines
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +4 -0
+      - items:
+          - const: fsl,imx8dxl-lpuart
+          - const: fsl,imx8qxp-lpuart
+          - const: fsl,imx7ulp-lpuart

I'm confused why 8dxl is compatible with 7ulp, but 8qm is not? From the
driver, it looks like the difference is clocks.

There is a difference between 8qm and 7ulp regarding the clocks. Are they still considered compatible? Depending on the answer [1] might not be the correct solution for earlycon regression on 8qm.

Best regards,
Alexander

[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2021-November/696770.html

author
#21 lore raw

Re: (EXT) Re: [PATCH v4 12/12] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible

Quoted 30 lines · Alexander Stein

Am Donnerstag, dem 18.11.2021 um 19:04 -0600 schrieb Rob Herring:

Quoted 20 lines · Abel Vesa
Quoted 19 lines

Add i.MX8DXL lpuart compatible to the bindings documentation.

Signed-off-by: Abel Vesa <
[email protected]

Quoted 1 line
---
 Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl- lpuart.yaml
index dc1f0e07cbd4..fa8a602ccb22 100644

Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +0 -0
@@ -27,6 +27,10 @@ properties:
       - items:
           - const: fsl,imx8qm-lpuart
           - const: fsl,imx8qxp-lpuart
Quoted 8 lines

Documentation/devicetree/bindings/serial/fsl-lpuart.yaml properties: · line 33

Quoted 4 lines
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +4 -0
+      - items:
+          - const: fsl,imx8dxl-lpuart
+          - const: fsl,imx8qxp-lpuart
+          - const: fsl,imx7ulp-lpuart

I'm confused why 8dxl is compatible with 7ulp, but 8qm is not? From the
driver, it looks like the difference is clocks.

Quoted 4 lines

There is a difference between 8qm and 7ulp regarding the clocks. Are they still considered compatible? Depending on the answer [1] might not be the correct solution for earlycon regression on 8qm.

In NXP's tree, they are not compatible.

See here:

https://source.codeaurora.org/external/imx/linux-imx/tree/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi?h=lf-5.10.y#n9

Quoted 7 lines

Best regards,
Alexander

[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2021-November/696770.html

#22 lore raw

Re: (EXT) Re: (EXT) Re: [PATCH v4 12/12] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible

Am Montag, dem 22.11.2021 um 18:45 +0200 schrieb Abel Vesa:

Quoted 41 lines · Alexander Stein
Quoted 33 lines

Am Donnerstag, dem 18.11.2021 um 19:04 -0600 schrieb Rob Herring:

Quoted 23 lines · Abel Vesa
Quoted 22 lines

Add i.MX8DXL lpuart compatible to the bindings documentation.

Signed-off-by: Abel Vesa <
[email protected]

---
 Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4
++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl- lpuart.yaml
index dc1f0e07cbd4..fa8a602ccb22 100644

Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +1 -0
@@ -27,6 +27,10 @@ properties:
       - items:
           - const: fsl,imx8qm-lpuart
           - const: fsl,imx8qxp-lpuart
+      - items:
Quoted 8 lines

Documentation/devicetree/bindings/serial/fsl-lpuart.yaml properties: · line 33

Quoted 3 lines
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +3 -0
+          - const: fsl,imx8dxl-lpuart
+          - const: fsl,imx8qxp-lpuart
+          - const: fsl,imx7ulp-lpuart

I'm confused why 8dxl is compatible with 7ulp, but 8qm is not? From
the
driver, it looks like the difference is clocks.

Quoted 6 lines

There is a difference between 8qm and 7ulp regarding the clocks. Are
they still considered compatible? Depending on the answer [1] might not
be the correct solution for earlycon regression on 8qm.

Quoted 5 lines

In NXP's tree, they are not compatible.

See here:

https://source.codeaurora.org/external/imx/linux-imx/tree/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi?h=lf-5.10.y#n9

Well, commit
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b4b844930f27bf7019c0bbd8cc575dde32e00ecc
says otherwise.
This might be true for earlycon only, because clocks should be setup already.

Together with your other mail regarding the imx7ulp fixup, commit b4b844930f27bf7019c0bbd8cc575dde32e00ecc should just be reverted in order to get earlycon running again on imx8qm and imx8qxp, IMHO.

Best regards,
Alexander

author
#23 lore raw

Re: (EXT) Re: (EXT) Re: [PATCH v4 12/12] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible

Quoted 54 lines · Alexander Stein

Am Montag, dem 22.11.2021 um 18:45 +0200 schrieb Abel Vesa:

Quoted 41 lines · Alexander Stein
Quoted 33 lines

Am Donnerstag, dem 18.11.2021 um 19:04 -0600 schrieb Rob Herring:

Quoted 23 lines · Abel Vesa
Quoted 22 lines

Add i.MX8DXL lpuart compatible to the bindings documentation.

Signed-off-by: Abel Vesa <
[email protected]

---
 Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4
++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl- lpuart.yaml
index dc1f0e07cbd4..fa8a602ccb22 100644

Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +1 -0
@@ -27,6 +27,10 @@ properties:
       - items:
           - const: fsl,imx8qm-lpuart
           - const: fsl,imx8qxp-lpuart
+      - items:
Quoted 8 lines

Documentation/devicetree/bindings/serial/fsl-lpuart.yaml properties: · line 33

Quoted 3 lines
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +3 -0
+          - const: fsl,imx8dxl-lpuart
+          - const: fsl,imx8qxp-lpuart
+          - const: fsl,imx7ulp-lpuart

I'm confused why 8dxl is compatible with 7ulp, but 8qm is not? From
the
driver, it looks like the difference is clocks.

Quoted 6 lines

There is a difference between 8qm and 7ulp regarding the clocks. Are
they still considered compatible? Depending on the answer [1] might not
be the correct solution for earlycon regression on 8qm.

Quoted 5 lines

In NXP's tree, they are not compatible.

See here:

https://source.codeaurora.org/external/imx/linux-imx/tree/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi?h=lf-5.10.y#n9

Well, commit
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b4b844930f27bf7019c0bbd8cc575dde32e00ecc
says otherwise.
This might be true for earlycon only, because clocks should be setup already.

Quoted 4 lines

Together with your other mail regarding the imx7ulp fixup, commit b4b844930f27bf7019c0bbd8cc575dde32e00ecc should just be reverted in order to get earlycon running again on imx8qm and imx8qxp, IMHO.

I think you're right, the commit b4b844930f27bf7019c should be reverted.

You can send the revert yourself, if you want. If not, let me know.

Quoted 4 lines

Best regards,
Alexander

#24 lore raw

Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH v4 12/12] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible

Am Donnerstag, dem 25.11.2021 um 15:19 +0200 schrieb Abel Vesa:

Quoted 73 lines · Alexander Stein
Quoted 66 lines

Am Montag, dem 22.11.2021 um 18:45 +0200 schrieb Abel Vesa:

Quoted 50 lines · Alexander Stein
Quoted 40 lines

Am Donnerstag, dem 18.11.2021 um 19:04 -0600 schrieb Rob Herring:

Quoted 29 lines · Abel Vesa
Quoted 28 lines

Add i.MX8DXL lpuart compatible to the bindings
documentation.

Signed-off-by: Abel Vesa <
[email protected]

---
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml |
4
++++

 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl- lpuart.yaml
index dc1f0e07cbd4..fa8a602ccb22 100644
--- a/Documentation/devicetree/bindings/serial/fsl- lpuart.yaml
+++ b/Documentation/devicetree/bindings/serial/fsl- lpuart.yaml

Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +2 -0
@@ -27,6 +27,10 @@ properties:
       - items:
           - const: fsl,imx8qm-lpuart
           - const: fsl,imx8qxp-lpuart
+      - items:
+          - const: fsl,imx8dxl-lpuart
Quoted 8 lines

Documentation/devicetree/bindings/serial/fsl-lpuart.yaml properties: · line 33

Quoted 2 lines
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +2 -0
+          - const: fsl,imx8qxp-lpuart
+          - const: fsl,imx7ulp-lpuart

I'm confused why 8dxl is compatible with 7ulp, but 8qm is not?
From
the
driver, it looks like the difference is clocks.

Quoted 8 lines

There is a difference between 8qm and 7ulp regarding the clocks.
Are
they still considered compatible? Depending on the answer [1] might
not
be the correct solution for earlycon regression on 8qm.

Quoted 6 lines

In NXP's tree, they are not compatible.

See here:

https://source.codeaurora.org/external/imx/linux-imx/tree/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi?h=lf-5.10.y#n9

Well, commit
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b4b844930f27bf7019c0bbd8cc575dde32e00ecc

says otherwise.
This might be true for earlycon only, because clocks should be setup
already.

Quoted 5 lines

Together with your other mail regarding the imx7ulp fixup, commit b4b844930f27bf7019c0bbd8cc575dde32e00ecc should just be reverted
in order to get earlycon running again on imx8qm and imx8qxp, IMHO.

Quoted 4 lines

I think you're right, the commit b4b844930f27bf7019c should be reverted.

You can send the revert yourself, if you want. If not, let me know.

It's already there:

https://lore.kernel.org/all/[email protected]/T/

Thanks,
Alexander

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author
#25 lore raw

Re: [PATCH v4 12/12] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible

In reply to Rob Herring
Quoted 8 lines · Rob Herring
Quoted 7 lines · Abel Vesa

Add i.MX8DXL lpuart compatible to the bindings documentation.

---
 Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Quoted 16 lines

Documentation/devicetree/bindings/serial/fsl-lpuart.yaml properties: · line 33

Quoted 12 lines
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +4 -0
index dc1f0e07cbd4..fa8a602ccb22 100644
@@ -27,6 +27,10 @@ properties:
       - items:
           - const: fsl,imx8qm-lpuart
           - const: fsl,imx8qxp-lpuart
+      - items:
+          - const: fsl,imx8dxl-lpuart
+          - const: fsl,imx8qxp-lpuart
+          - const: fsl,imx7ulp-lpuart

I'm confused why 8dxl is compatible with 7ulp, but 8qm is not? From the driver, it looks like the difference is clocks.

There are still things to be upstreamed for the fsl-lpuart driver. Looking at the NXP's tree, 7ulp has some specific fixup that the 8qm doesn't need.

Have a look here:

https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/tty/serial/fsl_lpuart.c?h=lf-5.10.y#n3242

Quoted 7 lines
Quoted 7 lines
Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +0 -0
   reg:
     maxItems: 1
Signature · 1 line
2.31.1