FAILED: patch "[PATCH] bcache: fix use-after-free problem in bcache_device_free()" failed to apply to 5.14-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 5.14-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 8468f45091d2866affed6f6a7aecc20779139173 Mon Sep 17 00:00:00 2001
From: Coly Li <[email protected]>
Date: Wed, 3 Nov 2021 14:49:17 +0800
Subject: [PATCH] bcache: fix use-after-free problem in bcache_device_free()
In bcache_device_free(), pointer disk is referenced still in ida_simple_remove() after blk_cleanup_disk() gets called on this pointer. This may cause a potential panic by use-after-free on the disk pointer.
This patch fixes the problem by calling blk_cleanup_disk() after ida_simple_remove().
drivers/md/bcache/super.c +1 -1
@@ -885,9 +885,9 @@ static void bcache_device_free(struct bcache_device *d)bcache_device_detach (d);if (disk) { -blk_cleanup_disk (disk);ida_simple_remove (&bcache_device_idx,first_minor_to_idx (disk->first_minor)); +blk_cleanup_disk (disk); }bioset_exit (&d->bio_split);