package/bdwgc: bump to 8.0.6

Buildroot Ivan Maidanski via buildroot 2 participants 3 messages Nov 15, 2021 – Nov 16, 2021

Share & tools

Ivan Maidanski via buildroot

author

2021-11-15 21:41 UTC #0 lore raw

Hello,
Here’s a patch updating bdwgc from 8.0.4 to 8.0.6.
--
Regards,
Ivan Maidanski

From 2c723988bf122e3780d2536dbae1a45bf7b758a5 Mon Sep 17 00:00:00 2001
From: Ivan Maidanski <[email protected]>
Date: Sun, 14 Nov 2021 16:34:36 +0300
Subject: [PATCH 1/1] package/bdwgc: bump to 8.0.6

- Remove patch (already in version)
- Change URL to Github releases
- Remove --disable-cplusplus which is default behavior

Signed-off-by Ivan Maidanski <[email protected]>

---
 ...ference-to-__data_start-linker-error.patch | 33 -------------------
 package/bdwgc/Config.in                       |  2 +-
 package/bdwgc/bdwgc.hash                      |  4 +--
 package/bdwgc/bdwgc.mk                        |  6 ++--
 4 files changed, 5 insertions(+), 40 deletions(-)
 delete mode 100644 package/bdwgc/0001-Fix-undefined-reference-to-__data_start-linker-error.patch

package/bdwgc/0001-Fix-undefined-reference-to-__data_start-linker-error.patch deleted +0 ~~-33~~

deleted file mode 100644
index 81221c9f66..0000000000
@@ -1,33 +0,0 @@
-From 301ef15aefa6764466c374d07efb511b1c3862cc Mon Sep 17 00:00:00 2001
-From: Nikita Ermakov <[email protected]>
-Date: Wed, 20 May 2020 17:57:17 +0300
-Subject: [PATCH] Fix 'undefined reference to __data_start' linker error on
- RISC-V
-
-Issue #294 (bdwgc).
-
-* include/private/gcconfig.h [RISCV && LINUX] (__data_start): Add
-attribute(weak).
-
-(cherry picked from commit 538562ad01b181f4cc3913da1ac06a77945cd9b9)
-Signed-off-by: Romain Naour <[email protected]>
----
- include/private/gcconfig.h | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/include/private/gcconfig.h b/include/private/gcconfig.h
-index d9d45da1..d6cefa6f 100644
---- a/include/private/gcconfig.h
-+++ b/include/private/gcconfig.h
-@@ -2943,7 +2943,7 @@ EXTERN_C_BEGIN
- #   define ALIGNMENT (CPP_WORDSZ/8)
- #   ifdef LINUX
- #     define OS_TYPE "LINUX"
--      extern int __data_start[];
-+      extern int __data_start[] __attribute__((__weak__));
- #     define DATASTART ((ptr_t)__data_start)
- #     define LINUX_STACKBOTTOM
- #     define DYNAMIC_LOADING
--- 
-2.30.2
-

package/bdwgc/Config.in +1 -1

index 95139efb93..aad2bc9ef2 100644
@@ -7,4 +7,4 @@ config BR2_PACKAGE_BDWGC
 	  be used as a garbage collecting replacement for C 'malloc'
 	  or C++ 'new'.
 
-	  http://www.hboehm.info/gc/
+	  https://www.hboehm.info/gc/

package/bdwgc/bdwgc.hash +2 -2

index 4d22131964..d0459969b5 100644
@@ -1,3 +1,3 @@
 # Locally computed
-sha256 436a0ddc67b1ac0b0405b61a9675bca9e075c8156f4debd1d06f3a56c7cd289d  gc-8.0.4.tar.gz
-sha256 aeeaabbf44e67d413e18719f0c6ac9c23387ab0b33e7a15ee46cf59ddef12cc7  README.QUICK
+sha256 3b4914abc9fa76593596773e4da671d7ed4d5390e3d46fbf2e5f155e121bea11  gc-8.0.6.tar.gz
+sha256 0aab7a56a92ed878c4a5464cf282d65f38bcdee64fe9cf213e26254bddb3f340  README.QUICK

package/bdwgc/bdwgc.mk +2 -4

index 57dd82cab4..54bc4fd889 100644
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-BDWGC_VERSION = 8.0.4
+BDWGC_VERSION = 8.0.6
 BDWGC_SOURCE = gc-$(BDWGC_VERSION).tar.gz
-BDWGC_SITE = http://www.hboehm.info/gc/gc_source
+BDWGC_SITE = https://github.com/ivmai/bdwgc/releases/download/v$(BDWGC_VERSION)
 BDWGC_INSTALL_STAGING = YES
 BDWGC_LICENSE = bdwgc license
 BDWGC_LICENSE_FILES = README.QUICK

@@ -28,8 +28,6 @@ HOST_BDWGC_CONF_OPTS = --with-libatomic-ops=yes
 
 ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
 BDWGC_CONF_OPTS += --enable-cplusplus
-else
-BDWGC_CONF_OPTS += --disable-cplusplus
 endif
 
 $(eval $(autotools-package))

Signature · 1 line

2.33.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Thomas Petazzoni

2021-11-15 22:34 UTC #1 lore raw

Hello Ivan,

Quoted 1 line · On Tue, 16 Nov 2021 00:40:44 +0300 Ivan Maidanski via buildroot…

Here’s a patch updating bdwgc from 8.0.4 to 8.0.6.

I have applied your patch to the next branch, with some changes (see below). However, for future patches, could you use "git send-email" to send them so that the patch appears inline, which makes it easier to review?

Here is your patch:

package/bdwgc/bdwgc.hash line 3

Quoted 4 lines

package/bdwgc/bdwgc.hash +2 -2

-sha256 436a0ddc67b1ac0b0405b61a9675bca9e075c8156f4debd1d06f3a56c7cd289d  gc-8.0.4.tar.gz
-sha256 aeeaabbf44e67d413e18719f0c6ac9c23387ab0b33e7a15ee46cf59ddef12cc7  README.QUICK
+sha256 3b4914abc9fa76593596773e4da671d7ed4d5390e3d46fbf2e5f155e121bea11  gc-8.0.6.tar.gz
+sha256 0aab7a56a92ed878c4a5464cf282d65f38bcdee64fe9cf213e26254bddb3f340  README.QUICK

When the license file hash changes, we want an indication in the commit log explaining why it has changed. Indeed, the reason why we have such hashes is to detect changes in the license terms of upstream projects. If we "silently" change such hashes without a proper justification, it kind of defeats the entire purpose of those hashes. After checking the differences in README.QUICK between 8.0.4 and 8.0.6, I've added an explanation in the commit log.

Quoted 17 lines

package/bdwgc/bdwgc.mk +2 -2

index 57dd82cab4..54bc4fd889 100644
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-BDWGC_VERSION = 8.0.4
+BDWGC_VERSION = 8.0.6
 BDWGC_SOURCE = gc-$(BDWGC_VERSION).tar.gz
-BDWGC_SITE = http://www.hboehm.info/gc/gc_source
+BDWGC_SITE = https://github.com/ivmai/bdwgc/releases/download/v$(BDWGC_VERSION)
 BDWGC_INSTALL_STAGING = YES
 BDWGC_LICENSE = bdwgc license
 BDWGC_LICENSE_FILES = README.QUICK

package/bdwgc/bdwgc.mk HOST_BDWGC_CONF_OPTS = --with-libatomic-ops=yes · line 32

Quoted 5 lines

package/bdwgc/bdwgc.mk +0 -2

@@ -28,8 +28,6 @@ HOST_BDWGC_CONF_OPTS = --with-libatomic-ops=yes
 
 ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
 BDWGC_CONF_OPTS += --enable-cplusplus
-else
-BDWGC_CONF_OPTS += --disable-cplusplus

No, we want to keep this, even if this is the default. We want to be explicit about such options, which is what we do in the vast majority of packages. So I've reverted that particular change from your patch when applying.

Thanks a lot!

Thomas

Signature · 7 lines

Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Ivan Maidanski via buildroot

author

2021-11-16 08:09 UTC #2 lore raw

Hello Thomas,

Got it, agree.
Thank you!

Quoted 57 lines

Tue, 16 Nov 2021, 1:34 +03:00 from Thomas Petazzoni <[email protected]>:

Hello Ivan,
Quoted 1 line · On Tue, 16 Nov 2021 00:40:44 +0300 Ivan Maidanski via buildroot <…
Here’s a patch updating bdwgc from 8.0.4 to 8.0.6.
I have applied your patch to the next branch, with some changes (see below). However, for future patches, could you use "git send-email" to send them so that the patch appears inline, which makes it easier to review?
Here is your patch:
package/bdwgc/bdwgc.hash line 3
Quoted 4 lines
package/bdwgc/bdwgc.hash +2 -2
-sha256 436a0ddc67b1ac0b0405b61a9675bca9e075c8156f4debd1d06f3a56c7cd289d gc-8.0.4.tar.gz
-sha256 aeeaabbf44e67d413e18719f0c6ac9c23387ab0b33e7a15ee46cf59ddef12cc7 README.QUICK
+sha256 3b4914abc9fa76593596773e4da671d7ed4d5390e3d46fbf2e5f155e121bea11 gc-8.0.6.tar.gz
+sha256 0aab7a56a92ed878c4a5464cf282d65f38bcdee64fe9cf213e26254bddb3f340 README.QUICK
When the license file hash changes, we want an indication in the commit log explaining why it has changed. Indeed, the reason why we have such hashes is to detect changes in the license terms of upstream projects. If we "silently" change such hashes without a proper justification, it kind of defeats the entire purpose of those hashes. After checking the differences in README.QUICK between 8.0.4 and 8.0.6, I've added an explanation in the commit log.
Quoted 20 lines
package/bdwgc/bdwgc.mk +1 -1
index 57dd82cab4..54bc4fd889 100644
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-BDWGC_VERSION = 8.0.4
+BDWGC_VERSION = 8.0.6
BDWGC_SOURCE = gc-$(BDWGC_VERSION).tar.gz
package/bdwgc/bdwgc.mk +1 -1
-BDWGC_SITE =  http://www.hboehm.info/gc/gc_source
+BDWGC_SITE =  https://github.com/ivmai/bdwgc/releases/download/v$(BDWGC_VERSION )
BDWGC_INSTALL_STAGING = YES
BDWGC_LICENSE = bdwgc license
BDWGC_LICENSE_FILES = README.QUICK
package/bdwgc/bdwgc.mk +0 -0
@@ -28,8 +28,6 @@ HOST_BDWGC_CONF_OPTS = --with-libatomic-ops=yes
 
 ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
BDWGC_CONF_OPTS += --enable-cplusplus
package/bdwgc/bdwgc.mk HOST_BDWGC_CONF_OPTS = --with-libatomic-ops=yes · line 32
Quoted 2 lines
package/bdwgc/bdwgc.mk +0 -2
-else
-BDWGC_CONF_OPTS += --disable-cplusplus
No, we want to keep this, even if this is the default. We want to be explicit about such options, which is what we do in the vast majority of packages. So I've reverted that particular change from your patch when applying.

Quoted 7 lines

Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training
https://bootlin.com

--
Ivan Maidanski

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot