Skip to contentSkip to conversation

ethernet: renesas: Use div64_ul instead of do_div

PATCH Superseded Yang Li 2 participants 2 messages Nov 18, 2021

Subsystems (3)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH v2 1/1 ethernet: renesas: Use div64_ul instead of do_div

do_div() does a 64-by-32 division. Here the divisor is an unsigned long which on some platforms is 64 bit wide. So use div64_ul instead of do_div to avoid a possible truncation.

Eliminate the following coccicheck warning:
./drivers/net/ethernet/renesas/ravb_main.c:2492:1-7: WARNING:
do_div() does a 64-by-32 division, please consider using div64_ul instead.

---

change in v2:
--Fixed warning message

 drivers/net/ethernet/renesas/ravb_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/renesas/ravb_main.c +1 -1
index b4c597f..2b89710 100644
@@ -2489,7 +2489,7 @@ static int ravb_set_gti(struct net_device *ndev)
 		return -EINVAL;
 
 	inc = 1000000000ULL << 20;
-	do_div(inc, rate);
+	inc = div64_ul(inc, rate);
 
 	if (inc < GTI_TIV_MIN || inc > GTI_TIV_MAX) {
 		dev_err(dev, "gti.tiv increment 0x%llx is outside the range 0x%x - 0x%x\n",
Signature · 1 line
1.8.3.1
Reviewed-by on v2 1/1
#1 lore raw

Hi Yang,

Quoted 10 lines · Yang Li

do_div() does a 64-by-32 division. Here the divisor is an unsigned long which on some platforms is 64 bit wide. So use div64_ul instead of do_div to avoid a possible truncation.

Eliminate the following coccicheck warning:
./drivers/net/ethernet/renesas/ravb_main.c:2492:1-7: WARNING:
do_div() does a 64-by-32 division, please consider using div64_ul instead.

Thanks for your patch!

drivers/net/ethernet/renesas/ravb_main.c static int ravb_set_gti(struct net_device *ndev) · line 2495

Quoted 11 lines
drivers/net/ethernet/renesas/ravb_main.c +1 -1
@@ -2489,7 +2489,7 @@ static int ravb_set_gti(struct net_device *ndev)
                return -EINVAL;
 
        inc = 1000000000ULL << 20;
-       do_div(inc, rate);
+       inc = div64_ul(inc, rate);
 
        if (inc < GTI_TIV_MIN || inc > GTI_TIV_MAX) {
                dev_err(dev, "gti.tiv increment 0x%llx is outside the range 0x%x - 0x%x\n",

Please also replace

    #include <asm/div64.h>

by

#include <linux/math64.h>

With that added:

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds