ath11k: Fix mon status ring rx tlv processing
PATCH 1/1 ath11k: Fix mon status ring rx tlv processing
In HE monitor capture, HAL_TLV_STATUS_PPDU_DONE is received on processing multiple skb. Do not clear the ppdu_info till the HAL_TLV_STATUS_PPDU_DONE is received.
This fixes below warning and packet drops in monitor mode.
"Rate marked as an HE rate but data is invalid: MCS: 6, NSS: 0"
WARNING: at
PC is at ieee80211_rx_napi+0x624/0x840 [mac80211]
Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-01693-QCAHKSWPL_SILICONZ-1
--- drivers/net/wireless/ath/ath11k/dp_rx.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/net/wireless/ath/ath11k/dp_rx.c +7 -7
@@ -3064,10 +3064,10 @@ int ath11k_dp_rx_process_mon_status(struct ath11k_base *ab, int mac_id,if (!num_buffs_reaped) goto exit; -while ((skb =__skb_dequeue (&skb_list))) { -memset (&ppdu_info,0 ,sizeof (ppdu_info)); - ppdu_info.peer_id =HAL_INVALID_PEERID ; +memset (&ppdu_info,0 ,sizeof (ppdu_info)); + ppdu_info.peer_id =HAL_INVALID_PEERID ; +while ((skb =__skb_dequeue (&skb_list))) {if (ath11k_debugfs_is_pktlog_lite_mode_enabled (ar)) { log_type =ATH11K_PKTLOG_TYPE_LITE_RX ; rx_buf_sz =DP_RX_BUFFER_SIZE_LITE ;
@@ -3095,10 +3095,7 @@ int ath11k_dp_rx_process_mon_status(struct ath11k_base *ab, int mac_id,ath11k_dbg (ab,ATH11K_DBG_DATA ,"failed to find the peer with peer_id %d\n" , ppdu_info.peer_id); -spin_unlock_bh (&ab->base_lock); -rcu_read_unlock (); -dev_kfree_skb_any (skb); -continue ; + goto next_skb; } arsta = (struct ath11k_sta *)peer->sta->drv_priv;
@@ -3107,10 +3104,13 @@ int ath11k_dp_rx_process_mon_status(struct ath11k_base *ab, int mac_id,if (ath11k_debugfs_is_pktlog_peer_valid (ar, peer->addr))trace_ath11k_htt_rxdesc (ar, skb->data, log_type, rx_buf_sz); +next_skb:spin_unlock_bh (&ab->base_lock);rcu_read_unlock ();dev_kfree_skb_any (skb); +memset (&ppdu_info,0 ,sizeof (ppdu_info)); + ppdu_info.peer_id =HAL_INVALID_PEERID ; } exit:return num_buffs_reaped;
Signature · 1 line
2.7.4
Quoted 9 lines · Anilkumar Kolli
In HE monitor capture,
HAL_TLV_STATUS_PPDU_DONEis received on processing multiple skb. Do not clear theppdu_infotill theHAL_TLV_STATUS_PPDU_DONEis received.This fixes below warning and packet drops in monitor mode.
"Rate marked as an HE rate but data is invalid: MCS: 6, NSS: 0"
WARNING: at
PC is atieee80211_rx_napi+0x624/0x840[mac80211]
Quoted 4 lines
Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-01693-QCAHKSWPL_SILICONZ-1
Signed-off-by Anilkumar Kolli <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
09f16f7390f3 ath11k: Fix mon status ring rx tlv processing
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches