Skip to contentSkip to conversation

FAILED: patch "[PATCH] ice: Delete always true check of PF pointer" failed to apply to 4.19-stable tree

PATCH [email protected] 1 participant 1 message Nov 24, 2021

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.19-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 2ff04286a9569675948f39cec2c6ad47c3584633 Mon Sep 17 00:00:00 2001
From: Leon Romanovsky <[email protected]>
Date: Thu, 23 Sep 2021 21:12:52 +0300
Subject: [PATCH] ice: Delete always true check of PF pointer

PF pointer is always valid when PCI core calls its .shutdown() and .remove() callbacks. There is no need to check it again.

Fixes 837f08fdecbe ("ice: Add basic driver framework for Intel(R) E800 Series")
drivers/net/ethernet/intel/ice/ice_main.c +0 -3
index 34e64533026a..aacc0b345bbe 100644
@@ -4593,9 +4593,6 @@ static void ice_remove(struct pci_dev *pdev)
 	struct ice_pf *pf = pci_get_drvdata(pdev);
 	int i;
 
-	if (!pf)
-		return;
-
 	for (i = 0; i < ICE_MAX_RESET_WAIT; i++) {
 		if (!ice_is_reset_in_progress(pf->state))
 			break;