Skip to contentSkip to conversation

Bluetooth: hci_qca: Optimizations in init sequence for WCN6750.

PATCH In review pharish 2 participants 5 messages Nov 25, 2021 – Dec 7, 2021

Subsystems (3)
lore
Share & tools
lore

pharish

author
#0 lore raw

PATCH 1/1 Bluetooth: hci_qca: Optimizations in init sequence for WCN6750.

This change adds optimazation in init sequence for WCN6750.

---
 drivers/bluetooth/hci_qca.c | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)
drivers/bluetooth/hci_qca.c +11 -7
index 6f44b26..4dedaaa 100644
@@ -1603,15 +1603,19 @@ static int qca_regulator_init(struct hci_uart *hu)
 	 */
 	qcadev = serdev_device_get_drvdata(hu->serdev);
 	if (!qcadev->bt_power->vregs_on) {
-		serdev_device_close(hu->serdev);
+		if (qca_is_wcn399x(soc_type))
+			serdev_device_close(hu->serdev);
+
 		ret = qca_regulator_enable(qcadev);
 		if (ret)
 			return ret;
 
-		ret = serdev_device_open(hu->serdev);
-		if (ret) {
-			bt_dev_err(hu->hdev, "failed to open port");
-			return ret;
+		if (qca_is_wcn399x(soc_type)) {
+			ret = serdev_device_open(hu->serdev);
+			if (ret) {
+				bt_dev_err(hu->hdev, "failed to open port");
+				return ret;
+			}
 		}
 	}
 
@@ -1635,9 +1639,8 @@ static int qca_regulator_init(struct hci_uart *hu)
 		}
 	}
 
-	qca_set_speed(hu, QCA_INIT_SPEED);
-
 	if (qca_is_wcn399x(soc_type)) {
+		qca_set_speed(hu, QCA_INIT_SPEED);
 		ret = qca_send_power_pulse(hu, true);
 		if (ret)
 			return ret;
@@ -1648,6 +1651,7 @@ static int qca_regulator_init(struct hci_uart *hu)
 	 * Without this, we will have RTS and CTS synchronization
 	 * issues.
 	 */
+
 	serdev_device_close(hu->serdev);
 	ret = serdev_device_open(hu->serdev);
 	if (ret) {
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
author
#1 lore raw

PATCH 1/1 Bluetooth: hci_qca: Stop IBS timer during BT OFF

This change stops IBS timers during BT OFF.

---
 drivers/bluetooth/hci_qca.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/bluetooth/hci_qca.c +3 -0
index dd768a8..6f44b26 100644
@@ -1928,6 +1928,9 @@ static int qca_power_off(struct hci_dev *hdev)
 	hu->hdev->hw_error = NULL;
 	hu->hdev->cmd_timeout = NULL;
 
+	mod_timer(&qca->tx_idle_timer, 0);
+	mod_timer(&qca->wake_retrans_timer, 0);
+
 	/* Stop sending shutdown command if soc crashes. */
 	if (soc_type != QCA_ROME
 		&& qca->memdump_state == QCA_MEMDUMP_IDLE) {
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
maintainer
#2 lore raw

Re: [PATCH v1] Bluetooth: hci_qca: Stop IBS timer during BT OFF

Hi,

Quoted 3 lines

This change stops IBS timers during BT OFF.

clear name please.

Quoted 9 lines

---
drivers/bluetooth/hci_qca.c | 3 +++

1 file changed, 3 insertions(+)
drivers/bluetooth/hci_qca.c +0 -0
index dd768a8..6f44b26 100644

drivers/bluetooth/hci_qca.c static int qca_power_off(struct hci_dev *hdev) · line 1933

Quoted 6 lines
drivers/bluetooth/hci_qca.c +3 -0
@@ -1928,6 +1928,9 @@ static int qca_power_off(struct hci_dev *hdev)
 	hu->hdev->hw_error = NULL;
 	hu->hdev->cmd_timeout = NULL;
 
+	mod_timer(&qca->tx_idle_timer, 0);
+	mod_timer(&qca->wake_retrans_timer, 0);
+

And I would really prefer if this gets changed to use a workqueue instead of a timer.

Regards

Marcel

#3 lore raw

Re: [PATCH v1] Bluetooth: hci_qca: Stop IBS timer during BT OFF

Quoted 7 lines · Marcel Holtmann

Hi,

Quoted 3 lines

This change stops IBS timers during BT OFF.

clear name please.

[Harish]: will update

Quoted 13 lines
Quoted 13 lines

---
drivers/bluetooth/hci_qca.c | 3 +++

1 file changed, 3 insertions(+)
drivers/bluetooth/hci_qca.c +0 -0
index dd768a8..6f44b26 100644
@@ -1928,6 +1928,9 @@ static int qca_power_off(struct hci_dev *hdev)
 	hu->hdev->hw_error = NULL;
 	hu->hdev->cmd_timeout = NULL;
 
Quoted 6 lines

drivers/bluetooth/hci_qca.c static int qca_power_off(struct hci_dev *hdev) · line 1933

Quoted 3 lines
drivers/bluetooth/hci_qca.c +3 -0
+	mod_timer(&qca->tx_idle_timer, 0);
+	mod_timer(&qca->wake_retrans_timer, 0);
+

And I would really prefer if this gets changed to use a workqueue instead of a timer.

[Harish]: The full implementation of IBS is based on timers to that reason I have switched to timers.

Quoted 4 lines

Regards

Marcel

maintainer
#4 lore raw
In reply to pharish

Hi,

Quoted 1 line

This change adds optimazation in init sequence for WCN6750.

you need to explain what you are doing.

Quoted 22 lines

---
drivers/bluetooth/hci_qca.c | 18 +++++++++++-------

1 file changed, 11 insertions(+), 7 deletions(-)
drivers/bluetooth/hci_qca.c +3 -1
index 6f44b26..4dedaaa 100644
@@ -1603,15 +1603,19 @@ static int qca_regulator_init(struct hci_uart *hu)
 	 */
 	qcadev = serdev_device_get_drvdata(hu->serdev);
 	if (!qcadev->bt_power->vregs_on) {
-		serdev_device_close(hu->serdev);
+		if (qca_is_wcn399x(soc_type))
+			serdev_device_close(hu->serdev);
+
 		ret = qca_regulator_enable(qcadev);
 		if (ret)
 			return ret;
 

drivers/bluetooth/hci_qca.c static int qca_regulator_init(struct hci_uart *hu) · line 1618

Quoted 10 lines
drivers/bluetooth/hci_qca.c +6 -4
-		ret = serdev_device_open(hu->serdev);
-		if (ret) {
-			bt_dev_err(hu->hdev, "failed to open port");
-			return ret;
+		if (qca_is_wcn399x(soc_type)) {
+			ret = serdev_device_open(hu->serdev);
+			if (ret) {
+				bt_dev_err(hu->hdev, "failed to open port");
+				return ret;
+			}

I am really not doing this. You need to stop doing this SoC X or SoC Y crap. I said this before and I am saying this again, start from scratch and write a clean serdev only driver. Adding things to hci_qca is just a hack.

Quoted 15 lines
drivers/bluetooth/hci_qca.c +1 -2
 		}
 	}
 
@@ -1635,9 +1639,8 @@ static int qca_regulator_init(struct hci_uart *hu)
 		}
 	}
 
-	qca_set_speed(hu, QCA_INIT_SPEED);
-
 	if (qca_is_wcn399x(soc_type)) {
+		qca_set_speed(hu, QCA_INIT_SPEED);
 		ret = qca_send_power_pulse(hu, true);
 		if (ret)
 			return ret;

drivers/bluetooth/hci_qca.c static int qca_regulator_init(struct hci_uart *hu) · line 1654

Quoted 4 lines
drivers/bluetooth/hci_qca.c +1 -0
@@ -1648,6 +1651,7 @@ static int qca_regulator_init(struct hci_uart *hu)
 	 * Without this, we will have RTS and CTS synchronization
 	 * issues.
 	 */
+

Unrelated change.

drivers/bluetooth/hci_qca.c static int qca_regulator_init(struct hci_uart *hu) · line 1657

Quoted 3 lines
drivers/bluetooth/hci_qca.c +0 -0
 	serdev_device_close(hu->serdev);
 	ret = serdev_device_open(hu->serdev);
 	if (ret) {

Regards

Marcel