Skip to contentSkip to conversation

patch "serial: liteuart: Fix NULL pointer dereference in ->remove()" added to tty-linus

PATCH [email protected] 1 participant 1 message Nov 25, 2021

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

    serial: liteuart: Fix NULL pointer dereference in ->remove()

to my tty git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
in the tty-linus branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.

If you have any questions about this process, please let me know.

From 0f55f89d98c8b3e12b4f55f71c127a173e29557c Mon Sep 17 00:00:00 2001
From: Ilia Sergachev <[email protected]>
Date: Mon, 15 Nov 2021 22:49:44 +0100
Subject: serial: liteuart: Fix NULL pointer dereference in ->remove()

drvdata has to be set in _probe() - otherwise platform_get_drvdata() causes null pointer dereference BUG in _remove().

---
 drivers/tty/serial/liteuart.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/tty/serial/liteuart.c +2 -0
index dbc0559a9157..f075f4ff5fcf 100644
@@ -285,6 +285,8 @@ static int liteuart_probe(struct platform_device *pdev)
 	port->line = dev_id;
 	spin_lock_init(&port->lock);
 
+	platform_set_drvdata(pdev, port);
+
 	return uart_add_one_port(&liteuart_driver, &uart->port);
 }
 
Signature · 1 line
2.34.0