FAILED: patch "[PATCH] KVM: fix avic_set_running for preemptable kernels" failed to apply to 4.14-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 4.14-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 7cfc5c653b07782e7059527df8dc1e3143a7591e Mon Sep 17 00:00:00 2001
From: Paolo Bonzini <[email protected]>
Date: Tue, 30 Nov 2021 03:46:07 -0500
Subject: [PATCH] KVM: fix avic_set_running for preemptable kernels
avic_set_running() passes the current CPU to avic_vcpu_load(), albeit via vcpu->cpu rather than smp_processor_id(). If the thread is migrated while avic_set_running runs, the call to avic_vcpu_load() can use a stale value for the processor id. Avoid this by blocking preemption over the entire execution of avic_set_running().
arch/x86/kvm/svm/avic.c +9 -7
@@ -989,16 +989,18 @@ void avic_vcpu_put(struct kvm_vcpu *vcpu)static void avic_set_running (struct kvm_vcpu *vcpu,bool is_run) {struct vcpu_svm *svm =to_svm (vcpu); +int cpu =get_cpu (); +WARN_ON (cpu != vcpu->cpu); svm->avic_is_running = is_run; -if (!kvm_vcpu_apicv_active (vcpu)) -return ; - -if (is_run) -avic_vcpu_load (vcpu, vcpu->cpu); -else -avic_vcpu_put (vcpu); +if (kvm_vcpu_apicv_active (vcpu)) { +if (is_run) +avic_vcpu_load (vcpu, cpu); +else +avic_vcpu_put (vcpu); + } +put_cpu (); }void svm_vcpu_blocking (struct kvm_vcpu *vcpu)