Skip to contentSkip to conversation

maintainers: improve coverage of arch-specific files

PATCH Superseded Thomas Monjalon 3 participants 6 messages Oct 6, 2020 – Oct 24, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 maintainers: improve coverage of arch-specific files

The sub-directories of config/ are maintained by
different architecture maintainers.

Some wildcards are used to describe the lib and drivers files which are specific to some architectures.

The EAL Arm files have split responsibilities depending on 32/64 suffix, and the common files are shared between Armv7 and Armv8 sections.

---
 MAINTAINERS | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)
MAINTAINERS +11 -12
index 75a17d51c0..349fc9c38a 100644
@@ -256,32 +256,31 @@ F: app/test/test_rand_perf.c
 ARM v7
 M: Jan Viktorin <[email protected]>
 M: Ruifeng Wang <[email protected]>
+F: config/arm/
 F: lib/librte_eal/arm/
+X: lib/librte_eal/arm/include/*_64.h
 
 ARM v8
 M: Jerin Jacob <[email protected]>
 M: Ruifeng Wang <[email protected]>
-F: lib/librte_eal/arm/include/*_64.h
-F: lib/librte_net/net_crc_neon.h
-F: lib/librte_acl/acl_run_neon.*
-F: lib/librte_bpf/bpf_jit_arm64.c
-F: lib/librte_lpm/rte_lpm_neon.h
-F: lib/librte_hash/rte*_arm64.h
-F: lib/librte_efd/rte*_arm64.h
-F: lib/librte_table/rte*_arm64.h
-F: drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
-F: drivers/net/i40e/i40e_rxtx_vec_neon.c
-F: drivers/net/virtio/virtio_rxtx_simple_neon.c
+F: config/arm/
+F: lib/librte_eal/arm/
+X: lib/librte_eal/arm/include/*_32.h
+F: lib/*/*_neon.*
+F: lib/*/*_arm64.*
+F: drivers/*/*/*_neon.*
 
 IBM POWER (alpha)
 M: David Christensen <[email protected]>
+F: config/ppc/
 F: lib/librte_eal/ppc/
-F: drivers/net/i40e/i40e_rxtx_vec_altivec.c
+F: drivers/*/*/*_altivec.*
 F: examples/l3fwd/*altivec.h
 
 Intel x86
 M: Bruce Richardson <[email protected]>
 M: Konstantin Ananyev <[email protected]>
+F: config/x86/
 F: lib/librte_eal/x86/
 
 Linux EAL (with overlaps)
Signature · 1 line
2.28.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 53 lines · Thomas Monjalon

The sub-directories of config/ are maintained by
different architecture maintainers.

Some wildcards are used to describe the lib and drivers files which are specific to some architectures.

The EAL Arm files have split responsibilities depending on 32/64 suffix, and the common files are shared between Armv7 and Armv8 sections.

---
  MAINTAINERS | 23 +++++++++++------------
  1 file changed, 11 insertions(+), 12 deletions(-)
MAINTAINERS +9 -12
index 75a17d51c0..349fc9c38a 100644
@@ -256,32 +256,31 @@ F: app/test/test_rand_perf.c
  ARM v7
  M: Jan Viktorin <[email protected]>
  M: Ruifeng Wang <[email protected]>
+F: config/arm/
  F: lib/librte_eal/arm/
+X: lib/librte_eal/arm/include/*_64.h
 
  ARM v8
  M: Jerin Jacob <[email protected]>
  M: Ruifeng Wang <[email protected]>
-F: lib/librte_eal/arm/include/*_64.h
-F: lib/librte_net/net_crc_neon.h
-F: lib/librte_acl/acl_run_neon.*
-F: lib/librte_bpf/bpf_jit_arm64.c
-F: lib/librte_lpm/rte_lpm_neon.h
-F: lib/librte_hash/rte*_arm64.h
-F: lib/librte_efd/rte*_arm64.h
-F: lib/librte_table/rte*_arm64.h
-F: drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
-F: drivers/net/i40e/i40e_rxtx_vec_neon.c
-F: drivers/net/virtio/virtio_rxtx_simple_neon.c
+F: config/arm/
+F: lib/librte_eal/arm/
+X: lib/librte_eal/arm/include/*_32.h
+F: lib/*/*_neon.*
+F: lib/*/*_arm64.*
+F: drivers/*/*/*_neon.*
 
  IBM POWER (alpha)
  M: David Christensen <[email protected]>
+F: config/ppc/
  F: lib/librte_eal/ppc/
-F: drivers/net/i40e/i40e_rxtx_vec_altivec.c

MAINTAINERS F: app/test/test_rand_perf.c · line 286

Quoted 10 lines
MAINTAINERS +2 -0
+F: drivers/*/*/*_altivec.*
  F: examples/l3fwd/*altivec.h
 
  Intel x86
  M: Bruce Richardson <[email protected]>
  M: Konstantin Ananyev <[email protected]>
+F: config/x86/
  F: lib/librte_eal/x86/
 
  Linux EAL (with overlaps)
#2 lore raw
In reply to Thomas Monjalon
Quoted 6 lines · Thomas Monjalon

The sub-directories of config/ are maintained by
different architecture maintainers.

Some wildcards are used to describe the lib and drivers files which are specific to some architectures.

I noticed "some" misses, see below.

Quoted 31 lines

The EAL Arm files have split responsibilities depending on 32/64 suffix, and the common files are shared between Armv7 and Armv8 sections.

---
 MAINTAINERS | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)
MAINTAINERS +2 -7
index 75a17d51c0..349fc9c38a 100644
@@ -256,32 +256,31 @@ F: app/test/test_rand_perf.c
 ARM v7
 M: Jan Viktorin <[email protected]>
 M: Ruifeng Wang <[email protected]>
+F: config/arm/
 F: lib/librte_eal/arm/
+X: lib/librte_eal/arm/include/*_64.h
 
 ARM v8
 M: Jerin Jacob <[email protected]>
 M: Ruifeng Wang <[email protected]>
-F: lib/librte_eal/arm/include/*_64.h
-F: lib/librte_net/net_crc_neon.h
-F: lib/librte_acl/acl_run_neon.*
-F: lib/librte_bpf/bpf_jit_arm64.c
-F: lib/librte_lpm/rte_lpm_neon.h
-F: lib/librte_hash/rte*_arm64.h
-F: lib/librte_efd/rte*_arm64.h

MAINTAINERS F: app/test/test_rand_perf.c · line 271

Quoted 10 lines
MAINTAINERS +6 -4
-F: lib/librte_table/rte*_arm64.h
-F: drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
-F: drivers/net/i40e/i40e_rxtx_vec_neon.c
-F: drivers/net/virtio/virtio_rxtx_simple_neon.c
+F: config/arm/
+F: lib/librte_eal/arm/
+X: lib/librte_eal/arm/include/*_32.h
+F: lib/*/*_neon.*
+F: lib/*/*_arm64.*
+F: drivers/*/*/*_neon.*

app and examples directory are not caught in this:

./lib/librte_net/net_crc_neon.h
./lib/librte_acl/acl_run_neon.h
./lib/librte_acl/acl_run_neon.c
./lib/librte_lpm/rte_lpm_neon.h
./lib/librte_node/ip4_lookup_neon.h
./examples/l3fwd/l3fwd_lpm_neon.h
./examples/l3fwd/l3fwd_em_hlm_neon.h
./examples/l3fwd/l3fwd_neon.h
./app/test-pmd/macswap_neon.h
./drivers/net/hns3/hns3_rxtx_vec_neon.h
./drivers/net/bnxt/bnxt_rxtx_vec_neon.c
./drivers/net/mlx5/mlx5_rxtx_vec_neon.h
./drivers/net/virtio/virtio_rxtx_simple_neon.c
./drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
./drivers/net/i40e/i40e_rxtx_vec_neon.c

Can we use a wildcard at dpdk root?
*/*/*_neon.*

The drivers/*/*/*_neon.* entry would still be needed though.

MAINTAINERS F: app/test/test_rand_perf.c · line 278

Quoted 8 lines
MAINTAINERS +2 -1
 IBM POWER (alpha)
 M: David Christensen <[email protected]>
+F: config/ppc/
 F: lib/librte_eal/ppc/
-F: drivers/net/i40e/i40e_rxtx_vec_altivec.c
+F: drivers/*/*/*_altivec.*
 F: examples/l3fwd/*altivec.h

Idem neon, lib files missing.

./lib/librte_eal/ppc/include/rte_altivec.h
./lib/librte_acl/acl_run_altivec.c
./lib/librte_acl/acl_run_altivec.h
./lib/librte_lpm/rte_lpm_altivec.h
./examples/l3fwd/l3fwd_altivec.h
./examples/l3fwd/l3fwd_lpm_altivec.h
./drivers/net/mlx5/mlx5_rxtx_vec_altivec.h
./drivers/net/virtio/virtio_rxtx_simple_altivec.c
./drivers/net/i40e/i40e_rxtx_vec_altivec.c

MAINTAINERS F: app/test/test_rand_perf.c · line 284

Quoted 6 lines
MAINTAINERS +1 -0
 Intel x86
 M: Bruce Richardson <[email protected]>
 M: Konstantin Ananyev <[email protected]>
+F: config/x86/
 F: lib/librte_eal/x86/

Nothing for avx/sse ?

Quoted 5 lines
MAINTAINERS +0 -1
 Linux EAL (with overlaps)
--

2.28.0

Signature · 1 line
David Marchand
#3 lore raw

07/10/2020 09:44, David Marchand:

Quoted 99 lines · Thomas Monjalon
Quoted 6 lines

The sub-directories of config/ are maintained by
different architecture maintainers.

Some wildcards are used to describe the lib and drivers files which are specific to some architectures.

I noticed "some" misses, see below.

Quoted 31 lines

The EAL Arm files have split responsibilities depending on 32/64 suffix, and the common files are shared between Armv7 and Armv8 sections.

---
 MAINTAINERS | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)
MAINTAINERS +2 -7
index 75a17d51c0..349fc9c38a 100644
@@ -256,32 +256,31 @@ F: app/test/test_rand_perf.c
 ARM v7
 M: Jan Viktorin <[email protected]>
 M: Ruifeng Wang <[email protected]>
+F: config/arm/
 F: lib/librte_eal/arm/
+X: lib/librte_eal/arm/include/*_64.h
 
 ARM v8
 M: Jerin Jacob <[email protected]>
 M: Ruifeng Wang <[email protected]>
-F: lib/librte_eal/arm/include/*_64.h
-F: lib/librte_net/net_crc_neon.h
-F: lib/librte_acl/acl_run_neon.*
-F: lib/librte_bpf/bpf_jit_arm64.c
-F: lib/librte_lpm/rte_lpm_neon.h
-F: lib/librte_hash/rte*_arm64.h
-F: lib/librte_efd/rte*_arm64.h

MAINTAINERS F: app/test/test_rand_perf.c · line 271

Quoted 10 lines
MAINTAINERS +6 -4
-F: lib/librte_table/rte*_arm64.h
-F: drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
-F: drivers/net/i40e/i40e_rxtx_vec_neon.c
-F: drivers/net/virtio/virtio_rxtx_simple_neon.c
+F: config/arm/
+F: lib/librte_eal/arm/
+X: lib/librte_eal/arm/include/*_32.h
+F: lib/*/*_neon.*
+F: lib/*/*_arm64.*
+F: drivers/*/*/*_neon.*

app and examples directory are not caught in this:

./lib/librte_net/net_crc_neon.h
./lib/librte_acl/acl_run_neon.h
./lib/librte_acl/acl_run_neon.c
./lib/librte_lpm/rte_lpm_neon.h
./lib/librte_node/ip4_lookup_neon.h
./examples/l3fwd/l3fwd_lpm_neon.h
./examples/l3fwd/l3fwd_em_hlm_neon.h
./examples/l3fwd/l3fwd_neon.h
./app/test-pmd/macswap_neon.h
./drivers/net/hns3/hns3_rxtx_vec_neon.h
./drivers/net/bnxt/bnxt_rxtx_vec_neon.c
./drivers/net/mlx5/mlx5_rxtx_vec_neon.h
./drivers/net/virtio/virtio_rxtx_simple_neon.c
./drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
./drivers/net/i40e/i40e_rxtx_vec_neon.c

Can we use a wildcard at dpdk root?
*/*/*_neon.*

The drivers/*/*/*_neon.* entry would still be needed though.

MAINTAINERS F: app/test/test_rand_perf.c · line 278

Quoted 8 lines
MAINTAINERS +2 -1
 IBM POWER (alpha)
 M: David Christensen <[email protected]>
+F: config/ppc/
 F: lib/librte_eal/ppc/
-F: drivers/net/i40e/i40e_rxtx_vec_altivec.c
+F: drivers/*/*/*_altivec.*
 F: examples/l3fwd/*altivec.h

Idem neon, lib files missing.

./lib/librte_eal/ppc/include/rte_altivec.h
./lib/librte_acl/acl_run_altivec.c
./lib/librte_acl/acl_run_altivec.h
./lib/librte_lpm/rte_lpm_altivec.h
./examples/l3fwd/l3fwd_altivec.h
./examples/l3fwd/l3fwd_lpm_altivec.h
./drivers/net/mlx5/mlx5_rxtx_vec_altivec.h
./drivers/net/virtio/virtio_rxtx_simple_altivec.c
./drivers/net/i40e/i40e_rxtx_vec_altivec.c

Quoted 1 line
Quoted 7 lines
Quoted 5 lines

Intel x86
M: Bruce Richardson <[email protected]>
M: Konstantin Ananyev <[email protected]>
+F: config/x86/
F: lib/librte_eal/x86/

Nothing for avx/sse ?

I was not extending the scope too much.
I think you're right, we can go further in apps and x86-specific files.

#4 lore raw

PATCH v2 1/1 maintainers: improve coverage of arch-specific files

In reply to Thomas Monjalon

The sub-directories of config/ are maintained by
different architecture maintainers.

Some wildcards are used to describe the lib, drivers and app files which are specific to some architectures.

The EAL Arm files have split responsibilities depending on 32/64 suffix, and the common files are shared between Armv7 and Armv8 sections.

---
v2: add more files (doc, apps and SSE/AVX)

---
 MAINTAINERS | 41 +++++++++++++++++++++++++++--------------
 1 file changed, 27 insertions(+), 14 deletions(-)
MAINTAINERS +27 -14
index a3d1927476..41983c1490 100644
@@ -98,7 +98,6 @@ F: Makefile
 F: meson.build
 F: meson_options.txt
 F: config/
-F: buildtools/binutils-avx512-check.sh
 F: buildtools/call-sphinx-build.py
 F: buildtools/gen-pmdinfo-cfile.sh
 F: buildtools/list-dir-globs.py
@@ -256,33 +255,47 @@ F: app/test/test_rand_perf.c
 ARM v7
 M: Jan Viktorin <[email protected]>
 M: Ruifeng Wang <[email protected]>
+F: config/arm/
 F: lib/librte_eal/arm/
+X: lib/librte_eal/arm/include/*_64.h
 
 ARM v8
 M: Jerin Jacob <[email protected]>
 M: Ruifeng Wang <[email protected]>
-F: lib/librte_eal/arm/include/*_64.h
-F: lib/librte_net/net_crc_neon.c
-F: lib/librte_acl/acl_run_neon.*
-F: lib/librte_bpf/bpf_jit_arm64.c
-F: lib/librte_lpm/rte_lpm_neon.h
-F: lib/librte_hash/rte*_arm64.h
-F: lib/librte_efd/rte*_arm64.h
-F: lib/librte_table/rte*_arm64.h
-F: drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
-F: drivers/net/i40e/i40e_rxtx_vec_neon.c
-F: drivers/net/virtio/virtio_rxtx_simple_neon.c
+F: config/arm/
+F: doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
+F: lib/librte_eal/arm/
+X: lib/librte_eal/arm/include/*_32.h
+F: lib/*/*_arm64.*
+F: lib/*/*_neon.*
+F: drivers/*/*/*_neon.*
+F: app/*/*_neon.*
+F: examples/*/*_neon.*
 
 IBM POWER (alpha)
 M: David Christensen <[email protected]>
+F: config/ppc/
 F: lib/librte_eal/ppc/
-F: drivers/net/i40e/i40e_rxtx_vec_altivec.c
-F: examples/l3fwd/*altivec.h
+F: drivers/*/*/*_altivec.*
+F: app/*/*_altivec.*
+F: examples/*/*_altivec.*
 
 Intel x86
 M: Bruce Richardson <[email protected]>
 M: Konstantin Ananyev <[email protected]>
+F: config/x86/
+F: doc/guides/linux_gsg/nic_perf_intel_platform.rst
+F: buildtools/binutils-avx512-check.sh
+F: doc/guides/howto/avx512.rst
 F: lib/librte_eal/x86/
+F: lib/*/*_sse*
+F: lib/*/*_avx*
+F: drivers/*/*/*_sse*
+F: drivers/*/*/*_avx*
+F: app/*/*_sse*
+F: app/*/*_avx*
+F: examples/*/*_sse*
+F: examples/*/*_avx*
 
 Linux EAL (with overlaps)
 F: lib/librte_eal/linux/
Signature · 1 line
2.28.0
Acked-by on v2 1/1 Applied
#5 lore raw
Quoted 4 lines · Thomas Monjalon

The sub-directories of config/ are maintained by
different architecture maintainers.

Quoted 8 lines

Some wildcards are used to describe the lib, drivers and app files which are specific to some architectures.

The EAL Arm files have split responsibilities depending on 32/64 suffix, and the common files are shared between Armv7 and Armv8 sections.

Squashed:

@@ -276,6 +276,7 @@ IBM POWER (alpha)
M: David Christensen <[email protected]>
F: config/ppc/
F: lib/librte_eal/ppc/
+F: lib/*/*_altivec*
F: drivers/*/*/*_altivec.*
F: app/*/*_altivec.*
F: examples/*/*_altivec.*

Applied.

Signature · 1 line
David Marchand