Skip to contentSkip to conversation

TCC cooling on Meteorlake

DISCUSSION Gwara, Mateusz 1 participant 1 message Feb 24, 2025 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi,

Sorry, my first mail was sent as HTML due to a corporate policy preset. So here's my initial mail:

Hello dear maintainers!

I was comparing the behavior of the Intel TCC cooling driver on a kernel we develop and also on regular Ubuntu kernel releases(based on Linux kernel up to 6.13). On a Raptorlake CPU you’ll see the TCC node with e.g.:

/sys/class/thermal/cooling_device8/type
/sys/class/thermal/cooling_device8/cur_state

Endpoints

This allows reading/setting the offsets as expected.

This was made possible in
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers?h=next-20250212&id=be6bfb29c55e48567983e24aba7b6bf9a66a45ab/https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/thermal?h=next-20250212&id=be6bfb29c55e48567983e24aba7b6bf9a66a45ab/https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/thermal/intel?h=next-20250212&id=be6bfb29c55e48567983e24aba7b6bf9a66a45ab/https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/thermal/intel/intel_tcc_cooling.c?h=next-20250212&id=be6bfb29c55e48567983e24aba7b6bf9a66a45ab

with a patch that added

Quoted 5 lines

+       X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE,           &temp_tigerlake), +       X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L,         &temp_tigerlake), +       X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE,          &temp_tigerlake), +       X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_P,        &temp_tigerlake), +       X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_S,        &temp_tigerlake),

Among other changes, where intel_tcc_get_offset_mask would get the correct Tjunction offset for each CPU.

I was trying to add a similar entry corresponding to the Meteorlake Model names but this did not have the same effect and there was no TCC node present like on a Raptorlake device.
As I see in
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/thermal/intel/intel_tcc_cooling.c?h=next-20250219
the last CPU added here still is the Raptorlake model.

I checked the repositories where Intel maintains their CPU patches but there was also no mention of Meteorlake (and later models)regarding TCC support. As there have been several ARROW&LUNAR-lake patches handling different issues regarding clocking the different core variants.

I’d like to know if there is something I’m missing(maybe NO TCC support since Meteorlake?) or if there is TCC support planned? I’d be willing to help test anything regarding this issue.

Sorry for the lengthy mail and thank you for you work on the Linux Kernel so far :)

Mateusz

Signature · 18 lines
Mateusz Gwara
Senior Software Developer
Department Network & Client Security
Division Public Authorities
secunet Security Networks AG

Tel.: +49 201 54 54-2934
E-Mail: mailto:[email protected]
Alt-Moabit 96, 10559 Berlin
http://www.secunet.com
______________________________________________________________________

secunet Security Networks AG
Sitz: Kurfürstenstraße 58, 45138 Essen, Deutschland
Amtsgericht Essen HRB 13615
Vorstand: Axel Deininger (Vors.), Torsten Henn, Dr. Kai Martius, Jessica Nospers
Aufsichtsratsvorsitzender: Dr. Ralf Wintergerst
______________________________________________________________________