Skip to contentSkip to conversation

i40e: Remove unused RX realloc stat

PATCH Superseded Joe Damato 2 participants 2 messages Dec 20, 2021 – Jan 4, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Joe Damato

author
#0 lore raw

PATCH 1/1 i40e: Remove unused RX realloc stat

rx_stats.realloc_count was not being incremented after 1a557afc4dd5, so remove it.

The debugfs string was left but hardcoded to 0. This is intended to prevent breaking any existing code / scripts that are parsing debugfs for i40e.

Fixes 1a557afc4dd5 ("i40e: Refactor receive routine")
---
 drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 3 +--
 drivers/net/ethernet/intel/i40e/i40e_txrx.h    | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_debugfs.c +1 -2
index 1e57cc8..90fff05 100644
@@ -275,9 +275,8 @@ static void i40e_dbg_dump_vsi_seid(struct i40e_pf *pf, int seid)
 			 rx_ring->rx_stats.alloc_page_failed,
 			 rx_ring->rx_stats.alloc_buff_failed);
 		dev_info(&pf->pdev->dev,
-			 "    rx_rings[%i]: rx_stats: realloc_count = %lld, page_reuse_count = %lld\n",
+			 "    rx_rings[%i]: rx_stats: realloc_count = 0, page_reuse_count = %lld\n",
 			 i,
-			 rx_ring->rx_stats.realloc_count,
 			 rx_ring->rx_stats.page_reuse_count);
 		dev_info(&pf->pdev->dev,
 			 "    rx_rings[%i]: size = %i\n",
drivers/net/ethernet/intel/i40e/i40e_txrx.h +0 -1
index bfc2845..88387a6 100644
@@ -298,7 +298,6 @@ struct i40e_rx_queue_stats {
 	u64 alloc_page_failed;
 	u64 alloc_buff_failed;
 	u64 page_reuse_count;
-	u64 realloc_count;
 };
 
 enum i40e_ring_state_t {
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 i40e: Remove unused RX realloc stat

Quoted 3 lines · Joe Damato

rx_stats.realloc_count was not being incremented after 1a557afc4dd5, so
remove it.

A couple of nits for you. When referencing a commit, you should include the title in addition to the SHA [1].

Also, unused code should be sent to next-queue.

Thanks,
Tony

Quoted 6 lines

The debugfs string was left but hardcoded to 0. This is intended to prevent breaking any existing code / scripts that are parsing debugfs for i40e.

Fixes 1a557afc4dd5 ("i40e: Refactor receive routine")

https://www.kernel.org/doc/html/latest/process/submitting-
patches.html#describe-your-changes