Skip to contentSkip to conversation

powerpc/xmon: Dump XIVE information for online-only processors.

PATCH Applied Sachin Sant 3 participants 4 messages Jan 5, 2022 – Jan 10, 2022 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/xmon: Dump XIVE information for online-only processors.

dxa command in XMON debugger iterates through all possible processors. As a result, empty lines are printed even for processors which are not online.

CPU 47:pp=00 CPPR=ff IPI=0x0040002f PQ=-- EQ idx=699 T=0 00000000 00000000 CPU 48:
CPU 49:

Restrict XIVE information(dxa) to be displayed for online processors only.

---

arch/powerpc/xmon/xmon.c +2 -2
diff -Naurp a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
@@ -2817,12 +2817,12 @@ static void dump_all_xives(void)
 {
 	int cpu;
 
-	if (num_possible_cpus() == 0) {
+	if (num_online_cpus() == 0) {
 		printf("No possible cpus, use 'dx #' to dump individual cpus\n");
 		return;
 	}
 
-	for_each_possible_cpu(cpu)
+	for_each_online_cpu(cpu)
 		dump_one_xive(cpu);
 }
 
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Sachin Sant

dxa command in XMON debugger iterates through all possible processors. As a result, empty lines are printed even for processors which are not online.

CPU 47:pp=00 CPPR=ff IPI=0x0040002f PQ=-- EQ idx=699 T=0 00000000 00000000 CPU 48:
CPU 49:

Restrict XIVE information(dxa) to be displayed for online processors only.

Looks good to me. We should do the same for :

/sys/kernel/debug/powerpc/xive/ipis

Thanks,

C.

Quoted 20 lines

---
diff -Naurp a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c

arch/powerpc/xmon/xmon.c +2 -2
@@ -2817,12 +2817,12 @@ static void dump_all_xives(void)
  {
  	int cpu;
 
-	if (num_possible_cpus() == 0) {
+	if (num_online_cpus() == 0) {
  		printf("No possible cpus, use 'dx #' to dump individual cpus\n");
  		return;
  	}
 
-	for_each_possible_cpu(cpu)
+	for_each_online_cpu(cpu)
  		dump_one_xive(cpu);
  }
 
#2 lore raw
Quoted 13 lines · Cédric Le Goater
Quoted 8 lines · Sachin Sant

dxa command in XMON debugger iterates through all possible processors. As a result, empty lines are printed even for processors which are not online.
CPU 47:pp=00 CPPR=ff IPI=0x0040002f PQ=-- EQ idx=699 T=0 00000000 00000000 CPU 48:
CPU 49:
Restrict XIVE information(dxa) to be displayed for online processors only.

Quoted 3 lines

Looks good to me. We should do the same for :

/sys/kernel/debug/powerpc/xive/ipis

Thanks for the pointer. Will send a separate patch for this issue.

- Sachin

Quoted 7 lines

Thanks,

C.

#3 lore raw
In reply to Sachin Sant
Quoted 9 lines · Sachin Sant

dxa command in XMON debugger iterates through all possible processors. As a result, empty lines are printed even for processors which are not online.

CPU 47:pp=00 CPPR=ff IPI=0x0040002f PQ=-- EQ idx=699 T=0 00000000 00000000 CPU 48:
CPU 49:

[...]

Applied to powerpc/next.

[1/1] powerpc/xmon: Dump XIVE information for online-only processors.

      https://git.kernel.org/powerpc/c/f1aa0e47c29268776205698f2453dc07fab49855

cheers