sfc: Use swap() instead of open coding it
Subsystems (4)
PATCH 1/1 sfc: Use swap() instead of open coding it
Clean the following coccicheck warning:
./drivers/net/ethernet/sfc/efx_channels.c:870:36-37: WARNING opportunity for swap().
./drivers/net/ethernet/sfc/efx_channels.c:824:36-37: WARNING opportunity for swap().
--- drivers/net/ethernet/sfc/efx_channels.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-)
drivers/net/ethernet/sfc/efx_channels.c +4 -10
@@ -819,11 +819,8 @@ int efx_realloc_channels(struct efx_nic *efx, u32 rxq_entries, u32 txq_entries) old_txq_entries = efx->txq_entries; efx->rxq_entries = rxq_entries; efx->txq_entries = txq_entries; -for (i =0 ; i < efx->n_channels; i++) { - channel = efx->channel[i]; - efx->channel[i] = other_channel[i]; - other_channel[i] = channel; - } +for (i =0 ; i < efx->n_channels; i++) +swap (efx->channel[i], other_channel[i]);/* Restart buffer table allocation */ efx->next_buffer_table = next_buffer_table;
@@ -865,11 +862,8 @@ int efx_realloc_channels(struct efx_nic *efx, u32 rxq_entries, u32 txq_entries)/* Swap back */ efx->rxq_entries = old_rxq_entries; efx->txq_entries = old_txq_entries; -for (i =0 ; i < efx->n_channels; i++) { - channel = efx->channel[i]; - efx->channel[i] = other_channel[i]; - other_channel[i] = channel; - } +for (i =0 ; i < efx->n_channels; i++) +swap (efx->channel[i], other_channel[i]); goto out; }
Signature · 1 line
2.20.1.7.g153144c
Quoted 10 lines · Jiapeng Chong
Clean the following coccicheck warning:
./drivers/net/ethernet/sfc/efx_channels.c:870:36-37: WARNING opportunity for
swap()../drivers/net/ethernet/sfc/efx_channels.c:824:36-37: WARNING opportunity for
swap().Reported-by Abaci Robot <[email protected]>Signed-off-by Jiapeng Chong <[email protected]>
Quoted 38 lines
--- drivers/net/ethernet/sfc/efx_channels.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-)drivers/net/ethernet/sfc/efx_channels.c +4
-10@@ -819,11 +819,8 @@ int efx_realloc_channels(struct efx_nic *efx, u32 rxq_entries, u32 txq_entries) old_txq_entries = efx->txq_entries; efx->rxq_entries = rxq_entries; efx->txq_entries = txq_entries; -for (i =0 ; i < efx->n_channels; i++) { - channel = efx->channel[i]; - efx->channel[i] = other_channel[i]; - other_channel[i] = channel; - } +for (i =0 ; i < efx->n_channels; i++) +swap (efx->channel[i], other_channel[i]);/* Restart buffer table allocation */ efx->next_buffer_table = next_buffer_table;@@ -865,11 +862,8 @@ int efx_realloc_channels(struct efx_nic *efx, u32 rxq_entries, u32 txq_entries)/* Swap back */ efx->rxq_entries = old_rxq_entries; efx->txq_entries = old_txq_entries; -for (i =0 ; i < efx->n_channels; i++) { - channel = efx->channel[i]; - efx->channel[i] = other_channel[i]; - other_channel[i] = channel; - } +for (i =0 ; i < efx->n_channels; i++) +swap (efx->channel[i], other_channel[i]); goto out; }Signature · 1 line
2.20.1.7.g153144c
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:
Quoted 9 lines · On Wed, 5 Jan 2022 23:22:37 +0800 you wrote:
Clean the following coccicheck warning:
./drivers/net/ethernet/sfc/efx_channels.c:870:36-37: WARNING opportunity for
swap()../drivers/net/ethernet/sfc/efx_channels.c:824:36-37: WARNING opportunity for
swap().[...]
Here is the summary with links:
- sfc: Use swap() instead of open coding it
https://git.kernel.org/netdev/net-next/c/0cf765fb00ce
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html