Skip to contentSkip to conversation

amt: fix wrong return type of amt_send_membership_update()

PATCH Applied Taehee Yoo 2 participants 2 messages Jan 9, 2022 – Jan 10, 2022

Subsystems (3)
lore
Share & tools
lore

Taehee Yoo

author maintainer
#0 lore raw

PATCH 1/1 amt: fix wrong return type of amt_send_membership_update()

amt_send_membership_update() would return -1 but it's return type is bool. So, it should be used TRUE instead of -1.

Fixes cbc21dc1cfe9 ("amt: add data plane of amt interface")
---
 drivers/net/amt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/amt.c +1 -1
index b732ee9a50ef..d3a9dda6c728 100644
@@ -1106,7 +1106,7 @@ static bool amt_send_membership_query(struct amt_dev *amt,
 	rt = ip_route_output_key(amt->net, &fl4);
 	if (IS_ERR(rt)) {
 		netdev_dbg(amt->dev, "no route to %pI4\n", &tunnel->ip4);
-		return -1;
+		return true;
 	}
 
 	amtmq		= skb_push(skb, sizeof(*amtmq));
Signature · 1 line
2.17.1
#1 lore raw
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Sun, 9 Jan 2022 16:37:02 +0000 you wrote:

amt_send_membership_update() would return -1 but it's return type is bool. So, it should be used TRUE instead of -1.

Fixes cbc21dc1cfe9 ("amt: add data plane of amt interface")

[...]

Here is the summary with links:
- [net] amt: fix wrong return type of amt_send_membership_update()

    https://git.kernel.org/netdev/net/c/dd3ca4c5184e

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html