blk-throtl: avoid double charge of bio IOPS due to split
Subsystems (3)
PATCH 1/1 blk-throtl: avoid double charge of bio IOPS due to split
From: Chunguang Xu <[email protected]>
After commit 900e08075202("block: move queue enter logic into blk_mq_submit_bio()"), submit_bio_checks() moved to __submit_bio_fops() and blk_mq_submit_bio(). The IOs go through blk_mq_submit_bio() may be splited before entering blk-throtl, so we need to check whether the BIO is throttled, and only update the io_split_cnt for the THROTTLED bio to avoid double charge.
--- block/blk-throttle.c | 3 +++ 1 file changed, 3 insertions(+)
block/blk-throttle.c +3 -0
@@ -2049,6 +2049,9 @@ void blk_throtl_charge_bio_split(struct bio *bio)struct throtl_service_queue *parent_sq;bool rw =bio_data_dir (bio); +if (!bio_flagged (bio,BIO_THROTTLED )) +return ; + do { if (!parent->has_rules[rw]) break;
Signature · 1 line
1.8.3.1
Hi Chunguang,
Quoted 8 lines · brookxu
From: Chunguang Xu <[email protected]>
After commit 900e08075202("block: move queue enter logic into
blk_mq_submit_bio()"),submit_bio_checks()moved to__submit_bio_fops()andblk_mq_submit_bio(). The IOs go throughblk_mq_submit_bio()may be splited before entering blk-throtl, so we need to check whether the BIO is throttled, and only update theio_split_cntfor the THROTTLED bio to avoid double charge.
Today Jens has merged the patch[1] of "block: don't protect submit_bio_checks by q_usage_counter", so the behavior is switched back to previous behavior: running bio check before calling blk_mq_submit_bio() or ->submit_bio().
Then looks your patch isn't needn't any more.
Thanks,
Ming