atm: iphase: remove redundant pointer skb
Subsystems (4)
PATCH 1/1 atm: iphase: remove redundant pointer skb
The pointer skb is redundant, it is assigned a value that is never read and hence can be removed. Cleans up clang scan warning:
drivers/atm/iphase.c:205:18: warning: Although the value stored to 'skb' is used in the enclosing expression, the value is never actually read from 'skb' [deadcode.DeadStores]
--- drivers/atm/iphase.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/atm/iphase.c +1 -3
@@ -178,7 +178,6 @@ static void ia_hack_tcq(IADEV *dev) {static u16 get_desc (IADEV *dev,struct ia_vcc *iavcc) {u_short desc_num, i; -struct sk_buff *skb;struct ia_vcc *iavcc_r =NULL ;unsigned long delta;static unsigned long timer =0 ;
@@ -202,8 +201,7 @@ static u16 get_desc (IADEV *dev, struct ia_vcc *iavcc) {else dev->ffL.tcq_rd -=2 ; *(u_short *)(dev->seg_ram + dev->ffL.tcq_rd) = i+1 ; -if (!(skb = dev->desc_tbl[i].txskb) || - !(iavcc_r = dev->desc_tbl[i].iavcc)) +if (!dev->desc_tbl[i].txskb || !(iavcc_r = dev->desc_tbl[i].iavcc))printk ("Fatal err, desc table vcc or skb is NULL\n" );else iavcc_r->vc_desc_cnt--;
Signature · 1 line
2.33.1
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 8 lines · On Wed, 12 Jan 2022 23:55:33 +0000 you wrote:
The pointer skb is redundant, it is assigned a value that is never read and hence can be removed. Cleans up clang scan warning:
drivers/atm/iphase.c:205:18: warning: Although the value stored to 'skb' is used in the enclosing expression, the value is never actually read from 'skb' [deadcode.DeadStores][...]
Here is the summary with links:
- atm: iphase: remove redundant pointer skb
https://git.kernel.org/netdev/net/c/d7b430341102
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html