Skip to contentSkip to conversation

net/smc: Remove unused function declaration

PATCH Applied Wen Gu 3 participants 3 messages Jan 14, 2022 – Jan 15, 2022

Subsystems (4)
lore
Share & tools
lore

Wen Gu

author reviewer
#0 lore raw

PATCH 1/1 net/smc: Remove unused function declaration

The declaration of smc_wr_tx_dismiss_slots() is unused. So remove it.

Fixes 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock")
---
 net/smc/smc_wr.h | 4 ----
 1 file changed, 4 deletions(-)
net/smc/smc_wr.h +0 -4
index 47512cc..a54e90a 100644
@@ -125,10 +125,6 @@ int smc_wr_tx_v2_send(struct smc_link *link,
 int smc_wr_tx_send_wait(struct smc_link *link, struct smc_wr_tx_pend_priv *priv,
 			unsigned long timeout);
 void smc_wr_tx_cq_handler(struct ib_cq *ib_cq, void *cq_context);
-void smc_wr_tx_dismiss_slots(struct smc_link *lnk, u8 wr_rx_hdr_type,
-			     smc_wr_tx_filter filter,
-			     smc_wr_tx_dismisser dismisser,
-			     unsigned long data);
 void smc_wr_tx_wait_no_pending_sends(struct smc_link *link);
 
 int smc_wr_rx_register_handler(struct smc_wr_rx_handler *handler);
Signature · 1 line
1.8.3.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Wen Gu

The declaration of smc_wr_tx_dismiss_slots() is unused. So remove it.

Sorry, I missed to remove this

Quoted 3 lines
Fixes 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock")
Quoted 21 lines

---
net/smc/smc_wr.h | 4 ----

1 file changed, 4 deletions(-)
net/smc/smc_wr.h +0 -4
index 47512cc..a54e90a 100644
@@ -125,10 +125,6 @@ int smc_wr_tx_v2_send(struct smc_link *link,
 int smc_wr_tx_send_wait(struct smc_link *link, struct smc_wr_tx_pend_priv *priv,
 			unsigned long timeout);
 void smc_wr_tx_cq_handler(struct ib_cq *ib_cq, void *cq_context);
-void smc_wr_tx_dismiss_slots(struct smc_link *lnk, u8 wr_rx_hdr_type,
-			     smc_wr_tx_filter filter,
-			     smc_wr_tx_dismisser dismisser,
-			     unsigned long data);
 void smc_wr_tx_wait_no_pending_sends(struct smc_link *link);
 
 int smc_wr_rx_register_handler(struct smc_wr_rx_handler *handler);
Signature · 1 line
1.8.3.1
#2 lore raw
In reply to Wen Gu
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

Quoted 8 lines · On Fri, 14 Jan 2022 21:35:45 +0800 you wrote:

The declaration of smc_wr_tx_dismiss_slots() is unused. So remove it.

Fixes 349d43127dac ("net/smc: fix kernel panic caused by race of smc_sock")
---
 net/smc/smc_wr.h | 4 ----
 1 file changed, 4 deletions(-)

Here is the summary with links:
- [net] net/smc: Remove unused function declaration

    https://git.kernel.org/netdev/net/c/9404bc1e58e4

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html