netns: add schedule point in ops_exit_list()
Subsystems (2)
PATCH 1/1 netns: add schedule point in ops_exit_list()
From: Eric Dumazet <[email protected]>
When under stress, cleanup_net() can have to dismantle netns in big numbers. ops_exit_list() currently calls many helpers [1] that have no schedule point, and we can end up with soft lockups, particularly on hosts with many cpus.
Even for moderate amount of netns processed by cleanup_net() this patch avoids latency spikes.
[1] Some of these helpers like fib_sync_up() and fib_sync_down_dev() are very slow because net/ipv4/fib_semantics.c uses host-wide hash tables, and ifindex is used as the only input of two hash functions. ifindexes tend to be the same for all netns (lo.ifindex==1 per instance) This will be fixed in a separate patch.
--- net/core/net_namespace.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
net/core/net_namespace.c +3 -1
@@ -164,8 +164,10 @@ static void ops_exit_list(const struct pernet_operations *ops, {struct net *net;if (ops->exit) { -list_for_each_entry (net, net_exit_list, exit_list) +list_for_each_entry (net, net_exit_list, exit_list) { ops->exit (net); +cond_resched (); + } }if (ops->exit_batch) ops->exit_batch (net_exit_list);
Signature · 1 line
2.34.1.703.g22d0c6ccf7-goog
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 9 lines · On Tue, 18 Jan 2022 03:43:40 -0800 you wrote:
From: Eric Dumazet <[email protected]>
When under stress,
cleanup_net()can have to dismantle netns in big numbers.ops_exit_list()currently calls many helpers [1] that have no schedule point, and we can end up with soft lockups, particularly on hosts with many cpus.[...]
Here is the summary with links:
- [net] netns: add schedule point in ops_exit_list()
https://git.kernel.org/netdev/net/c/2836615aa22d
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html