ARM: shmobile: marzen: defconfig: enable DMA engine support

From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support

Building marzen_defconfig for next-20130626 results in the following build error:

drivers/built-in.o: In function `sh_mobile_sdhi_probe':
/home/bzolnier/sam/linux-sprc/drivers/mmc/host/sh_mobile_sdhi.c:170: undefined reference to `shdma_chan_filter'

Fix it by adding CONFIG_DMADEVICES=y line to marzen_defconfig. This will result in CONFIG_SH_DMAE_BASE being enabled by default and the needed code being build.

Cc Stephen Rothwell <[email protected]>

Cc Simon Horman <[email protected]>

Cc Magnus Damm <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
 arch/arm/configs/marzen_defconfig |    1 +
 1 file changed, 1 insertion(+)

Index: b/arch/arm/configs/marzen_defconfig
===================================================================

arch/arm/configs/marzen_defconfig +1 -0

@@ -96,6 +96,7 @@ CONFIG_USB_STORAGE=y
 CONFIG_NEW_LEDS=y
 CONFIG_LEDS_CLASS=y
 CONFIG_LEDS_GPIO=y
+CONFIG_DMADEVICES=y
 CONFIG_UIO=y
 CONFIG_UIO_PDRV_GENIRQ=y
 # CONFIG_IOMMU_SUPPORT is not set

[ Cc linux-sh and Guennadi ]

I have not looked into this closely but it seems to me that it would be more robust to resolve this problem using Kconfig.

Quoted 22 lines

From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support

Building marzen_defconfig for next-20130626 results in the following build error:

drivers/built-in.o: In function `sh_mobile_sdhi_probe':
/home/bzolnier/sam/linux-sprc/drivers/mmc/host/sh_mobile_sdhi.c:170: undefined reference to `shdma_chan_filter'

Fix it by adding CONFIG_DMADEVICES=y line to marzen_defconfig. This will result in CONFIG_SH_DMAE_BASE being enabled by default and the needed code being build.

Cc Stephen Rothwell <[email protected]>

Cc Simon Horman <[email protected]>

Cc Magnus Damm <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
 arch/arm/configs/marzen_defconfig |    1 +
 1 file changed, 1 insertion(+)

arch/arm/configs/marzen_defconfig CONFIG_USB_STORAGE=y · line 102

Quoted 13 lines

Index: b/arch/arm/configs/marzen_defconfig
===================================================================

arch/arm/configs/marzen_defconfig +1 -0

@@ -96,6 +96,7 @@ CONFIG_USB_STORAGE=y
 CONFIG_NEW_LEDS=y
 CONFIG_LEDS_CLASS=y
 CONFIG_LEDS_GPIO=y
+CONFIG_DMADEVICES=y
 CONFIG_UIO=y
 CONFIG_UIO_PDRV_GENIRQ=y
 # CONFIG_IOMMU_SUPPORT is not set

Hi

Quoted 4 lines · Simon Horman

[ Cc linux-sh and Guennadi ]

I have not looked into this closely but it seems to me that it would be more robust to resolve this problem using Kconfig.

I still think this

https://patchwork.kernel.org/patch/2640051/

is a proper fix. We cannot and do not want to force building shdma on all platforms, where SDHI or any other potential shdma client is built. It is perfectly valid to build SDHI with no DMA support, which is exactly what that patch makes possible.

Thanks
Guennadi

Quoted 24 lines · Bartlomiej Zolnierkiewicz

Quoted 22 lines

From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support

Building marzen_defconfig for next-20130626 results in the following build error:

drivers/built-in.o: In function `sh_mobile_sdhi_probe':
/home/bzolnier/sam/linux-sprc/drivers/mmc/host/sh_mobile_sdhi.c:170: undefined reference to `shdma_chan_filter'

Fix it by adding CONFIG_DMADEVICES=y line to marzen_defconfig. This will result in CONFIG_SH_DMAE_BASE being enabled by default and the needed code being build.

Cc Stephen Rothwell <[email protected]>

Cc Simon Horman <[email protected]>

Cc Magnus Damm <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
 arch/arm/configs/marzen_defconfig |    1 +
 1 file changed, 1 insertion(+)

Quoted 14 lines

arch/arm/configs/marzen_defconfig CONFIG_USB_STORAGE=y · line 102

Quoted 13 lines

Index: b/arch/arm/configs/marzen_defconfig
===================================================================

arch/arm/configs/marzen_defconfig +1 -0

@@ -96,6 +96,7 @@ CONFIG_USB_STORAGE=y
 CONFIG_NEW_LEDS=y
 CONFIG_LEDS_CLASS=y
 CONFIG_LEDS_GPIO=y
+CONFIG_DMADEVICES=y
 CONFIG_UIO=y
 CONFIG_UIO_PDRV_GENIRQ=y
 # CONFIG_IOMMU_SUPPORT is not set

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 11 lines · Guennadi Liakhovetski

Hi

Quoted 4 lines · Simon Horman

[ Cc linux-sh and Guennadi ]

I have not looked into this closely but it seems to me that it would be more robust to resolve this problem using Kconfig.

I still think this

Quoted 6 lines

https://patchwork.kernel.org/patch/2640051/

is a proper fix. We cannot and do not want to force building shdma on all platforms, where SDHI or any other potential shdma client is built. It is perfectly valid to build SDHI with no DMA support, which is exactly what that patch makes possible.

That is fine by me. Is there anything I can do to help move it forward?