rpmsg: fix driver_override memory leak
Subsystems (2)
PATCH 1/1 rpmsg: fix driver_override memory leak
rpmsg_core allows to override driver using driver_override sysfs attribute. When used, the sysfs store function will duplicate the user provided string using kstrndup. However, when the rpdev is released, the driver_override attribute is not freed. In order to have a consistent allocation and release, use kstrdup in rpmsg_chrdev_register_device and move it in rpmsg_core.c to avoid header dependencies. Moreover, add a rpmsg_release_device function to be called in device release. Drivers using rpmsg have been modified to use this function and ensure there will be no more memory leak when releasing rpmsg devices.
This was found with kmemleak while using remoteproc and virtio.
--- drivers/rpmsg/qcom_glink_native.c | 1 + drivers/rpmsg/qcom_smd.c | 1 + drivers/rpmsg/rpmsg_core.c | 22 ++++++++++++++++++++++ drivers/rpmsg/rpmsg_internal.h | 15 ++------------- drivers/rpmsg/virtio_rpmsg_bus.c | 1 + 5 files changed, 27 insertions(+), 13 deletions(-)
drivers/rpmsg/qcom_glink_native.c +1 -0
@@ -1373,6 +1373,7 @@ static void qcom_glink_rpdev_release(struct device *dev)struct glink_channel *channel =to_glink_channel (rpdev->ept); channel->rpdev =NULL ; +rpmsg_release_device (rpdev);kfree (rpdev); }
drivers/rpmsg/qcom_smd.c +1 -0
@@ -1047,6 +1047,7 @@ static void qcom_smd_release_device(struct device *dev)struct rpmsg_device *rpdev =to_rpmsg_device (dev);struct qcom_smd_device *qsdev =to_smd_device (rpdev); +rpmsg_release_device (rpdev);kfree (qsdev); }
drivers/rpmsg/rpmsg_core.c +22 -0
@@ -554,6 +554,28 @@ int rpmsg_unregister_device(struct device *parent, }EXPORT_SYMBOL (rpmsg_unregister_device); +void rpmsg_release_device (struct rpmsg_device *rpdev) +{ +kfree (rpdev->driver_override); +} +EXPORT_SYMBOL (rpmsg_release_device); + +/** +* rpmsg_chrdev_register_device() - register chrdev device based on rpdev +* @rpdev: prepared rpdev to be used for creating endpoints +* +* This function wraps rpmsg_register_device() preparing the rpdev for use as +* basis for the rpmsg chrdev. +*/ +int rpmsg_chrdev_register_device (struct rpmsg_device *rpdev) +{ +strcpy (rpdev->id.name,"rpmsg_chrdev" ); + rpdev->driver_override =kstrdup ("rpmsg_chrdev" ,GFP_KERNEL ); + +return rpmsg_register_device (rpdev); +} +EXPORT_SYMBOL (rpmsg_chrdev_register_device); +/** * __register_rpmsg_driver() - register an rpmsg driver with the rpmsg bus * @rpdrv: pointer to a struct rpmsg_driver
drivers/rpmsg/rpmsg_internal.h +2 -13
@@ -75,19 +75,8 @@ int rpmsg_unregister_device(struct device *parent,struct device *rpmsg_find_device (struct device *parent,struct rpmsg_channel_info *chinfo); -/** -* rpmsg_chrdev_register_device() - register chrdev device based on rpdev -* @rpdev: prepared rpdev to be used for creating endpoints -* -* This function wraps rpmsg_register_device() preparing the rpdev for use as -* basis for the rpmsg chrdev. -*/ -static inline int rpmsg_chrdev_register_device (struct rpmsg_device *rpdev) -{ -strcpy (rpdev->id.name,"rpmsg_chrdev" ); - rpdev->driver_override ="rpmsg_chrdev" ; +int rpmsg_chrdev_register_device (struct rpmsg_device *rpdev); -return rpmsg_register_device (rpdev); -} +void rpmsg_release_device (struct rpmsg_device *rpdev);#endif
drivers/rpmsg/virtio_rpmsg_bus.c +1 -0
@@ -381,6 +381,7 @@ static void virtio_rpmsg_release_device(struct device *dev)struct rpmsg_device *rpdev =to_rpmsg_device (dev);struct virtio_rpmsg_channel *vch =to_virtio_rpmsg_channel (rpdev); +rpmsg_release_device (rpdev);kfree (vch); }
Signature · 1 line
2.17.1
Mathieu Poirier
maintainerHi Clément,
Quoted 60 lines · Clement Leger
rpmsg_coreallows to override driver usingdriver_overridesysfs attribute. When used, the sysfs store function will duplicate the user provided string using kstrndup. However, when the rpdev is released, thedriver_overrideattribute is not freed. In order to have a consistent allocation and release, use kstrdup inrpmsg_chrdev_register_deviceand move it inrpmsg_core.cto avoid header dependencies. Moreover, add arpmsg_release_devicefunction to be called in device release. Drivers using rpmsg have been modified to use this function and ensure there will be no more memory leak when releasing rpmsg devices.
This was found with kmemleak while using remoteproc and virtio.Signed-off-by Clement Leger <[email protected]>--- drivers/rpmsg/qcom_glink_native.c | 1 + drivers/rpmsg/qcom_smd.c | 1 + drivers/rpmsg/rpmsg_core.c | 22 ++++++++++++++++++++++ drivers/rpmsg/rpmsg_internal.h | 15 ++------------- drivers/rpmsg/virtio_rpmsg_bus.c | 1 + 5 files changed, 27 insertions(+), 13 deletions(-)drivers/rpmsg/qcom_glink_native.c +1
-0@@ -1373,6 +1373,7 @@ static void qcom_glink_rpdev_release(struct device *dev)struct glink_channel *channel =to_glink_channel (rpdev->ept); channel->rpdev =NULL ; +rpmsg_release_device (rpdev);kfree (rpdev); }drivers/rpmsg/qcom_smd.c +1
-0@@ -1047,6 +1047,7 @@ static void qcom_smd_release_device(struct device *dev)struct rpmsg_device *rpdev =to_rpmsg_device (dev);struct qcom_smd_device *qsdev =to_smd_device (rpdev); +rpmsg_release_device (rpdev);kfree (qsdev); }drivers/rpmsg/rpmsg_core.c +7
-0@@ -554,6 +554,28 @@ int rpmsg_unregister_device(struct device *parent, }EXPORT_SYMBOL (rpmsg_unregister_device); +void rpmsg_release_device (struct rpmsg_device *rpdev) +{ +kfree (rpdev->driver_override); +} +EXPORT_SYMBOL (rpmsg_release_device); + +/**
drivers/rpmsg/rpmsg_core.c int rpmsg_unregister_device(struct device *parent, · line 573
Quoted 10 lines
drivers/rpmsg/rpmsg_core.c +10
-0+* rpmsg_chrdev_register_device() - register chrdev device based on rpdev +* @rpdev: prepared rpdev to be used for creating endpoints +* +* This function wraps rpmsg_register_device() preparing the rpdev for use as +* basis for the rpmsg chrdev. +*/ +int rpmsg_chrdev_register_device (struct rpmsg_device *rpdev) +{ +strcpy (rpdev->id.name,"rpmsg_chrdev" ); + rpdev->driver_override =kstrdup ("rpmsg_chrdev" ,GFP_KERNEL );
Have you considered using devm_kstrdup() instead? Since the same rpdev is available here and in field##_store(), proceeding that way would prevent the need to add a new rpmsg_release_device() function. Depending on header dependencies rpmsg_chrdev_register_device() may also be able to remain in rpmsg_internal.h.
Thanks,
Mathieu
Quoted 49 lines
drivers/rpmsg/rpmsg_core.c +5
-0+ +return rpmsg_register_device (rpdev); +} +EXPORT_SYMBOL (rpmsg_chrdev_register_device); +/** * __register_rpmsg_driver() - register an rpmsg driver with the rpmsg bus * @rpdrv: pointer to a struct rpmsg_driver drivers/rpmsg/rpmsg_internal.h +2
-13@@ -75,19 +75,8 @@ int rpmsg_unregister_device(struct device *parent,struct device *rpmsg_find_device (struct device *parent,struct rpmsg_channel_info *chinfo); -/** -* rpmsg_chrdev_register_device() - register chrdev device based on rpdev -* @rpdev: prepared rpdev to be used for creating endpoints -* -* This function wraps rpmsg_register_device() preparing the rpdev for use as -* basis for the rpmsg chrdev. -*/ -static inline int rpmsg_chrdev_register_device (struct rpmsg_device *rpdev) -{ -strcpy (rpdev->id.name,"rpmsg_chrdev" ); - rpdev->driver_override ="rpmsg_chrdev" ; +int rpmsg_chrdev_register_device (struct rpmsg_device *rpdev); -return rpmsg_register_device (rpdev); -} +void rpmsg_release_device (struct rpmsg_device *rpdev);#endif drivers/rpmsg/virtio_rpmsg_bus.c +1
-0@@ -381,6 +381,7 @@ static void virtio_rpmsg_release_device(struct device *dev)struct rpmsg_device *rpdev =to_rpmsg_device (dev);struct virtio_rpmsg_channel *vch =to_virtio_rpmsg_channel (rpdev); +rpmsg_release_device (rpdev);kfree (vch); }Signature · 1 line
2.17.1
Hi Mathieu,
Quoted 72 lines · ----- On 16 Jun, 2020, at 19:10, Mathieu Poirier [email protected]…
Hi Clément,
Quoted 69 lines · Clement Leger
rpmsg_coreallows to override driver usingdriver_overridesysfs attribute. When used, the sysfs store function will duplicate the user provided string using kstrndup. However, when the rpdev is released, thedriver_overrideattribute is not freed. In order to have a consistent allocation and release, use kstrdup inrpmsg_chrdev_register_deviceand move it inrpmsg_core.cto avoid header dependencies. Moreover, add arpmsg_release_devicefunction to be called in device release. Drivers using rpmsg have been modified to use this function and ensure there will be no more memory leak when releasing rpmsg devices.
This was found with kmemleak while using remoteproc and virtio.Signed-off-by Clement Leger <[email protected]>--- drivers/rpmsg/qcom_glink_native.c | 1 + drivers/rpmsg/qcom_smd.c | 1 + drivers/rpmsg/rpmsg_core.c | 22 ++++++++++++++++++++++ drivers/rpmsg/rpmsg_internal.h | 15 ++------------- drivers/rpmsg/virtio_rpmsg_bus.c | 1 + 5 files changed, 27 insertions(+), 13 deletions(-)drivers/rpmsg/qcom_glink_native.c +1
-0@@ -1373,6 +1373,7 @@ static void qcom_glink_rpdev_release(struct device *dev)struct glink_channel *channel =to_glink_channel (rpdev->ept); channel->rpdev =NULL ; +rpmsg_release_device (rpdev);kfree (rpdev); }drivers/rpmsg/qcom_smd.c +1
-0@@ -1047,6 +1047,7 @@ static void qcom_smd_release_device(struct device *dev)struct rpmsg_device *rpdev =to_rpmsg_device (dev);struct qcom_smd_device *qsdev =to_smd_device (rpdev); +rpmsg_release_device (rpdev);kfree (qsdev); }drivers/rpmsg/rpmsg_core.c +15
-0@@ -554,6 +554,28 @@ int rpmsg_unregister_device(struct device *parent, }EXPORT_SYMBOL (rpmsg_unregister_device); +void rpmsg_release_device (struct rpmsg_device *rpdev) +{ +kfree (rpdev->driver_override); +} +EXPORT_SYMBOL (rpmsg_release_device); + +/** +* rpmsg_chrdev_register_device() - register chrdev device based on rpdev +* @rpdev: prepared rpdev to be used for creating endpoints +* +* This function wraps rpmsg_register_device() preparing the rpdev for use as +* basis for the rpmsg chrdev. +*/ +int rpmsg_chrdev_register_device (struct rpmsg_device *rpdev) +{
Quoted 8 lines
drivers/rpmsg/rpmsg_core.c int rpmsg_unregister_device(struct device *parent, · line 573
Quoted 2 lines
drivers/rpmsg/rpmsg_core.c +2
-0+strcpy (rpdev->id.name,"rpmsg_chrdev" ); + rpdev->driver_override =kstrdup ("rpmsg_chrdev" ,GFP_KERNEL );Have you considered using
devm_kstrdup()instead? Since the same rpdev is available here and in field##_store(), proceeding that way would prevent the need to add a newrpmsg_release_device()function. Depending on header dependenciesrpmsg_chrdev_register_device()may also be able to remain inrpmsg_internal.h.
Indeed, using devm_kstrdup would be better. Regarding the use of kstrdup in headers, I only found a really really few occurences of such usage in the whole kernel. If you think it's ok, I can go go with it though.
Thanks,
Clément
Quoted 52 lines
Thanks,
MathieuQuoted 48 lines
drivers/rpmsg/rpmsg_core.c +5
-0+ +return rpmsg_register_device (rpdev); +} +EXPORT_SYMBOL (rpmsg_chrdev_register_device); +/** * __register_rpmsg_driver() - register an rpmsg driver with the rpmsg bus * @rpdrv: pointer to a struct rpmsg_driver drivers/rpmsg/rpmsg_internal.h +2
-13@@ -75,19 +75,8 @@ int rpmsg_unregister_device(struct device *parent,struct device *rpmsg_find_device (struct device *parent,struct rpmsg_channel_info *chinfo); -/** -* rpmsg_chrdev_register_device() - register chrdev device based on rpdev -* @rpdev: prepared rpdev to be used for creating endpoints -* -* This function wraps rpmsg_register_device() preparing the rpdev for use as -* basis for the rpmsg chrdev. -*/ -static inline int rpmsg_chrdev_register_device (struct rpmsg_device *rpdev) -{ -strcpy (rpdev->id.name,"rpmsg_chrdev" ); - rpdev->driver_override ="rpmsg_chrdev" ; +int rpmsg_chrdev_register_device (struct rpmsg_device *rpdev); -return rpmsg_register_device (rpdev); -} +void rpmsg_release_device (struct rpmsg_device *rpdev);#endif drivers/rpmsg/virtio_rpmsg_bus.c +1
-1@@ -381,6 +381,7 @@ static void virtio_rpmsg_release_device(struct device *dev)struct rpmsg_device *rpdev =to_rpmsg_device (dev);struct virtio_rpmsg_channel *vch =to_virtio_rpmsg_channel (rpdev); +rpmsg_release_device (rpdev);kfree (vch); } --2.17.1
Mathieu Poirier
maintainerQuoted 86 lines · Clément Leger
Hi Mathieu,
Quoted 72 lines · ----- On 16 Jun, 2020, at 19:10, Mathieu Poirier [email protected]…
Hi Clément,
Quoted 69 lines · Clement Leger
rpmsg_coreallows to override driver usingdriver_overridesysfs attribute. When used, the sysfs store function will duplicate the user provided string using kstrndup. However, when the rpdev is released, thedriver_overrideattribute is not freed. In order to have a consistent allocation and release, use kstrdup inrpmsg_chrdev_register_deviceand move it inrpmsg_core.cto avoid header dependencies. Moreover, add arpmsg_release_devicefunction to be called in device release. Drivers using rpmsg have been modified to use this function and ensure there will be no more memory leak when releasing rpmsg devices.
This was found with kmemleak while using remoteproc and virtio.Signed-off-by Clement Leger <[email protected]>--- drivers/rpmsg/qcom_glink_native.c | 1 + drivers/rpmsg/qcom_smd.c | 1 + drivers/rpmsg/rpmsg_core.c | 22 ++++++++++++++++++++++ drivers/rpmsg/rpmsg_internal.h | 15 ++------------- drivers/rpmsg/virtio_rpmsg_bus.c | 1 + 5 files changed, 27 insertions(+), 13 deletions(-)drivers/rpmsg/qcom_glink_native.c +1
-0@@ -1373,6 +1373,7 @@ static void qcom_glink_rpdev_release(struct device *dev)struct glink_channel *channel =to_glink_channel (rpdev->ept); channel->rpdev =NULL ; +rpmsg_release_device (rpdev);kfree (rpdev); }drivers/rpmsg/qcom_smd.c +1
-0@@ -1047,6 +1047,7 @@ static void qcom_smd_release_device(struct device *dev)struct rpmsg_device *rpdev =to_rpmsg_device (dev);struct qcom_smd_device *qsdev =to_smd_device (rpdev); +rpmsg_release_device (rpdev);kfree (qsdev); }drivers/rpmsg/rpmsg_core.c +15
-0@@ -554,6 +554,28 @@ int rpmsg_unregister_device(struct device *parent, }EXPORT_SYMBOL (rpmsg_unregister_device); +void rpmsg_release_device (struct rpmsg_device *rpdev) +{ +kfree (rpdev->driver_override); +} +EXPORT_SYMBOL (rpmsg_release_device); + +/** +* rpmsg_chrdev_register_device() - register chrdev device based on rpdev +* @rpdev: prepared rpdev to be used for creating endpoints +* +* This function wraps rpmsg_register_device() preparing the rpdev for use as +* basis for the rpmsg chrdev. +*/ +int rpmsg_chrdev_register_device (struct rpmsg_device *rpdev) +{Quoted 8 lines
drivers/rpmsg/rpmsg_core.c int rpmsg_unregister_device(struct device *parent, · line 573
Quoted 2 lines
drivers/rpmsg/rpmsg_core.c +2
-0+strcpy (rpdev->id.name,"rpmsg_chrdev" ); + rpdev->driver_override =kstrdup ("rpmsg_chrdev" ,GFP_KERNEL );Have you considered using
devm_kstrdup()instead? Since the same rpdev is available here and in field##_store(), proceeding that way would prevent the need to add a newrpmsg_release_device()function. Depending on header dependenciesrpmsg_chrdev_register_device()may also be able to remain inrpmsg_internal.h.
Quoted 3 lines
Indeed, using
devm_kstrdupwould be better. Regarding the use of kstrdup in headers, I only found a really really few occurences of such usage in the whole kernel. If you think it's ok, I can go go with it though.
I don't see an issue with using devm_kstrdup() in a header file.
Quoted 57 lines
Thanks,
Clément
Quoted 52 lines
Thanks,
MathieuQuoted 48 lines
drivers/rpmsg/rpmsg_core.c +5
-0+ +return rpmsg_register_device (rpdev); +} +EXPORT_SYMBOL (rpmsg_chrdev_register_device); +/** * __register_rpmsg_driver() - register an rpmsg driver with the rpmsg bus * @rpdrv: pointer to a struct rpmsg_driver drivers/rpmsg/rpmsg_internal.h +2
-13@@ -75,19 +75,8 @@ int rpmsg_unregister_device(struct device *parent,struct device *rpmsg_find_device (struct device *parent,struct rpmsg_channel_info *chinfo); -/** -* rpmsg_chrdev_register_device() - register chrdev device based on rpdev -* @rpdev: prepared rpdev to be used for creating endpoints -* -* This function wraps rpmsg_register_device() preparing the rpdev for use as -* basis for the rpmsg chrdev. -*/ -static inline int rpmsg_chrdev_register_device (struct rpmsg_device *rpdev) -{ -strcpy (rpdev->id.name,"rpmsg_chrdev" ); - rpdev->driver_override ="rpmsg_chrdev" ; +int rpmsg_chrdev_register_device (struct rpmsg_device *rpdev); -return rpmsg_register_device (rpdev); -} +void rpmsg_release_device (struct rpmsg_device *rpdev);#endif drivers/rpmsg/virtio_rpmsg_bus.c +1
-1@@ -381,6 +381,7 @@ static void virtio_rpmsg_release_device(struct device *dev)struct rpmsg_device *rpdev =to_rpmsg_device (dev);struct virtio_rpmsg_channel *vch =to_virtio_rpmsg_channel (rpdev); +rpmsg_release_device (rpdev);kfree (vch); } --2.17.1
Quoted 88 lines · ----- On 16 Jun, 2020, at 21:13, Mathieu Poirier [email protected]…
Quoted 87 lines · Clément Leger
Hi Mathieu,
----- On 16 Jun, 2020, at 19:10, Mathieu Poirier [email protected]
Quoted 80 lines · wrote:
Hi Clément,
Quoted 61 lines · Clement Leger
rpmsg_coreallows to override driver usingdriver_overridesysfs attribute. When used, the sysfs store function will duplicate the user provided string using kstrndup. However, when the rpdev is released, thedriver_overrideattribute is not freed. In order to have a consistent allocation and release, use kstrdup inrpmsg_chrdev_register_deviceand move it inrpmsg_core.cto avoid header dependencies. Moreover, add arpmsg_release_devicefunction to be called in device release. Drivers using rpmsg have been modified to use this function and ensure there will be no more memory leak when releasing rpmsg devices.
This was found with kmemleak while using remoteproc and virtio.Signed-off-by Clement Leger <[email protected]>--- drivers/rpmsg/qcom_glink_native.c | 1 + drivers/rpmsg/qcom_smd.c | 1 + drivers/rpmsg/rpmsg_core.c | 22 ++++++++++++++++++++++ drivers/rpmsg/rpmsg_internal.h | 15 ++------------- drivers/rpmsg/virtio_rpmsg_bus.c | 1 + 5 files changed, 27 insertions(+), 13 deletions(-)drivers/rpmsg/qcom_glink_native.c +1
-0@@ -1373,6 +1373,7 @@ static void qcom_glink_rpdev_release(struct device *dev)struct glink_channel *channel =to_glink_channel (rpdev->ept); channel->rpdev =NULL ; +rpmsg_release_device (rpdev);kfree (rpdev); }drivers/rpmsg/qcom_smd.c +1
-0@@ -1047,6 +1047,7 @@ static void qcom_smd_release_device(struct device *dev)struct rpmsg_device *rpdev =to_rpmsg_device (dev);struct qcom_smd_device *qsdev =to_smd_device (rpdev); +rpmsg_release_device (rpdev);kfree (qsdev); }drivers/rpmsg/rpmsg_core.c +7
-0@@ -554,6 +554,28 @@ int rpmsg_unregister_device(struct device *parent, }EXPORT_SYMBOL (rpmsg_unregister_device); +void rpmsg_release_device (struct rpmsg_device *rpdev) +{ +kfree (rpdev->driver_override); +} +EXPORT_SYMBOL (rpmsg_release_device); + +/** drivers/rpmsg/rpmsg_core.c int rpmsg_unregister_device(struct device *parent, · line 573
Quoted 10 lines
drivers/rpmsg/rpmsg_core.c +10
-0+* rpmsg_chrdev_register_device() - register chrdev device based on rpdev +* @rpdev: prepared rpdev to be used for creating endpoints +* +* This function wraps rpmsg_register_device() preparing the rpdev for use as +* basis for the rpmsg chrdev. +*/ +int rpmsg_chrdev_register_device (struct rpmsg_device *rpdev) +{ +strcpy (rpdev->id.name,"rpmsg_chrdev" ); + rpdev->driver_override =kstrdup ("rpmsg_chrdev" ,GFP_KERNEL );Have you considered using
devm_kstrdup()instead? Since the same rpdev is available here and in field##_store(), proceeding that way would prevent the need to add a newrpmsg_release_device()function. Depending on header dependenciesrpmsg_chrdev_register_device()may also be able to remain inrpmsg_internal.h.
Quoted 5 lines
Quoted 3 lines
Indeed, using
devm_kstrdupwould be better. Regarding the use of kstrdup in headers, I only found a really really few occurences of such usage in the whole kernel. If you think it's ok, I can go go with it though.I don't see an issue with using
devm_kstrdup()in a header file.
Ok, anyway after looking more thoroughly in using devm_kstrndup, it will be possible to make the modification really localized in sysfs store only. I just have to add devm_kstrndup which does not exists yet.
Quoted 58 lines
Quoted 58 lines
Thanks,
Clément
Quoted 52 lines
Thanks,
MathieuQuoted 48 lines
drivers/rpmsg/rpmsg_core.c +5
-0+ +return rpmsg_register_device (rpdev); +} +EXPORT_SYMBOL (rpmsg_chrdev_register_device); +/** * __register_rpmsg_driver() - register an rpmsg driver with the rpmsg bus * @rpdrv: pointer to a struct rpmsg_driver drivers/rpmsg/rpmsg_internal.h +2
-13@@ -75,19 +75,8 @@ int rpmsg_unregister_device(struct device *parent,struct device *rpmsg_find_device (struct device *parent,struct rpmsg_channel_info *chinfo); -/** -* rpmsg_chrdev_register_device() - register chrdev device based on rpdev -* @rpdev: prepared rpdev to be used for creating endpoints -* -* This function wraps rpmsg_register_device() preparing the rpdev for use as -* basis for the rpmsg chrdev. -*/ -static inline int rpmsg_chrdev_register_device (struct rpmsg_device *rpdev) -{ -strcpy (rpdev->id.name,"rpmsg_chrdev" ); - rpdev->driver_override ="rpmsg_chrdev" ; +int rpmsg_chrdev_register_device (struct rpmsg_device *rpdev); -return rpmsg_register_device (rpdev); -} +void rpmsg_release_device (struct rpmsg_device *rpdev);#endif drivers/rpmsg/virtio_rpmsg_bus.c +1
-1@@ -381,6 +381,7 @@ static void virtio_rpmsg_release_device(struct device *dev)struct rpmsg_device *rpdev =to_rpmsg_device (dev);struct virtio_rpmsg_channel *vch =to_virtio_rpmsg_channel (rpdev); +rpmsg_release_device (rpdev);kfree (vch); } --2.17.1