FAILED: patch "[PATCH] powerpc/32s: Fix kasan_init_region() for KASAN" failed to apply to 5.15-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 5.15-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From d37823c3528e5e0705fc7746bcbc2afffb619259 Mon Sep 17 00:00:00 2001
From: Christophe Leroy <[email protected]>
Date: Mon, 10 Jan 2022 15:29:25 +0000
Subject: [PATCH] powerpc/32s: Fix kasan_init_region() for KASAN
It has been reported some configuration where the kernel doesn't boot with KASAN enabled.
This is due to wrong BAT allocation for the KASAN area:
---[ Data Block Address Translation ]--- 0: 0xc0000000-0xcfffffff 0x00000000 256M Kernel rw m 1: 0xd0000000-0xdfffffff 0x10000000 256M Kernel rw m 2: 0xe0000000-0xefffffff 0x20000000 256M Kernel rw m 3: 0xf8000000-0xf9ffffff 0x2a000000 32M Kernel rw m 4: 0xfa000000-0xfdffffff 0x2c000000 64M Kernel rw m
A BAT must have both virtual and physical addresses alignment matching the size of the BAT. This is not the case for BAT 4 above.
Fix kasan_init_region() by using block_size() function that is in book3s32/mmu.c. To be able to reuse it here, make it non static and change its name to bat_block_size() in order to avoid name conflict with block_size() defined in <linux/blkdev.h>
Also reuse find_free_bat() to avoid an error message from setbat() when no BAT is available.
And allocate memory outside of linear memory mapping to avoid wasting that precious space.
With this change we get correct alignment for BATs and KASAN shadow memory is allocated outside the linear memory space.
---[ Data Block Address Translation ]--- 0: 0xc0000000-0xcfffffff 0x00000000 256M Kernel rw 1: 0xd0000000-0xdfffffff 0x10000000 256M Kernel rw 2: 0xe0000000-0xefffffff 0x20000000 256M Kernel rw 3: 0xf8000000-0xfbffffff 0x7c000000 64M Kernel rw 4: 0xfc000000-0xfdffffff 0x7a000000 32M Kernel rw
arch/powerpc/include/asm/book3s/32/mmu-hash.h +2 -0
@@ -223,6 +223,8 @@ static __always_inline void update_user_segments(u32 val) update_user_segment(15, val); } +int __init find_free_bat (void ); +unsigned int bat_block_size (unsigned long base,unsigned long top);#endif /* !__ASSEMBLY__ */ /* We happily ignore the smaller BATs on 601, we don't actually use
arch/powerpc/mm/book3s32/mmu.c +5 -5
@@ -76,7 +76,7 @@ unsigned long p_block_mapped(phys_addr_t pa)return 0 ; } -static int __init find_free_bat (void ) +int __init find_free_bat (void ) {int b;int n =mmu_has_feature (MMU_FTR_USE_HIGH_BATS ) ?8 :4 ;
@@ -100,7 +100,7 @@ static int __init find_free_bat(void)* - block size has to be a power of two. This is calculated by finding the * highest bit set to 1. */ -static unsigned int block_size (unsigned long base,unsigned long top) +unsigned int bat_block_size (unsigned long base,unsigned long top) {unsigned int max_size =SZ_256M ;unsigned int base_shift = (ffs (base) -1 ) &31 ;
@@ -145,7 +145,7 @@ static unsigned long __init __mmu_mapin_ram(unsigned long base, unsigned long toint idx;while ((idx =find_free_bat ()) !=-1 && base != top) { -unsigned int size =block_size (base, top); +unsigned int size =bat_block_size (base, top);if (size <128 <<10 )break ;
@@ -201,12 +201,12 @@ void mmu_mark_initmem_nx(void)unsigned long size;for (i =0 ; i < nb -1 && base < top;) { - size =block_size (base, top); + size =bat_block_size (base, top);setibat (i++,PAGE_OFFSET + base, base, size,PAGE_KERNEL_TEXT ); base += size; }if (base < top) { - size =block_size (base, top); + size =bat_block_size (base, top);if ((top - base) > size) { size <<=1 ;if (strict_kernel_rwx_enabled () && base + size > border)
arch/powerpc/mm/kasan/book3s_32.c +31 -28
79 lines not on this page · raw message