FAILED: patch "[PATCH] net/mlx5e: IPsec: Fix crypto offload for non TCP/UDP" failed to apply to 5.15-stable tree
[email protected]
maintainerThe patch below does not apply to the 5.15-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 5352859b3bfa0ca188b2f1d2c1436fddc781e3b6 Mon Sep 17 00:00:00 2001
From: Raed Salem <[email protected]>
Date: Thu, 2 Dec 2021 17:43:50 +0200
Subject: [PATCH] net/mlx5e: IPsec: Fix crypto offload for non TCP/UDP
encapsulated traffic
IPsec crypto offload always set the ethernet segment checksum flags with the inner L4 header checksum flag enabled for encapsulated IPsec offloaded packet regardless of the encapsulated L4 header type, and even if it doesn't exists in the first place, this breaks non TCP/UDP traffic as such.
Set the inner L4 checksum flag only when the encapsulated L4 header protocol is TCP/UDP using software parser swp_inner_l4_offset field as indication.
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.h +6 -3
@@ -131,14 +131,17 @@ static inline bool mlx5e_ipsec_txwqe_build_eseg_csum(struct mlx5e_txqsq *sq, struct sk_buff *skb, struct mlx5_wqe_eth_seg *eseg) { - struct xfrm_offload *xo = xfrm_offload(skb); + u8 inner_ipproto;if (!mlx5e_ipsec_eseg_meta (eseg))return false; eseg->cs_flags =MLX5_ETH_WQE_L3_CSUM ; -if (xo->inner_ipproto) { - eseg->cs_flags |=MLX5_ETH_WQE_L4_INNER_CSUM |MLX5_ETH_WQE_L3_INNER_CSUM ; + inner_ipproto =xfrm_offload (skb)->inner_ipproto; +if (inner_ipproto) { + eseg->cs_flags |=MLX5_ETH_WQE_L3_INNER_CSUM ; +if (inner_ipproto ==IPPROTO_TCP || inner_ipproto ==IPPROTO_UDP ) + eseg->cs_flags |=MLX5_ETH_WQE_L4_INNER_CSUM ; }else if (likely (skb->ip_summed ==CHECKSUM_PARTIAL )) { eseg->cs_flags |=MLX5_ETH_WQE_L4_CSUM ; sq->stats->csum_partial_inner++;