Skip to contentSkip to conversation

eal/windows: add interrupt functions stub

PATCH Superseded Pallavi Kadam 4 participants 7 messages Dec 11, 2020 – Jan 5, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eal/windows: add interrupt functions stub

Add some missing interrupt implementations on Windows. Also add respestive functions to export file.

---
 lib/librte_eal/rte_eal_exports.def      | 11 ++++
 lib/librte_eal/windows/eal_interrupts.c | 76 +++++++++++++++++++++++++
 2 files changed, 87 insertions(+)
lib/librte_eal/rte_eal_exports.def +11 -0
index 6a6be1cfa..98a38ed32 100644
@@ -63,6 +63,17 @@ EXPORTS
 	rte_get_tsc_hz
 	rte_hexdump
 	rte_hypervisor_get
+	rte_intr_ack
+	rte_intr_allow_others
+	rte_intr_callback_register
+	rte_intr_callback_unregister
+	rte_intr_cap_multiple
+	rte_intr_disable
+	rte_intr_dp_is_en
+	rte_intr_efd_disable
+	rte_intr_efd_enable
+	rte_intr_enable
+	rte_intr_free_epoll_fd
 	rte_intr_rx_ctl
 	rte_lcore_count
 	rte_lcore_has_role
lib/librte_eal/windows/eal_interrupts.c +76 -0

79 lines not on this page · raw message

Signature · 1 line
2.18.0.windows.1
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Pallavi Kadam

Add some missing interrupt implementations on Windows. Also add respestive functions to export file.

---
 lib/librte_eal/rte_eal_exports.def      | 11 ++++
 lib/librte_eal/windows/eal_interrupts.c | 76 +++++++++++++++++++++++++
 2 files changed, 87 insertions(+)
#2 lore raw
In reply to Pallavi Kadam
Quoted 20 lines · Pallavi Kadam

Add some missing interrupt implementations on Windows. Also add respestive functions to export file.

---
 lib/librte_eal/rte_eal_exports.def      | 11 ++++
 lib/librte_eal/windows/eal_interrupts.c | 76 +++++++++++++++++++++++++
 2 files changed, 87 insertions(+)
lib/librte_eal/rte_eal_exports.def +1 -0
index 6a6be1cfa..98a38ed32 100644
@@ -63,6 +63,17 @@ EXPORTS
 	rte_get_tsc_hz
 	rte_hexdump
 	rte_hypervisor_get
+	rte_intr_ack

lib/librte_eal/rte_eal_exports.def EXPORTS · line 76

Quoted 10 lines
lib/librte_eal/rte_eal_exports.def +10 -0
+	rte_intr_allow_others
+	rte_intr_callback_register
+	rte_intr_callback_unregister
+	rte_intr_cap_multiple
+	rte_intr_disable
+	rte_intr_dp_is_en
+	rte_intr_efd_disable
+	rte_intr_efd_enable
+	rte_intr_enable
+	rte_intr_free_epoll_fd

Might as well add all remaining interrupt APIs:

rte_intr_callback_unregister_pending
rte_intr_tls_epfd

Quoted 3 lines
lib/librte_eal/rte_eal_exports.def +0 -0
 	rte_intr_rx_ctl
 	rte_lcore_count
 	rte_lcore_has_role
#3 lore raw

Hi Dmitry,

Quoted 33 lines · Dmitry Kozlyuk
Quoted 20 lines · Pallavi Kadam

Add some missing interrupt implementations on Windows. Also add respestive functions to export file.

---
  lib/librte_eal/rte_eal_exports.def      | 11 ++++
  lib/librte_eal/windows/eal_interrupts.c | 76 +++++++++++++++++++++++++
  2 files changed, 87 insertions(+)
lib/librte_eal/rte_eal_exports.def +1 -0
index 6a6be1cfa..98a38ed32 100644
@@ -63,6 +63,17 @@ EXPORTS
  	rte_get_tsc_hz
  	rte_hexdump
  	rte_hypervisor_get
+	rte_intr_ack

lib/librte_eal/rte_eal_exports.def EXPORTS · line 76

Quoted 10 lines
lib/librte_eal/rte_eal_exports.def +10 -0
+	rte_intr_allow_others
+	rte_intr_callback_register
+	rte_intr_callback_unregister
+	rte_intr_cap_multiple
+	rte_intr_disable
+	rte_intr_dp_is_en
+	rte_intr_efd_disable
+	rte_intr_efd_enable
+	rte_intr_enable
+	rte_intr_free_epoll_fd

Might as well add all remaining interrupt APIs:

Quoted 2 lines

rte_intr_callback_unregister_pending
rte_intr_tls_epfd

Sent out v2 with additional interrupt APIs.

Please let me know if anything is missing.

Thanks,

Quoted 4 lines
Quoted 4 lines
lib/librte_eal/rte_eal_exports.def +0 -0
  	rte_intr_rx_ctl
  	rte_lcore_count
  	rte_lcore_has_role
#4 lore raw

PATCH v2 1/1 eal/windows: add interrupt functions stub

In reply to Pallavi Kadam

Add some missing interrupt implementations on Windows. Also add respective functions to export file.

v2 changes:
Add remaining interrupt APIs (Dmitry Kozlyuk)

---
 lib/librte_eal/rte_eal_exports.def      |  16 +++
 lib/librte_eal/windows/eal_interrupts.c | 126 ++++++++++++++++++++++++
 2 files changed, 142 insertions(+)
lib/librte_eal/rte_eal_exports.def +16 -0
index 6a6be1cfa..dd8398f88 100644
@@ -56,6 +56,9 @@ EXPORTS
 	rte_eal_tailq_register
 	rte_eal_using_phys_addrs
 	rte_eal_wait_lcore
+	rte_epoll_ctl
+	rte_epoll_wait
+	rte_epoll_wait_interruptible
 	rte_exit
 	rte_free
 	rte_get_main_lcore
@@ -63,7 +66,20 @@ EXPORTS
 	rte_get_tsc_hz
 	rte_hexdump
 	rte_hypervisor_get
+	rte_intr_ack
+	rte_intr_allow_others
+	rte_intr_callback_register
+	rte_intr_callback_unregister
+	rte_intr_callback_unregister_pending
+	rte_intr_cap_multiple
+	rte_intr_disable
+	rte_intr_dp_is_en
+	rte_intr_efd_disable
+	rte_intr_efd_enable
+	rte_intr_enable
+	rte_intr_free_epoll_fd
 	rte_intr_rx_ctl
+	rte_intr_tls_epfd
 	rte_lcore_count
 	rte_lcore_has_role
 	rte_lcore_index
lib/librte_eal/windows/eal_interrupts.c +126 -0

129 lines not on this page · raw message

Signature · 1 line
2.18.0.windows.1
#6 lore raw

15/12/2020 23:39, Dmitry Kozlyuk:

Quoted 10 lines · Pallavi Kadam
Quoted 7 lines

Add some missing interrupt implementations on Windows. Also add respective functions to export file.

Applied, thanks

Note: rte_eal_exports.def is sorted as version.map to ease comparison.