lapi/fsmount.h: remove useless sys/mount.h
PATCH 1/1 lapi/fsmount.h: remove useless sys/mount.h
--- include/lapi/fsmount.h | 1 - 1 file changed, 1 deletion(-)
include/lapi/fsmount.h +0 -1
@@ -7,7 +7,6 @@#ifndef LAPI_FSMOUNT_H__ #define LAPI_FSMOUNT_H__ -#include <sys/mount.h> #include <sys/syscall.h> #include <sys/types.h>
Signature · 5 lines
1.8.3.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Dai, Viresh, all,
[ Cc: Viresh, as he's the author ]
Quoted 10 lines
Signed-off-by Dai Shili <[email protected]>--- include/lapi/fsmount.h | 1 - 1 file changed, 1 deletion(-)include/lapi/fsmount.h +0
-0
include/lapi/fsmount.h line 10
Quoted 4 lines
include/lapi/fsmount.h +0
-1@@ -7,7 +7,6 @@#ifndef LAPI_FSMOUNT_H__ #define LAPI_FSMOUNT_H__ -#include <sys/mount.h>
indeed now is sys/mount.h useless, but we're not sure if there is no wrapper for new syscalls (e.g. fsopen, fsconfig, fspick, move_mount, ...) in any libc in the future. Because we have configure checks for these functions. @Viresh, was this the reason why you added <sys/mount.h> ?
Kind regards,
Petr
Quoted 2 lines
include/lapi/fsmount.h +0
-0#include <sys/syscall.h> #include <sys/types.h>
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 17 lines · Petr Vorel
Hi Dai, Viresh, all,
[ Cc: Viresh, as he's the author ]
Quoted 12 lines
Signed-off-by Dai Shili <[email protected]>--- include/lapi/fsmount.h | 1 - 1 file changed, 1 deletion(-)include/lapi/fsmount.h +0
-0@@ -7,7 +7,6 @@#ifndef LAPI_FSMOUNT_H__ #define LAPI_FSMOUNT_H__
Quoted 6 lines
include/lapi/fsmount.h line 10
Quoted 1 line
include/lapi/fsmount.h +0
-1-#include <sys/mount.h> indeed now is
sys/mount.huseless, but we're not sure if there is no wrapper for new syscalls (e.g. fsopen, fsconfig, fspick,move_mount, ...) in any libc in the future. Because we have configure checks for these functions. @Viresh, was this the reason why you added <sys/mount.h> ?
Right. Once the libc has the prototypes of these routines, most of fsmount.h will become useless and sys/mount.h is the one that is going to be used.
Signature · 4 lines
viresh -- Mailing list info: https://lists.linux.it/listinfo/ltp