FAILED: patch "[PATCH] tty: n_gsm: fix deadlock in gsmtty_open()" failed to apply to 4.14-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 4.14-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From a2ab75b8e76e455af7867e3835fd9cdf386b508f Mon Sep 17 00:00:00 2001
From: "[email protected]" <[email protected]>
Date: Thu, 17 Feb 2022 23:31:23 -0800
Subject: [PATCH] tty: n_gsm: fix deadlock in gsmtty_open()
In the current implementation the user may open a virtual tty which then could fail to establish the underlying DLCI. The function gsmtty_open() gets stuck in tty_port_block_til_ready() while waiting for a carrier rise. This happens if the remote side fails to acknowledge the link establishment request in time or completely. At some point gsm_dlci_close() is called to abort the link establishment attempt. The function tries to inform the associated virtual tty by performing a hangup. But the blocking loop within tty_port_block_til_ready() is not informed about this event. The patch proposed here fixes this by resetting the initialization state of the virtual tty to ensure the loop exits and triggering it to make tty_port_block_til_ready() return.
drivers/tty/n_gsm.c +3 -0
@@ -1457,6 +1457,9 @@ static void gsm_dlci_close(struct gsm_dlci *dlci)if (dlci->addr !=0 ) {tty_port_tty_hangup (&dlci->port, false);kfifo_reset (&dlci->fifo); +/* Ensure that gsmtty_open() can return. */ +tty_port_set_initialized (&dlci->port,0 ); +wake_up_interruptible (&dlci->port.open_wait); }else dlci->gsm->dead = true;/* Unregister gsmtty driver,report gsmtty dev remove uevent for user */