Skip to contentSkip to conversation

net: ipa: add an interconnect dependency

PATCH Applied Alex Elder 2 participants 2 messages Mar 1, 2022 – Mar 3, 2022

Subsystems (4)
lore
Share & tools
lore

Alex Elder

author
#0 lore raw

PATCH v2 1/1 net: ipa: add an interconnect dependency

In order to function, the IPA driver very clearly requires the interconnect framework to be enabled in the kernel configuration. State that dependency in the Kconfig file.

This became a problem when CONFIG_COMPILE_TEST support was added. Non-Qualcomm platforms won't necessarily enable CONFIG_INTERCONNECT.

Fixes 38a4066f593c5 ("net: ipa: support COMPILE_TEST")

---
v2: Rebased as requested.

 drivers/net/ipa/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ipa/Kconfig +1 -0
index e0164a55c1e66..6782c2cbf542f 100644
@@ -2,6 +2,7 @@ config QCOM_IPA
 	tristate "Qualcomm IPA support"
 	depends on NET && QCOM_SMEM
 	depends on ARCH_QCOM || COMPILE_TEST
+	depends on INTERCONNECT
 	depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST)
 	depends on QCOM_AOSS_QMP || QCOM_AOSS_QMP=n
 	select QCOM_MDT_LOADER if ARCH_QCOM
Signature · 1 line
2.32.0
#1 lore raw
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Tue, 1 Mar 2022 05:34:40 -0600 you wrote:

In order to function, the IPA driver very clearly requires the interconnect framework to be enabled in the kernel configuration. State that dependency in the Kconfig file.

This became a problem when CONFIG_COMPILE_TEST support was added. Non-Qualcomm platforms won't necessarily enable CONFIG_INTERCONNECT.

[...]

Here is the summary with links:
- [net,v2] net: ipa: add an interconnect dependency

    https://git.kernel.org/netdev/net/c/1dba41c9d2e2

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html