Skip to contentSkip to conversation

maintainers: add explicit maintainer for some bbdev PMDs

PATCH New Nicolas Chautru 4 participants 5 messages Mar 3, 2022 – Mar 9, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 maintainers: add explicit maintainer for some bbdev PMDs

Suggested by Bruce to add explicit maintainer for some of the existing bbdev PMDs even it is already implicit currently.
Intent is to be easier for user to get hit when looking for a specific PMD.

Nicolas Chautru (1):
maintainers: add explicit maintainer for some bbdev PMDs

 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/1 maintainers: add explicit maintainer for some bbdev PMDs

These were implicit from DPDK script but adding
separate reference to make it explicit

---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)
MAINTAINERS +4 -0
index 7577834..004ec91 100644
@@ -421,6 +421,10 @@ T: git://dpdk.org/next/dpdk-next-crypto
 F: lib/bbdev/
 F: doc/guides/prog_guide/bbdev.rst
 F: drivers/baseband/
+F: drivers/baseband/turbo_sw/
+F: drivers/baseband/fpga_lte_fec/
+F: drivers/baseband/fpga_5gnr_fec/
+F: drivers/baseband/acc100/
 F: doc/guides/bbdevs/
 F: app/test-bbdev/
 F: doc/guides/tools/testbbdev.rst
Signature · 1 line
1.8.3.1
Acked-by on v1 1/1
#2 lore raw
Quoted 8 lines · Nicolas Chautru

These were implicit from DPDK script but adding
separate reference to make it explicit

---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)

Thanks for this. It just means that someone looking for the driver name in the MAINTAINERS file will get a hit, rather than having to know that it's implicit in the top-level baseband directory.

#3 lore raw
In reply to Nicolas Chautru

03/03/2022 19:51, Nicolas Chautru:

Quoted 13 lines

These were implicit from DPDK script but adding
separate reference to make it explicit

---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)
MAINTAINERS +0 -0
index 7577834..004ec91 100644

MAINTAINERS T: git://dpdk.org/next/dpdk-next-crypto · line 423

Quoted 3 lines
MAINTAINERS +0 -0
@@ -421,6 +421,10 @@ T: git://dpdk.org/next/dpdk-next-crypto
 F: lib/bbdev/
 F: doc/guides/prog_guide/bbdev.rst
 F: drivers/baseband/

I think you can remove the above catch-all.

MAINTAINERS T: git://dpdk.org/next/dpdk-next-crypto · line 427

Quoted 4 lines
MAINTAINERS +4 -0
+F: drivers/baseband/turbo_sw/
+F: drivers/baseband/fpga_lte_fec/
+F: drivers/baseband/fpga_5gnr_fec/
+F: drivers/baseband/acc100/

I would prefer a separate section for Intel baseband drivers.

Quoted 3 lines
MAINTAINERS +0 -0
 F: doc/guides/bbdevs/
 F: app/test-bbdev/
 F: doc/guides/tools/testbbdev.rst
#4 lore raw
Quoted 21 lines · Thomas Monjalon

03/03/2022 19:51, Nicolas Chautru:

Quoted 13 lines

These were implicit from DPDK script but adding
separate reference to make it explicit

---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)
MAINTAINERS +0 -0
index 7577834..004ec91 100644

MAINTAINERS T: git://dpdk.org/next/dpdk-next-crypto · line 423

Quoted 3 lines
MAINTAINERS +0 -0
@@ -421,6 +421,10 @@ T: git://dpdk.org/next/dpdk-next-crypto
 F: lib/bbdev/
 F: doc/guides/prog_guide/bbdev.rst
 F: drivers/baseband/

I think you can remove the above catch-all.

Quoted 6 lines

MAINTAINERS T: git://dpdk.org/next/dpdk-next-crypto · line 427

Quoted 4 lines
MAINTAINERS +4 -0
+F: drivers/baseband/turbo_sw/
+F: drivers/baseband/fpga_lte_fec/
+F: drivers/baseband/fpga_5gnr_fec/
+F: drivers/baseband/acc100/

I would prefer a separate section for Intel baseband drivers.

We now have a baseband drivers section with a NXP driver. It is more clear to have Intel drivers in this section like we do for other classes of devices: one section for API, one section for drivers.

Btw, the baseband drivers section is missing a global T: entry too. It means that updates on nxp (atm) and any (in the future) bbdev driver ends up in the main repo scope instead of next-crypto.

Quoted 2 lines

MAINTAINERS T: git://dpdk.org/next/dpdk-next-crypto · line 428

Quoted 2 lines
MAINTAINERS +0 -0
 F: doc/guides/bbdevs/

This too is a catch all.
For the API section, I'd rather see:
-F: drivers/baseband/
-F: doc/guides/bbdevs/
+F: doc/guides/bbdevs/features/default.ini

Quoted 2 lines
Quoted 2 lines
MAINTAINERS +0 -0
 F: app/test-bbdev/
 F: doc/guides/tools/testbbdev.rst
Signature · 1 line
David Marchand