net: tcp: fix shim definition of tcp_inbound_md5_hash
Subsystems (3)
PATCH 1/1 net: tcp: fix shim definition of tcp_inbound_md5_hash
When CONFIG_TCP_MD5SIG isn't enabled, there is a compilation bug due to the fact that the static inline definition of tcp_inbound_md5_hash() has an unexpected semicolon. Remove it.
--- include/net/tcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/net/tcp.h +1 -1
@@ -1693,7 +1693,7 @@ tcp_md5_do_lookup(const struct sock *sk, int l3index,static inline enum skb_drop_reason tcp_inbound_md5_hash (const struct sock *sk,const struct sk_buff *skb,const void *saddr,const void *daddr, -int family,int dif,int sdif); +int family,int dif,int sdif) {return SKB_NOT_DROPPED_YET ; }
Signature · 1 line
2.25.1
Quoted 8 lines · Vladimir Oltean
When
CONFIG_TCP_MD5SIGisn't enabled, there is a compilation bug due to the fact that the static inline definition oftcp_inbound_md5_hash()has an unexpected semicolon. Remove it.Fixes 1330b6ef3313 ("skb: make drop reason booleanable")Signed-off-by Vladimir Oltean <[email protected]>---
Thanks!
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 9 Mar 2022 14:20:12 +0200 you wrote:
When
CONFIG_TCP_MD5SIGisn't enabled, there is a compilation bug due to the fact that the static inline definition oftcp_inbound_md5_hash()has an unexpected semicolon. Remove it.Fixes 1330b6ef3313 ("skb: make drop reason booleanable")Signed-off-by Vladimir Oltean <[email protected]>[...]
Here is the summary with links:
- [net-next] net: tcp: fix shim definition of tcp_inbound_md5_hash
https://git.kernel.org/netdev/net-next/c/24055bb87977
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html