Skip to contentSkip to conversation

net: netvsc: remove break after return

PATCH Applied Saurabh Sengar 3 participants 3 messages Mar 10, 2022 – Mar 12, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: netvsc: remove break after return

In function netvsc_process_raw_pkt for VM_PKT_DATA_USING_XFER_PAGES case there is already a 'return' statement which results 'break' as dead code

---
 drivers/net/hyperv/netvsc.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/hyperv/netvsc.c +0 -1
index e675d10..9442f75 100644
@@ -1630,7 +1630,6 @@ static int netvsc_process_raw_pkt(struct hv_device *device,
 
 	case VM_PKT_DATA_USING_XFER_PAGES:
 		return netvsc_receive(ndev, net_device, nvchan, desc);
-		break;
 
 	case VM_PKT_DATA_INBAND:
 		netvsc_receive_inband(ndev, net_device, desc);
Signature · 1 line
1.8.3.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 25 lines

-----Original Message-----
From: Saurabh Sengar <[email protected]>
Sent: Thursday, March 10, 2022 12:32 PM
To: Saurabh Singh Sengar <[email protected]>; Haiyang Zhang <[email protected]>; KY Srinivasan <[email protected]>; Stephen Hemminger <[email protected]>; [email protected]; Dexuan Cui <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: [PATCH] net: netvsc: remove break after return

In function netvsc_process_raw_pkt for VM_PKT_DATA_USING_XFER_PAGES case there is already a 'return' statement which results 'break' as dead code

---
 drivers/net/hyperv/netvsc.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/hyperv/netvsc.c +0 -0
index e675d10..9442f75 100644

drivers/net/hyperv/netvsc.c static int netvsc_process_raw_pkt(struct hv_device *device, · line 1634

Quoted 6 lines
drivers/net/hyperv/netvsc.c +0 -1
@@ -1630,7 +1630,6 @@ static int netvsc_process_raw_pkt(struct hv_device *device,
 
 	case VM_PKT_DATA_USING_XFER_PAGES:
 		return netvsc_receive(ndev, net_device, nvchan, desc);
-		break;
 
 	case VM_PKT_DATA_INBAND:

Thanks.

#2 lore raw
In reply to Saurabh Sengar
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Thu, 10 Mar 2022 09:32:14 -0800 you wrote:

In function netvsc_process_raw_pkt for VM_PKT_DATA_USING_XFER_PAGES case there is already a 'return' statement which results 'break' as dead code

---
 drivers/net/hyperv/netvsc.c | 1 -
 1 file changed, 1 deletion(-)

Here is the summary with links:
- net: netvsc: remove break after return

    https://git.kernel.org/netdev/net-next/c/8cf5ab362dce

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html