ethernet: 8390: Remove unnecessary print function dev_err()
Subsystems (3)
PATCH 1/1 ethernet: 8390: Remove unnecessary print function dev_err()
The print function dev_err() is redundant because platform_get_irq() already prints an error.
Eliminate the follow coccicheck warning:
./drivers/net/ethernet/8390/mcf8390.c:414:2-9: line 414 is redundant because platform_get_irq() already prints an error
--- drivers/net/ethernet/8390/mcf8390.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/ethernet/8390/mcf8390.c +1 -3
@@ -410,10 +410,8 @@ static int mcf8390_probe(struct platform_device *pdev)int ret, irq; irq =platform_get_irq (pdev,0 ); -if (irq <0 ) { -dev_err (&pdev->dev,"no IRQ specified?\n" ); +if (irq <0 )return -ENXIO ; - } mem =platform_get_resource (pdev,IORESOURCE_MEM ,0 );if (mem ==NULL ) {
Signature · 1 line
2.20.1.7.g153144c
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Fri, 11 Mar 2022 08:17:56 +0800 you wrote:
The print function
dev_err()is redundant becauseplatform_get_irq()already prints an error.Eliminate the follow coccicheck warning:
./drivers/net/ethernet/8390/mcf8390.c:414:2-9: line 414 is redundant becauseplatform_get_irq()already prints an error[...]
Here is the summary with links:
- [-next] ethernet: 8390: Remove unnecessary print function dev_err()
https://git.kernel.org/netdev/net-next/c/d59c85ddacb3
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html