Skip to contentSkip to conversation

net: sparx5: fix a couple warning messages

PATCH Applied Dan Carpenter 2 participants 2 messages Mar 14, 2022 – Mar 15, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: sparx5: fix a couple warning messages

The WARN_ON() macro takes a condition, not a warning message.

Fixes 0933bd04047c ("net: sparx5: Add support for ptp clocks")
---
 drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c +2 -2
index cd110c31e5a4..0ed1ea7727c5 100644
@@ -45,7 +45,7 @@ static u64 sparx5_ptp_get_1ppm(struct sparx5 *sparx5)
 		res =  920535763834;
 		break;
 	default:
-		WARN_ON("Invalid core clock");
+		WARN(1, "Invalid core clock");
 		break;
 	}
 
@@ -67,7 +67,7 @@ static u64 sparx5_ptp_get_nominal_value(struct sparx5 *sparx5)
 		res = 0x0CC6666666666666;
 		break;
 	default:
-		WARN_ON("Invalid core clock");
+		WARN(1, "Invalid core clock");
 		break;
 	}
 
Signature · 1 line
2.20.1
#1 lore raw
This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:

Quoted 7 lines · On Mon, 14 Mar 2022 17:03:27 +0300 you wrote:

The WARN_ON() macro takes a condition, not a warning message.

Fixes 0933bd04047c ("net: sparx5: Add support for ptp clocks")
---
 drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
- [net-next] net: sparx5: fix a couple warning messages

    https://git.kernel.org/netdev/net-next/c/c24f657791fd

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html