drm/amdkfd: Check for potential null return of kmalloc_array()
Subsystems (3)
PATCH 1/1 drm/amdkfd: Check for potential null return of kmalloc_array()
As the kmalloc_array() may return null, the 'event_waiters[i].wait' would lead to null-pointer dereference. Therefore, it is better to check the return value of kmalloc_array() to avoid this confusion.
Signed-off-by QintaoShen <[email protected]>
--- drivers/gpu/drm/amd/amdkfd/kfd_events.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/amdkfd/kfd_events.c +2 -0
@@ -749,6 +749,8 @@ static struct kfd_event_waiter *alloc_event_waiters(uint32_t num_events) event_waiters =kmalloc_array (num_events,sizeof (struct kfd_event_waiter ),GFP_KERNEL ); +if (!event_waiters) +return NULL ;for (i =0 ; (event_waiters) && (i < num_events) ; i++) {init_wait (&event_waiters[i].wait);
Signature · 1 line
2.7.4
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 25 lines · QintaoShen
As the
kmalloc_array()may return null, the 'event_waiters[i].wait' would lead to null-pointer dereference. Therefore, it is better to check the return value ofkmalloc_array()to avoid this confusion.Signed-off-by QintaoShen <[email protected]>--- drivers/gpu/drm/amd/amdkfd/kfd_events.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/amd/amdkfd/kfd_events.c +2
-1@@ -749,6 +749,8 @@ static struct kfd_event_waiter *alloc_event_waiters(uint32_t num_events) event_waiters =kmalloc_array (num_events,sizeof (struct kfd_event_waiter ),GFP_KERNEL ); +if (!event_waiters) +return NULL ;for (i =0 ; (event_waiters) && (i < num_events) ; i++) {init_wait (&event_waiters[i].wait); --2.7.4