Skip to contentSkip to conversation

FAILED: patch "[PATCH] firmware: stratix10-svc: add missing callback parameter on" failed to apply to 5.4-stable tree

PATCH [email protected] 1 participant 1 message Apr 1, 2022

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 5.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From b850b7a8b369322adf699ef48ceff4d902525c8c Mon Sep 17 00:00:00 2001
From: Ang Tien Sung <[email protected]>
Date: Wed, 23 Feb 2022 08:41:46 -0600
Subject: [PATCH] firmware: stratix10-svc: add missing callback parameter on
RSU

Fix a bug whereby, the return response of parameter a1 from an SMC call is not properly set to the callback data during an INTEL_SIP_SMC_RSU_ERROR command.

drivers/firmware/stratix10-svc.c +1 -1
index 4bd57a908efe..8177a0fae11d 100644
@@ -483,7 +483,7 @@ static int svc_normal_to_secure_thread(void *data)
 		case INTEL_SIP_SMC_RSU_ERROR:
 			pr_err("%s: STATUS_ERROR\n", __func__);
 			cbdata->status = BIT(SVC_STATUS_ERROR);
-			cbdata->kaddr1 = NULL;
+			cbdata->kaddr1 = &res.a1;
 			cbdata->kaddr2 = NULL;
 			cbdata->kaddr3 = NULL;
 			pdata->chan->scl->receive_cb(pdata->chan->scl, cbdata);