ath10k: add support for MSDU IDs for USB devices
PATCH 1/2 ath10k: add support for MSDU IDs for USB devices
commit 93bbdec6683e1c8ba2cc4e6 ("ath10k: htt: support MSDU ids with SDIO") introduced MSDU ID allocation in the htt TX path for high latency devices. This feature needs to be enabled for USB as well in order to have a functional TX path.
--- drivers/net/wireless/ath/ath10k/usb.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/wireless/ath/ath10k/usb.c +1 -0
@@ -1013,6 +1013,7 @@ static int ath10k_usb_probe(struct usb_interface *interface, bus_params.dev_type =ATH10K_DEV_TYPE_HL ;/* TODO: don't know yet how to get chip_id with USB */ bus_params.chip_id =0 ; + bus_params.hl_msdu_ids = true; ret =ath10k_core_register (ar, &bus_params);if (ret) {ath10k_warn (ar,"failed to register driver core: %d\n" , ret);
Signature · 7 lines
2.35.1 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
PATCH 2/2 ath10k: enable napi on RX path for usb
commit cfee8793a74dc3afabb08fc9 ("ath10k: enable napi on RX path for sdio") introduced napi for SDIO and updated the htt interface for high latency devices.
These changes breaks USB, so USB code must be updated to use napi as well in order to have a working RX path.
--- drivers/net/wireless/ath/ath10k/usb.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
drivers/net/wireless/ath/ath10k/usb.c +26 -0
@@ -345,6 +345,12 @@ static void ath10k_usb_rx_complete(struct ath10k *ar, struct sk_buff *skb) ep->ep_ops.ep_rx_complete (ar, skb);/* The RX complete handler now owns the skb... */ +if (test_bit (ATH10K_FLAG_CORE_REGISTERED , &ar->dev_flags)) { +local_bh_disable (); +napi_schedule (&ar->napi); +local_bh_enable (); + } +return ; out_free_skb:
@@ -387,6 +393,7 @@ static int ath10k_usb_hif_start(struct ath10k *ar)int i;struct ath10k_usb *ar_usb =ath10k_usb_priv (ar); +ath10k_core_napi_enable (ar);ath10k_usb_start_recv_pipes (ar);/* set the TX resource avail threshold for each TX pipe */
@@ -462,6 +469,7 @@ static int ath10k_usb_hif_tx_sg(struct ath10k *ar, u8 pipe_id,static void ath10k_usb_hif_stop (struct ath10k *ar) {ath10k_usb_flush_all (ar); +ath10k_core_napi_sync_disable (ar); }static u16 ath10k_usb_hif_get_free_queue_number (struct ath10k *ar,u8 pipe_id)
@@ -966,6 +974,20 @@ static int ath10k_usb_create(struct ath10k *ar,return ret; } +static int ath10k_usb_napi_poll (struct napi_struct *ctx,int budget) +{ + struct ath10k *ar = container_of(ctx, struct ath10k, napi); +int done; + + done =ath10k_htt_rx_hl_indication (ar, budget); +ath10k_dbg (ar,ATH10K_DBG_USB ,"napi poll: done: %d, budget:%d\n" , done, budget); + +if (done < budget) +napi_complete_done (ctx, done); + +return done; +} +/* ath10k usb driver registered functions */ static int ath10k_usb_probe (struct usb_interface *interface,const struct usb_device_id *id)
@@ -992,6 +1014,9 @@ static int ath10k_usb_probe(struct usb_interface *interface,return -ENOMEM ; } +netif_napi_add (&ar->napi_dev, &ar->napi, ath10k_usb_napi_poll, +ATH10K_NAPI_BUDGET ); +usb_get_dev (dev); vendor_id =le16_to_cpu (dev->descriptor.idVendor); product_id =le16_to_cpu (dev->descriptor.idProduct);
@@ -1045,6 +1070,7 @@ static void ath10k_usb_remove(struct usb_interface *interface)return ;ath10k_core_unregister (ar_usb->ar); +netif_napi_del (&ar_usb->ar->napi);ath10k_usb_destroy (ar_usb->ar);usb_put_dev (interface_to_usbdev (interface));ath10k_core_destroy (ar_usb->ar);
Signature · 7 lines
2.35.1 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 6 lines · Erik Stromdahl
commit
93bbdec6683e1c8ba2cc4e6("ath10k: htt: support MSDU ids with SDIO") introduced MSDU ID allocation in the htt TX path for high latency devices. This feature needs to be enabled for USB as well in order to have a functional TX path.Signed-off-by Erik Stromdahl <[email protected]>
On what hardware and firmware version did you test these patches? I'll then add the Tested-on tag:
https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#tested-on_tag
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 7 lines · Kalle Valo
Quoted 5 lines · Erik Stromdahl
commit
93bbdec6683e1c8ba2cc4e6("ath10k: htt: support MSDU ids with SDIO") introduced MSDU ID allocation in the htt TX path for high latency devices. This feature needs to be enabled for USB as well in order to have a functional TX path.
Quoted 7 lines
Quoted 1 line
Signed-off-by Erik Stromdahl <[email protected]>On what hardware and firmware version did you test these patches? I'll then add the Tested-on tag:
https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#tested-on_tag
Hardware: Linksys WUSB6100M
Fw version: QCA9377 hw1.0 USB 1.0.0.299
Above fw version is printed by the driver at startup:
ath10k_log_dbg: usb 1-3 firmware 1.0.0.299 booted
The firmware file can be obtained from here:
https://www.linksys.com/se/support-article?articleNum=198580
Quoted 16 lines · Erik Stromdahl
Quoted 7 lines · Kalle Valo
Quoted 5 lines · Erik Stromdahl
commit
93bbdec6683e1c8ba2cc4e6("ath10k: htt: support MSDU ids with SDIO") introduced MSDU ID allocation in the htt TX path for high latency devices. This feature needs to be enabled for USB as well in order to have a functional TX path.Quoted 7 lines
Quoted 1 line
Signed-off-by Erik Stromdahl <[email protected]>On what hardware and firmware version did you test these patches? I'll then add the Tested-on tag:
https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#tested-on_tag
Quoted 6 lines
Hardware: Linksys WUSB6100M
Fw version: QCA9377 hw1.0 USB 1.0.0.299Above fw version is printed by the driver at startup:
ath10k_log_dbg: usb 1-3 firmware 1.0.0.299 booted
Thanks, I added this:
Tested-on: QCA9377 hw1.0 USB 1.0.0.299
Signature · 8 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 9 lines · Erik Stromdahl
commit
93bbdec6683e1c8ba2cc4e6("ath10k: htt: support MSDU ids with SDIO") introduced MSDU ID allocation in the htt TX path for high latency devices. This feature needs to be enabled for USB as well in order to have a functional TX path.Tested-on: QCA9377 hw1.0 USB 1.0.0.299
Signed-off-by Erik Stromdahl <[email protected]>Signed-off-by Kalle Valo <[email protected]>
2 patches applied to ath-next branch of ath.git, thanks.
2c977be2cc5c ath10k: add support for MSDU IDs for USB devices d930e2560ebe ath10k: enable napi on RX path for usb
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches