Skip to contentSkip to conversation

Bluetooth: btintel: Constify static struct regmap_bus

PATCH Applied Rikard Falkeborn 3 participants 3 messages Mar 30, 2022 – Apr 1, 2022 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth: btintel: Constify static struct regmap_bus

The only usage of regmap_ibt is to (after the regmap_init() macro is expanded), pass its address to __regmap_init(), which takes a pointer to const struct regmap_bus as input. Make it const to allow the compiler to put it in read-only memory.

---
 drivers/bluetooth/btintel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/btintel.c +1 -1
index 06514ed66022..818681c89db8 100644
@@ -794,7 +794,7 @@ static void regmap_ibt_free_context(void *context)
 	kfree(context);
 }
 
-static struct regmap_bus regmap_ibt = {
+static const struct regmap_bus regmap_ibt = {
 	.read = regmap_ibt_read,
 	.write = regmap_ibt_write,
 	.gather_write = regmap_ibt_gather_write,
Signature · 1 line
2.35.1
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=627655

---Test result---

Test Summary:

CheckPatch                    PASS      1.62 seconds
GitLint                       PASS      0.98 seconds
SubjectPrefix                 PASS      0.87 seconds
BuildKernel                   PASS      33.48 seconds
BuildKernel32                 PASS      29.99 seconds
Incremental Build with patchesPASS      40.13 seconds
TestRunner: Setup             PASS      494.49 seconds
TestRunner: l2cap-tester      PASS      16.50 seconds
TestRunner: bnep-tester       PASS      6.43 seconds
TestRunner: mgmt-tester       PASS      106.51 seconds
TestRunner: rfcomm-tester     PASS      8.49 seconds
TestRunner: sco-tester        PASS      8.29 seconds
TestRunner: smp-tester        PASS      8.33 seconds
TestRunner: userchan-tester   PASS      6.81 seconds

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Rikard Falkeborn
This patch was applied to bluetooth/bluetooth-next.git (master) by Marcel Holtmann <[email protected]>:

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master) by Marcel Holtmann <[email protected]>:

Quoted 8 lines · On Thu, 31 Mar 2022 00:32:52 +0200 you wrote:

The only usage of regmap_ibt is to (after the regmap_init() macro is expanded), pass its address to __regmap_init(), which takes a pointer to const struct regmap_bus as input. Make it const to allow the compiler to put it in read-only memory.

[...]

Here is the summary with links:
- Bluetooth: btintel: Constify static struct regmap_bus

    https://git.kernel.org/bluetooth/bluetooth-next/c/30b0001fcdc1

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html