arm64: mte: Fix the stack frame size warning in mte_dump_tag_range()
Catalin Marinas
maintainerPATCH 1/1 arm64: mte: Fix the stack frame size warning in mte_dump_tag_range()
With 64K page configurations, the tags array stored on the stack of the mte_dump_tag_range() function is 2048 bytes, triggering a compiler warning when CONFIG_FRAME_WARN is enabled. Switch to a kmalloc() allocation via mte_allocate_tag_storage().
--- arch/arm64/kernel/elfcore.c | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-)
arch/arm64/kernel/elfcore.c +20 -4
@@ -32,10 +32,11 @@ static unsigned long mte_vma_tag_dump_size(struct vm_area_struct *vma)static int mte_dump_tag_range (struct coredump_params *cprm,unsigned long start,unsigned long end) { +int ret =1 ;unsigned long addr; +void *tags =NULL ;for (addr = start; addr < end; addr +=PAGE_SIZE ) { -char tags[MTE_PAGE_TAG_STORAGE ];struct page *page =get_dump_page (addr);/*
@@ -59,13 +60,28 @@ static int mte_dump_tag_range(struct coredump_params *cprm,continue ; } +if (!tags) { + tags =mte_allocate_tag_storage (); +if (!tags) { +put_page (page); + ret =0 ; +break ; + } + } +mte_save_page_tags (page_address (page), tags);put_page (page); -if (!dump_emit (cprm, tags,MTE_PAGE_TAG_STORAGE )) -return 0 ; +if (!dump_emit (cprm, tags,MTE_PAGE_TAG_STORAGE )) { +mte_free_tag_storage (tags); + ret =0 ; +break ; + } } -return 1 ; +if (tags) +mte_free_tag_storage (tags); + +return ret; }Elf_Half elf_core_extra_phdrs (void )
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 6 lines · Catalin Marinas
With 64K page configurations, the tags array stored on the stack of the
mte_dump_tag_range()function is 2048 bytes, triggering a compiler warning whenCONFIG_FRAME_WARNis enabled. Switch to akmalloc()allocation viamte_allocate_tag_storage().
Applied to arm64 (for-next/fixes), thanks!
[1/1] arm64: mte: Fix the stack frame size warning in mte_dump_tag_range()
https://git.kernel.org/arm64/c/16decce22efa
Cheers,
Signature · 10 lines
Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel