Skip to contentSkip to conversation

Patch "ARM: 9187/1: JIVE: fix return value of __setup handler" has been added to the 5.15-stable tree

PATCH [email protected] 1 participant 1 message Apr 4, 2022

Subsystems (3)
lore
Share & tools
lore

[email protected]

author Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ARM: 9187/1: JIVE: fix return value of __setup handler

to the 5.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     arm-9187-1-jive-fix-return-value-of-__setup-handler.patch

and it can be found in the queue-5.15 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From 8b2360c7157b462c4870d447d1e65d30ef31f9aa Mon Sep 17 00:00:00 2001
From: Randy Dunlap <[email protected]>
Date: Sat, 12 Mar 2022 07:36:09 +0100
Subject: ARM: 9187/1: JIVE: fix return value of __setup handler

From: Randy Dunlap <[email protected]>

commit 8b2360c7157b462c4870d447d1e65d30ef31f9aa upstream.

__setup() handlers should return 1 to obsolete_checksetup() in init/main.c to indicate that the boot option has been handled. A return of 0 causes the boot option/value to be listed as an Unknown kernel parameter and added to init's (limited) argument or environment strings. Also, error return codes don't mean anything to obsolete_checksetup() -- only non-zero (usually 1) or zero. So return 1 from jive_mtdset().

Fixes 9db829f485c5 ("[ARM] JIVE: Initial machine support for Logitech Jive")
Cc Ben Dooks <[email protected]>
Cc Krzysztof Kozlowski <[email protected]>
Cc Alim Akhtar <[email protected]>
---
 arch/arm/mach-s3c/mach-jive.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-s3c/mach-jive.c +3 -3
@@ -236,11 +236,11 @@ static int __init jive_mtdset(char *opti
 	unsigned long set;
 
 	if (options == NULL || options[0] == '\0')
-		return 0;
+		return 1;
 
 	if (kstrtoul(options, 10, &set)) {
 		printk(KERN_ERR "failed to parse mtdset=%s\n", options);
-		return 0;
+		return 1;
 	}
 
 	switch (set) {
@@ -255,7 +255,7 @@ static int __init jive_mtdset(char *opti
 		       "using default.", set);
 	}
 
-	return 0;
+	return 1;
 }
 
 /* parse the mtdset= option given to the kernel command line */

Patches currently in stable-queue which might be from [email protected] are

queue-5.15/tomoyo-fix-__setup-handlers-return-values.patch queue-5.15/evm-fix-the-evm-__setup-handler-return-value.patch queue-5.15/mm-mmap-return-1-from-stack_guard_gap-__setup-handler.patch queue-5.15/tty-hvc-fix-return-value-of-__setup-handler.patch queue-5.15/pm-suspend-fix-return-value-of-__setup-handler.patch queue-5.15/clocksource-acpi_pm-fix-return-value-of-__setup-hand.patch queue-5.15/mips-rb532-fix-return-value-of-__setup-handler.patch queue-5.15/acpi-apei-fix-return-value-of-__setup-handlers.patch queue-5.15/dma-debug-fix-return-value-of-__setup-handlers.patch queue-5.15/hv-utils-add-ptp_1588_clock-to-kconfig-to-fix-build.patch queue-5.15/m68k-coldfire-device.c-only-build-for-mcf_edma-when-.patch queue-5.15/printk-fix-return-value-of-printk.devkmsg-__setup-ha.patch queue-5.15/mips-dec-honor-config_mips_fp_support-n.patch queue-5.15/net-sparx5-uses-depends-on-bridge-or-bridge.patch queue-5.15/net-sparx5-depends-on-ptp_1588_clock_optional.patch queue-5.15/pm-hibernate-fix-__setup-handler-error-handling.patch queue-5.15/kgdboc-fix-return-value-of-__setup-handler.patch queue-5.15/mm-memcontrol-return-1-from-cgroup.memory-__setup-handler.patch queue-5.15/driver-core-dd-fix-return-value-of-__setup-handler.patch queue-5.15/kgdbts-fix-return-value-of-__setup-handler.patch queue-5.15/mm-usercopy-return-1-from-hardened_usercopy-__setup-handler.patch queue-5.15/arm-9187-1-jive-fix-return-value-of-__setup-handler.patch

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel