Skip to contentSkip to conversation

qed: fix ethtool register dump

PATCH Applied Manish Chopra 3 participants 3 messages Apr 1, 2022 – Apr 4, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qed: fix ethtool register dump

To fix a coverity complain, commit d5ac07dfbd2b ("qed: Initialize debug string array") removed "sw-platform" (one of the common global parameters) from the dump as this was used in the dump with an uninitialized string, however it did not reduce the number of common global parameters which caused the incorrect (unable to parse) register dump

this patch fixes it with reducing NUM_COMMON_GLOBAL_PARAMS bye one.

Cc Tim Gardner <[email protected]>
Cc "David S. Miller" <[email protected]>
Fixes d5ac07dfbd2b ("qed: Initialize debug string array")
---
 drivers/net/ethernet/qlogic/qed/qed_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/qlogic/qed/qed_debug.c +1 -1
index e3edca187ddf..5250d1d1e49c 100644
@@ -489,7 +489,7 @@ struct split_type_defs {
 
 #define STATIC_DEBUG_LINE_DWORDS	9
 
-#define NUM_COMMON_GLOBAL_PARAMS	11
+#define NUM_COMMON_GLOBAL_PARAMS	10
 
 #define MAX_RECURSION_DEPTH		10
 
Signature · 1 line
2.35.1.273.ge6ebfd0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 27 lines · Manish Chopra

To fix a coverity complain, commit d5ac07dfbd2b ("qed: Initialize debug string array") removed "sw-platform" (one of the common global parameters) from the dump as this was used in the dump with an uninitialized string, however it did not reduce the number of common global parameters which caused the incorrect (unable to parse) register dump

this patch fixes it with reducing NUM_COMMON_GLOBAL_PARAMS bye one.

Cc Tim Gardner <[email protected]>
Cc "David S. Miller" <[email protected]>
Fixes d5ac07dfbd2b ("qed: Initialize debug string array")
---
  drivers/net/ethernet/qlogic/qed/qed_debug.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/qlogic/qed/qed_debug.c +0 -0
index e3edca187ddf..5250d1d1e49c 100644

drivers/net/ethernet/qlogic/qed/qed_debug.c struct split_type_defs { · line 495

Quoted 8 lines
drivers/net/ethernet/qlogic/qed/qed_debug.c +1 -1
@@ -489,7 +489,7 @@ struct split_type_defs {
 
  #define STATIC_DEBUG_LINE_DWORDS	9
 
-#define NUM_COMMON_GLOBAL_PARAMS	11
+#define NUM_COMMON_GLOBAL_PARAMS	10
 
  #define MAX_RECURSION_DEPTH		10
 

Looks good to me.

rtg

Signature · 3 lines
-----------
Tim Gardner
Canonical, Inc
#2 lore raw
In reply to Manish Chopra
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

Quoted 8 lines · On Fri, 1 Apr 2022 11:53:04 -0700 you wrote:

To fix a coverity complain, commit d5ac07dfbd2b ("qed: Initialize debug string array") removed "sw-platform" (one of the common global parameters) from the dump as this was used in the dump with an uninitialized string, however it did not reduce the number of common global parameters which caused the incorrect (unable to parse) register dump

[...]

Here is the summary with links:
- [net] qed: fix ethtool register dump

    https://git.kernel.org/netdev/net/c/20921c0c8609

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html