selftests/bpf: Fix file descriptor leak in load_kallsyms()
Subsystems (5)
PATCH 1/1 selftests/bpf: Fix file descriptor leak in load_kallsyms()
Currently, if sym_cnt > 0, it just returns and does not close file, fix it.
Signed-off-by Yuntao Wang <[email protected]>
--- tools/testing/selftests/bpf/trace_helpers.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
tools/testing/selftests/bpf/trace_helpers.c +5 -4
@@ -25,15 +25,12 @@ static int ksym_cmp(const void *p1, const void *p2)int load_kallsyms (void ) { -FILE *f =fopen ("/proc/kallsyms" ,"r" ); +FILE *f;char func[256 ], buf[256 ];char symbol;void *addr;int i =0 ; -if (!f) -return -ENOENT ; -/* * This is called/used from multiplace places, * load symbols just once.
@@ -41,6 +38,10 @@ int load_kallsyms(void)if (sym_cnt)return 0 ; + f =fopen ("/proc/kallsyms" ,"r" ); +if (!f) +return -ENOENT ; +while (fgets (buf,sizeof (buf), f)) {if (sscanf (buf,"%p %c %s" , &addr, &symbol, func) !=3 )break ;
Signature · 1 line
2.35.1
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:
Quoted 6 lines · On Tue, 5 Apr 2022 22:57:11 +0800 you wrote:
Currently, if
sym_cnt> 0, it just returns and does not close file, fix it.Signed-off-by Yuntao Wang <[email protected]>--- tools/testing/selftests/bpf/trace_helpers.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
Here is the summary with links:
- [bpf-next] selftests/bpf: Fix file descriptor leak in load_kallsyms()
https://git.kernel.org/bpf/bpf-next/c/2d0df01974ce
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html