Skip to contentSkip to conversation

regulator: rtq2134: Fix missing active_discharge_on setting

PATCH In review Axel Lin 3 participants 3 messages Apr 4, 2022 – Apr 6, 2022 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: rtq2134: Fix missing active_discharge_on setting

The active_discharge_on setting was missed, so output discharge resistor is always disabled. Fix it.

Fixes 0555d41497de ("regulator: rtq2134: Add support for Richtek RTQ2134 SubPMIC")
---
 drivers/regulator/rtq2134-regulator.c | 1 +
 1 file changed, 1 insertion(+)
drivers/regulator/rtq2134-regulator.c +1 -0
index f21e3f8b21f2..8e13dea354a2 100644
@@ -285,6 +285,7 @@ static const unsigned int rtq2134_buck_ramp_delay_table[] = {
 		.enable_mask = RTQ2134_VOUTEN_MASK, \
 		.active_discharge_reg = RTQ2134_REG_BUCK##_id##_CFG0, \
 		.active_discharge_mask = RTQ2134_ACTDISCHG_MASK, \
+		.active_discharge_on = RTQ2134_ACTDISCHG_MASK, \
 		.ramp_reg = RTQ2134_REG_BUCK##_id##_RSPCFG, \
 		.ramp_mask = RTQ2134_RSPUP_MASK, \
 		.ramp_delay_table = rtq2134_buck_ramp_delay_table, \
Signature · 1 line
2.32.0
maintainer
#1 lore raw
Quoted 4 lines · Axel Lin

The active_discharge_on setting was missed, so output discharge resistor is always disabled. Fix it.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: rtq2134: Fix missing active_discharge_on setting

      commit: 17049bf9de55a42ee96fd34520aff8a484677675

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

#2 lore raw
In reply to Axel Lin

於 一,2022-04-04 於 10:25 +0800,Axel Lin 提到:

Quoted 10 lines

The active_discharge_on setting was missed, so output discharge resistor is always disabled. Fix it.

Fixes 0555d41497de ("regulator: rtq2134: Add support for Richtek RTQ2134

SubPMIC")

---
 drivers/regulator/rtq2134-regulator.c | 1 +
 1 file changed, 1 insertion(+)

Hi, Axel:
Thanks for the fix.

Quoted 13 lines
drivers/regulator/rtq2134-regulator.c +1 -0
index f21e3f8b21f2..8e13dea354a2 100644
@@ -285,6 +285,7 @@ static const unsigned int rtq2134_buck_ramp_delay_table[]
 = {
 .enable_mask = RTQ2134_VOUTEN_MASK, \
 .active_discharge_reg = RTQ2134_REG_BUCK##_id##_CFG0, \
 .active_discharge_mask = RTQ2134_ACTDISCHG_MASK, \
+.active_discharge_on = RTQ2134_ACTDISCHG_MASK, \
 .ramp_reg = RTQ2134_REG_BUCK##_id##_RSPCFG, \
 .ramp_mask = RTQ2134_RSPUP_MASK, \
Quoted 1 line

.ramp_delay_table = rtq2134_buck_ramp_delay_table, \

************* Email Confidentiality Notice ********************

The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!